Venta\Config\Parser\Json

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

54.55%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	fromFile()	0	8	2
A	fromString()	0	12	2
A	supportedExtensions()	0	4	1

<?php declare(strict_types = 1);

namespace Venta\Config\Parser;

use League\Flysystem\FilesystemInterface;
use Venta\Contracts\Config\ConfigFileParser;

/**
 * Class Json
 *
 * @package Venta\Config\Parser
 */
class Json implements ConfigFileParser
{
    /**
     * @var FilesystemInterface
     */
    private $filesystem;

    /**
     * Construct function.
     *
     * @param FilesystemInterface $filesystem
     */
    public function __construct(FilesystemInterface $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * @inheritDoc
     */
    public function fromFile(string $filename): array
    {
        if ($this->filesystem->has($filename)) {
            return $this->fromString($this->filesystem->read($filename));

It seems like $this->filesystem->read($filename) targeting League\Flysystem\FilesystemInterface::read() can also be of type false; however, Venta\Config\Parser\Json::fromString() does only seem to accept string, did you maybe forget to handle an error condition?

        }

        throw new \RuntimeException(sprintf('Unable to parse configuration file: "%s".', $filename));
    }

    /**
     * @inheritDoc
     */
    public function fromString(string $configuration): array
    {
        $array = json_decode($configuration, true);
        if (json_last_error() !== JSON_ERROR_NONE) {
            throw new \RuntimeException(
                sprintf('Unable to parse configuration string: "%s".', json_last_error_msg()),
                json_last_error()
            );
        }

        return $array;
    }

    /**
     * @inheritDoc
     */
    public function supportedExtensions(): array
    {
        return ['json'];
    }
}