Vaened\Searcher\WithIndexes::search()

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function search(string $index, ?string $q): self
    {
        if ($q != null) {

It seems like you are loosely comparing $q of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $this->apply($this->getIndexProvider()->getConstraint($index, $q));

It seems like apply() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this;
    }