Vaened\Searcher\WithIndexes

Complexity

Total Complexity

2

Size/Duplication

Total Lines	11
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	search()	0	7	2

<?php
/**
 * Created by enea dhack - 13/06/2020 13:01.
 */

namespace Vaened\Searcher;

trait WithIndexes
{
    abstract protected function getIndexProvider(): Indexable;

    public function search(string $index, ?string $q): self
    {
        if ($q != null) {

It seems like you are loosely comparing $q of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $this->apply($this->getIndexProvider()->getConstraint($index, $q));

It seems like apply() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this;
    }
}