uvinum / php-kata-env

src/OtherExamples/Form.php

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
     /**
      * Form constructor.
      *
-     * @param $x
+     * @param integer $x
      */
     public function __construct($x)
     {

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     function getX()
     {
         //returns closure bound to this object and scope
-        return function ()
+        return function()
         {
             return $this->x;
         };

src/PHP7Kata/LegacyToMigrate.php

Spacing +7 added lines, -7 removed lines

@@ -25,7 +25,7 @@ 
     {
         // let's review that all items are integers!
         $result = array_map(
-            function ($value)
+            function($value)
             {
                 return (int) $value;
             },
@@ -38,7 +38,7 @@ 
     public function arraysSum(...$arrays)
     {
         return array_map(
-            function (array $array)
+            function(array $array)
             {
                 return ($array);
             },
@@ -72,7 +72,7 @@ 
         $example        = new Example();
         $not_an_example = new NotAnExample();
 
-        return $example->greetings() . ' ' . $not_an_example->greetings() . '!';
+        return $example->greetings().' '.$not_an_example->greetings().'!';
     }
 
     public function divideEnters($a, $b)
@@ -96,7 +96,7 @@ 
 
         $credit_card = preg_replace_callback(
             '/([a-z]{1})/',
-            function ($m)
+            function($m)
             {
                 return strtoupper($m[1]);
             },
@@ -105,7 +105,7 @@ 
 
         $credit_card = preg_replace_callback(
             '/([0-9]{1})/',
-            function ($m)
+            function($m)
             {
                 return 'XXX';
             },
@@ -144,7 +144,7 @@ 
     {
         list($id, $name) = $data[$number_user];
 
-        return $id . '_' . $name;
+        return $id.'_'.$name;
     }
 
     public function getAllComposedNames($data)
@@ -153,7 +153,7 @@ 
 
         foreach ($data as list($id, $name))
         {
-            $all_composed_names .= $id . '_' . $name . '|';
+            $all_composed_names .= $id.'_'.$name.'|';
         }
 
         return $all_composed_names;

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Kata\PHP7Kata;
 
-use Kata\OtherExamples\Form;
 use Kata\OtherExamples\Example;
+use Kata\OtherExamples\Form;
 use Kata\OtherExamples\NotAnExample;
 
 final class LegacyToMigrate

Braces +4 added lines, -8 removed lines

@@ -54,12 +54,10 @@ 
         if ($a == $b)
         {
             return 0;
-        }
-        elseif ($a > $b)
+        } elseif ($a > $b)
         {
             return 1;
-        }
-        else
+        } else
         {
             return -1;
         }
@@ -162,8 +160,7 @@ 
         try
         {
             $this->functionThatFails();
-        }
-        catch (FirstException $e)
+        } catch (FirstException $e)
         {
             return false;
         }
@@ -171,8 +168,7 @@ 
         try
         {
             $this->anotherFunctionThatAlsoFails();
-        }
-        catch (SecondException $e)
+        } catch (SecondException $e)
         {
             return false;
         }