CoupleCollection::offsetExists() - Code Metrics - Inspection of "Refactor models namespaces" - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — IncomprehensibleFinder/base ( 348f7f...2b8e11 )

by Albert

created 2017-03-23 10:02 UTC

CoupleCollection::offsetExists() A

↳ Parent: CoupleCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace Kata\Algorithm\Model;

class CoupleCollection implements \Iterator, \Countable, \ArrayAccess

{
    /** @var Couple[] */
    private $all_items;

    /**
     * @param Couple[] $couples_array
     */
    private function __construct(array $couples_array)
    {
        $this->all_items = $couples_array;
    }

    /**
     * @param array $people_array
     *
     * @return CoupleCollection
     */
    public static function buildAllPossibleCouplesFromPeopleArray(array $people_array): CoupleCollection
    {
        $couples = [];
        for ($i = 0; $i < count($people_array); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            for ($j = $i + 1; $j < count($people_array); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $couples[] = new Couple($people_array[$i], $people_array[$j]);
            }
        }

        return new self($couples);

    }

    public function allItems()
    {
        return $this->all_items;
    }

    public function offsetExists($offset)
    {
        return isset($this->all_items[$offset]);
    }

    public function offsetGet($offset)
    {
        return $this->all_items[$offset];
    }

    public function offsetSet($offset, $value)
    {
        return $this->all_items[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        unset($this->all_items[$offset]);
    }

    public function count()
    {
        return count($this->all_items);
    }


    public function current()
    {
        return current($this->all_items);
    }

    public function next()
    {
        next($this->all_items);
    }

    public function key()
    {
        return key($this->all_items);
    }

    public function valid()
    {
        return current($this->all_items);
    }

    public function rewind()
    {
        reset($this->all_items);
    }
}


1		<?php
2
3		namespace Kata\Algorithm\Model;
4
5		class CoupleCollection implements \Iterator, \Countable, \ArrayAccess
		0 ignored issues – show Coding Style introduced 2017-03-23 10:06 UTC by Report Bug Copy Issue Report Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
6		{
7		/** @var Couple[] */
8		private $all_items;
9
10		/**
11		* @param Couple[] $couples_array
12		*/
13	6	private function __construct(array $couples_array)
14		{
15	6	$this->all_items = $couples_array;
16	6	}
17
18		/**
19		* @param array $people_array
20		*
21		* @return CoupleCollection
22		*/
23	6	public static function buildAllPossibleCouplesFromPeopleArray(array $people_array): CoupleCollection
24		{
25	6	$couples = [];
26	6	for ($i = 0; $i < count($people_array); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2017-03-23 10:06 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
27	5	for ($j = $i + 1; $j < count($people_array); $j++) {
		0 ignored issues – show Performance Best Practice introduced 2017-03-23 10:06 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
28	4	$couples[] = new Couple($people_array[$i], $people_array[$j]);
29		}
30		}
31
32	6	return new self($couples);
33
34		}
35
36		public function allItems()
37		{
38		return $this->all_items;
39		}
40
41		public function offsetExists($offset)
42		{
43		return isset($this->all_items[$offset]);
44		}
45
46	4	public function offsetGet($offset)
47		{
48	4	return $this->all_items[$offset];
49		}
50
51		public function offsetSet($offset, $value)
52		{
53		return $this->all_items[$offset] = $value;
54		}
55
56		public function offsetUnset($offset)
57		{
58		unset($this->all_items[$offset]);
59		}
60
61	6	public function count()
62		{
63	6	return count($this->all_items);
64		}
65
66
67	4	public function current()
68		{
69	4	return current($this->all_items);
70		}
71
72	4	public function next()
73		{
74	4	next($this->all_items);
75	4	}
76
77		public function key()
78		{
79		return key($this->all_items);
80		}
81
82	4	public function valid()
83		{
84	4	return current($this->all_items);
85		}
86
87	4	public function rewind()
88		{
89	4	reset($this->all_items);
90	4	}
91		}
92

uvinum / php-kata-env

Push — IncomprehensibleFinder/base ( 348f7f...2b8e11 )

CoupleCollection::offsetExists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like