Kata\Algorithm\Model\CoupleCollection

Complexity

Total Complexity

15

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

67.65%

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	buildAllPossibleCouplesFromPeopleArray()	0	12	3
A	allItems()	0	4	1
A	offsetExists()	0	4	1
A	offsetGet()	0	4	1
A	offsetSet()	0	4	1
A	offsetUnset()	0	4	1
A	count()	0	4	1
A	current()	0	4	1
A	next()	0	4	1
A	key()	0	4	1
A	valid()	0	4	1
A	rewind()	0	4	1

<?php

namespace Kata\Algorithm\Model;

class CoupleCollection implements \Iterator, \Countable, \ArrayAccess

Since you have declared the constructor as private, maybe you should also declare the class as final.

{
    /** @var Couple[] */
    private $all_items;

    /**
     * @param Couple[] $couples_array
     */
    private function __construct(array $couples_array)
    {
        $this->all_items = $couples_array;
    }

    /**
     * @param array $people_array
     *
     * @return CoupleCollection
     */
    public static function buildAllPossibleCouplesFromPeopleArray(array $people_array): CoupleCollection
    {
        $couples = [];
        for ($i = 0; $i < count($people_array); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            for ($j = $i + 1; $j < count($people_array); $j++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $couples[] = new Couple($people_array[$i], $people_array[$j]);
            }
        }

        return new self($couples);

    }

    public function allItems()
    {
        return $this->all_items;
    }

    public function offsetExists($offset)
    {
        return isset($this->all_items[$offset]);
    }

    public function offsetGet($offset)
    {
        return $this->all_items[$offset];
    }

    public function offsetSet($offset, $value)
    {
        return $this->all_items[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        unset($this->all_items[$offset]);
    }

    public function count()
    {
        return count($this->all_items);
    }


    public function current()
    {
        return current($this->all_items);
    }

    public function next()
    {
        next($this->all_items);
    }

    public function key()
    {
        return key($this->all_items);
    }

    public function valid()
    {
        return current($this->all_items);
    }

    public function rewind()
    {
        reset($this->all_items);
    }
}