Test Failed
Pull Request — master (#46)
by
unknown
03:08
created
src/Upyun/Uploader.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,9 +31,9 @@
 block discarded – undo
31 31
         if (! $useBlock) {
32 32
             $req = new Rest($this->config);
33 33
             return $req->request('PUT', $path)
34
-                       ->withHeaders($params)
35
-                       ->withFile($stream)
36
-                       ->send();
34
+                        ->withHeaders($params)
35
+                        ->withFile($stream)
36
+                        ->send();
37 37
         } else {
38 38
             return $this->pointUpload($path, $stream, $params);
39 39
         }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
             return $req->upload($path, $stream, $params);
32 32
         }
33 33
 
34
-        if (! $useBlock) {
34
+        if (!$useBlock) {
35 35
             $req = new Rest($this->config);
36 36
             return $req->request('PUT', $path)
37 37
                        ->withHeaders($params)
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         $headers = array();
58 58
         if (is_array($params)) {
59 59
             foreach ($params as $key => $val) {
60
-                $headers['X-Upyun-Meta-' . $key] = $val;
60
+                $headers['X-Upyun-Meta-'.$key] = $val;
61 61
             }
62 62
         }
63 63
         $res = $req->request('PUT', $path)
Please login to merge, or discard this patch.
tests/bootstrap.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,15 +1,15 @@
 block discarded – undo
1 1
 <?php
2
-require dirname(__DIR__) . '/vendor/autoload.php';
2
+require dirname(__DIR__).'/vendor/autoload.php';
3 3
 
4 4
 define('USER_NAME', 'tester');
5 5
 define('PWD', 'grjxv2mxELR3');
6 6
 define('BUCKET', 'sdkimg');
7
-define('PIC_PATH', dirname(__FILE__) . '/assets/sample.jpeg');
7
+define('PIC_PATH', dirname(__FILE__).'/assets/sample.jpeg');
8 8
 define('PIC_SIZE', filesize(PIC_PATH));
9 9
 
10 10
 function getFileUrl($path)
11 11
 {
12
-    return "http://" . BUCKET . ".b0.upaiyun.com/" . ltrim($path, '/');
12
+    return "http://".BUCKET.".b0.upaiyun.com/".ltrim($path, '/');
13 13
 }
14 14
 
15 15
 function getUpyunFileSize($path)
Please login to merge, or discard this patch.
src/Upyun/Util.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -72,12 +72,12 @@
 block discarded – undo
72 72
     public static function encodeURI($url)
73 73
     {
74 74
         $unescaped = array(
75
-            '%2D'=>'-','%5F'=>'_','%2E'=>'.','%21'=>'!', '%7E'=>'~',
75
+            '%2D'=>'-', '%5F'=>'_', '%2E'=>'.', '%21'=>'!', '%7E'=>'~',
76 76
             '%2A'=>'*', '%27'=>"'", '%28'=>'(', '%29'=>')'
77 77
         );
78 78
         $reserved = array(
79
-            '%3B'=>';','%2C'=>',','%2F'=>'/','%3F'=>'?','%3A'=>':',
80
-            '%40'=>'@','%26'=>'&','%3D'=>'=','%2B'=>'+','%24'=>'$'
79
+            '%3B'=>';', '%2C'=>',', '%2F'=>'/', '%3F'=>'?', '%3A'=>':',
80
+            '%40'=>'@', '%26'=>'&', '%3D'=>'=', '%2B'=>'+', '%24'=>'$'
81 81
         );
82 82
         $score = array(
83 83
             '%23'=>'#'
Please login to merge, or discard this patch.
src/Upyun/Api/Form.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 
19 19
         $policy = Util::base64Json($params);
20 20
         $method = 'POST';
21
-        $signature = Signature::getBodySignature($this->config, $method, '/' . $params['service'], null, $policy);
21
+        $signature = Signature::getBodySignature($this->config, $method, '/'.$params['service'], null, $policy);
22 22
         $client = new Client([
23 23
             'timeout' => $this->config->timeout,
24 24
         ]);
Please login to merge, or discard this patch.
src/Upyun/Api/Pretreat.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         $method = 'POST';
44 44
         $signedHeaders = Signature::getHeaderSign($this->config, $method, $path);
45 45
 
46
-        $url = $this->config->getPretreatEndPoint() . $path;
46
+        $url = $this->config->getPretreatEndPoint().$path;
47 47
         $response = $client->request($method, $url, [
48 48
             'headers' => $signedHeaders,
49 49
             'form_params' => $params
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
64 64
             'service' => $this->config->serviceName,
65 65
             'task_ids' => implode(',', $taskIds)
66 66
         );
67
-        $path = $path . '?' . http_build_query($params);
67
+        $path = $path.'?'.http_build_query($params);
68 68
 
69 69
         $method = 'GET';
70
-        $url = $this->config->getPretreatEndPoint() . $path;
70
+        $url = $this->config->getPretreatEndPoint().$path;
71 71
         $signedHeaders = Signature::getHeaderSign($this->config, $method, $path);
72 72
         $response = $client->request($method, $url, [
73 73
             'headers' => $signedHeaders
Please login to merge, or discard this patch.
src/Upyun/Api/Rest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
     public function __construct(Config $config)
30 30
     {
31 31
         $this->config   = $config;
32
-        $this->endpoint = $config->getProtocol() . Config::$restApiEndPoint . '/' . $config->serviceName;
32
+        $this->endpoint = $config->getProtocol().Config::$restApiEndPoint.'/'.$config->serviceName;
33 33
     }
34 34
 
35 35
     public function request($method, $storagePath)
36 36
     {
37 37
         $this->method = strtoupper($method);
38
-        $this->storagePath = '/' . ltrim($storagePath, '/');
38
+        $this->storagePath = '/'.ltrim($storagePath, '/');
39 39
         return $this;
40 40
     }
41 41
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             'timeout' => $this->config->timeout,
63 63
         ]);
64 64
 
65
-        $url = $this->endpoint . $this->storagePath;
65
+        $url = $this->endpoint.$this->storagePath;
66 66
         $body = null;
67 67
         if ($this->file && $this->method === 'PUT') {
68 68
             $body = $this->file;
Please login to merge, or discard this patch.
src/Upyun/Signature.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -10,15 +10,15 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * 获取分块上传接口的签名
12 12
      */
13
-    const SIGN_MULTIPART     = 1;
13
+    const SIGN_MULTIPART = 1;
14 14
     /**
15 15
      * 生成视频处理接口的签名
16 16
      */
17
-    const SIGN_VIDEO         = 2;
17
+    const SIGN_VIDEO = 2;
18 18
     /**
19 19
      * 生成视频处理接口的签名(不需要操作员时使用)
20 20
      */
21
-    const SIGN_VIDEO_NO_OPERATOR   = 3;
21
+    const SIGN_VIDEO_NO_OPERATOR = 3;
22 22
 
23 23
     /**
24 24
      * 获取 Header 签名需要的请求头
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
         $headers = array(
41 41
             'Authorization' => $sign,
42 42
             'Date' => $gmtDate,
43
-            'User-agent' => 'Php-Sdk/' . $serviceConfig->getVersion()
43
+            'User-agent' => 'Php-Sdk/'.$serviceConfig->getVersion()
44 44
         );
45 45
         return $headers;
46 46
     }
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         return array(
61 61
             'Authorization' => "UpYun {$serviceConfig->serviceName}:{$serviceConfig->operatorName}:$sign",
62 62
             'Date' => $gmtDate,
63
-            'User-agent' => 'Php-Sdk/' . $serviceConfig->getVersion() . ' (purge api)'
63
+            'User-agent' => 'Php-Sdk/'.$serviceConfig->getVersion().' (purge api)'
64 64
         );
65 65
     }
66 66
 
@@ -93,6 +93,6 @@  discard block
 block discarded – undo
93 93
             $data[] = $contentMd5;
94 94
         }
95 95
         $signature = base64_encode(hash_hmac('sha1', implode('&', $data), $serviceConfig->operatorPassword, true));
96
-        return 'UPYUN ' . $serviceConfig->operatorName . ':' . $signature;
96
+        return 'UPYUN '.$serviceConfig->operatorName.':'.$signature;
97 97
     }
98 98
 }
Please login to merge, or discard this patch.
src/Upyun/Upyun.php 3 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $params = Util::getHeaderParams($response->getHeaders());
153 153
 
154 154
 
155
-        if (! isset($params['x-upyun-list-iter'])) {
155
+        if (!isset($params['x-upyun-list-iter'])) {
156 156
             if (is_resource($saveHandler)) {
157 157
                 Psr7\copy_to_stream($response->getBody(), Psr7\stream_for($saveHandler));
158 158
                 return true;
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
      */
257 257
     public function createDir($path)
258 258
     {
259
-        $path = rtrim($path, '/') . '/';
259
+        $path = rtrim($path, '/').'/';
260 260
         $req = new Rest($this->config);
261 261
         $res = $req->request('POST', $path)
262 262
             ->withHeader('folder', 'true')
@@ -286,9 +286,9 @@  discard block
 block discarded – undo
286 286
      */
287 287
     public function usage($path = '/')
288 288
     {
289
-        $path = rtrim($path, '/') . '/';
289
+        $path = rtrim($path, '/').'/';
290 290
         $req = new Rest($this->config);
291
-        $response = $req->request('GET', $path . '?usage')
291
+        $response = $req->request('GET', $path.'?usage')
292 292
             ->send();
293 293
 
294 294
         return $response->getBody()->getContents();
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
         $video = new Api\Pretreat($this->config);
364 364
 
365 365
         $options = array();
366
-        switch($type) {
366
+        switch ($type) {
367 367
             case self::$PROCESS_TYPE_MEDIA:
368 368
                 $options['accept'] = 'json';
369 369
                 $options['source'] = $source;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
      * 获取云存储文件/目录的基本信息
198 198
      *
199 199
      * @param string $path 云存储的文件路径
200
-     * @param array $otherHeaders 设置了后,方法将返回其他 http header 中的信息,默认为空
200
+     * @param string[] $otherHeaders 设置了后,方法将返回其他 http header 中的信息,默认为空
201 201
      *
202 202
      * @return array 返回一个数组,默认包含以下 key
203 203
      * - `x-upyun-file-type` 当 $path 是目录时,值为 *folder*,当 $path 是文件时,值为 *file*,
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     /**
298 298
      * 刷新缓存
299 299
      *
300
-     * @param array|string $urls 需要刷新的文件 url 列表
300
+     * @param string $urls 需要刷新的文件 url 列表
301 301
      *
302 302
      * @return array 刷新失败的 url 列表,若全部刷新成功则为空数组
303 303
      */
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
      * @param string $file 需要剪辑的又拍云云存储中的 m3u8 文件路径
461 461
      * @param string $saveAs 剪辑完成后新的 m3u8 文件保存路径
462 462
      * @param array $slice 需要被保留或删除的片段。
463
-     * @param bool $$isInclude 默认为 `true` 表示 `$slice` 参数描述的片段被保留,否则表示 `$slice` 参数描述的片段被删除
463
+     * @param bool $isInclude 默认为 `true` 表示 `$slice` 参数描述的片段被保留,否则表示 `$slice` 参数描述的片段被删除
464 464
      * @param bool $index 指定 `$slice` 参数的格式,默认为 `false` 表示使用时间范围描述片段,单位秒:`[<开始时间>, <结束时间>]`;`true` 表示使用 `m3u8` 文件的分片序号,从 0 开始,这种方式可以一次对多个片段操作
465 465
      *
466 466
      * @return array 见 [m3u8 剪辑 - 响应](http://docs.upyun.com/cloud/sync_video/#_6)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 namespace Upyun;
6 6
 
7 7
 use Upyun\Api\Rest;
8
-
9 8
 use GuzzleHttp\Client;
10 9
 use GuzzleHttp\Psr7;
11 10
 use GuzzleHttp;
Please login to merge, or discard this patch.
tests/UpyunTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
         $config->setFormApiKey('Mv83tlocuzkmfKKUFbz2s04FzTw=');
24 24
         $config->processNotifyUrl = 'http://localhost:9999';
25 25
         self::$upyun        = new Upyun($config);
26
-        self::$tempFilePath = __DIR__ . '/assets/test.txt';
26
+        self::$tempFilePath = __DIR__.'/assets/test.txt';
27 27
         touch(self::$tempFilePath);
28 28
     }
29 29
 
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     public function testWriteStream()
45 45
     {
46 46
         $filename = 'test.jpeg';
47
-        $f = fopen(__DIR__ . '/assets/sample.jpeg', 'rb');
47
+        $f = fopen(__DIR__.'/assets/sample.jpeg', 'rb');
48 48
         if (!$f) {
49 49
             throw new \Exception('open test file failed!');
50 50
         }
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     {
58 58
         $filename = 'test_async.jpeg';
59 59
         $newFilename = 'test_async.png';
60
-        $f = fopen(__DIR__ . '/assets/sample.jpeg', 'rb');
60
+        $f = fopen(__DIR__.'/assets/sample.jpeg', 'rb');
61 61
         if (!$f) {
62 62
             throw new \Exception('open test file failed!');
63 63
         }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         try {
82 82
             $fs->write('test.txt', 'test file content');
83 83
         } catch (\Exception $e) {
84
-            return ;
84
+            return;
85 85
         }
86 86
         throw new \Exception('should get sign error.');
87 87
     }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         try {
116 116
             self::$upyun->read('test-delete.txt');
117 117
         } catch (\Exception $e) {
118
-            return ;
118
+            return;
119 119
         }
120 120
         throw new \Exception('delete file failed');
121 121
     }
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
     public function testProcess()
218 218
     {
219 219
         $source = 'php-sdk-sample.mp4';
220
-        self::$upyun->write($source, fopen(__DIR__ . '/assets/SampleVideo_640x360_1mb.mp4', 'r'));
220
+        self::$upyun->write($source, fopen(__DIR__.'/assets/SampleVideo_640x360_1mb.mp4', 'r'));
221 221
         $result = self::$upyun->process(array(
222 222
             array('type' => 'video', 'avopts' => '/s/240p(4:3)/as/1/r/30', 'return_info' => true, 'save_as' => '/video/result.mp4')
223 223
         ), Upyun::$PROCESS_TYPE_MEDIA, $source);
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
     public function testAvMeta()
257 257
     {
258 258
         $source = 'php-sdk-sample.mp4';
259
-        self::$upyun->write($source, fopen(__DIR__ . '/assets/SampleVideo_640x360_1mb.mp4', 'r'));
259
+        self::$upyun->write($source, fopen(__DIR__.'/assets/SampleVideo_640x360_1mb.mp4', 'r'));
260 260
         $result = self::$upyun->avMeta('/php-sdk-sample.mp4');
261 261
         $this->assertTrue(count($result) === 2);
262 262
         $this->assertTrue($result['streams'][0]['type'] === 'video');
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     public function testSnapshot()
266 266
     {
267 267
         $source = 'php-sdk-sample.mp4';
268
-        self::$upyun->write($source, fopen(__DIR__ . '/assets/SampleVideo_640x360_1mb.mp4', 'r'));
268
+        self::$upyun->write($source, fopen(__DIR__.'/assets/SampleVideo_640x360_1mb.mp4', 'r'));
269 269
         $result = self::$upyun->snapshot('/php-sdk-sample.mp4', '/snapshot.jpg', '00:00:01', '720x480', 'jpg');
270 270
         $this->assertTrue($result['status_code'] === 200);
271 271
     }
Please login to merge, or discard this patch.