StickerSetArray::traverseObject() - Code Metrics - Inspection of "Implements new methods and adds new fields to exis..." - unreal4u/telegram-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dcfb29...f47acd )

by Camilo

created 2017-07-21 20:05 UTC

StickerSetArray::traverseObject() A

↳ Parent: StickerSetArray

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	4
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	0
crap	6

<?php

declare(strict_types = 1);

namespace unreal4u\TelegramAPI\Telegram\Types\Custom;

use unreal4u\TelegramAPI\Abstracts\CustomType;
use unreal4u\TelegramAPI\Telegram\Types\Sticker;
use unreal4u\TelegramAPI\Interfaces\CustomArrayType;
use Psr\Log\LoggerInterface;

/**
 * Mockup class to generate a real telegram update representation
 */
class StickerSetArray extends CustomType implements CustomArrayType
{
    public function __construct(array $data = null, LoggerInterface $logger = null)
    {
        if (count($data) !== 0) {
            foreach ($data as $id => $sticker) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $this->data[$id] = new Sticker($sticker, $logger);
            }
        }
    }

    /**
     * Traverses through our $data, yielding the result set
     *
     * @return Sticker[]

     */
    public function traverseObject()
    {
        foreach ($this->data as $sticker) {
            yield $sticker;
        }
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace unreal4u\TelegramAPI\Telegram\Types\Custom;
6
7			use unreal4u\TelegramAPI\Abstracts\CustomType;
8			use unreal4u\TelegramAPI\Telegram\Types\Sticker;
9			use unreal4u\TelegramAPI\Interfaces\CustomArrayType;
10			use Psr\Log\LoggerInterface;
11
12			/**
13			* Mockup class to generate a real telegram update representation
14			*/
15			class StickerSetArray extends CustomType implements CustomArrayType
16			{
17			public function __construct(array $data = null, LoggerInterface $logger = null)
18			{
19			if (count($data) !== 0) {
20			foreach ($data as $id => $sticker) {
			0 ignored issues – show Bug introduced 2017-05-18 22:49 UTC by Report Bug Copy Issue Report The expression `$data` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
21			$this->data[$id] = new Sticker($sticker, $logger);
22			}
23			}
24			}
25
26			/**
27			* Traverses through our $data, yielding the result set
28			*
29			* @return Sticker[]
			0 ignored issues – show Documentation introduced 2016-11-29 00:14 UTC by Report Bug Copy Issue Report Should the return type not be `\Generator`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
30			*/
31			public function traverseObject()
32			{
33			foreach ($this->data as $sticker) {
34			yield $sticker;
35			}
36			}
37			}
38

unreal4u / telegram-api

Push — master ( dcfb29...f47acd )

StickerSetArray::traverseObject() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like