unreal4u\TelegramAPI\Telegram\Types\Custom\StickerSetArray

Complexity

Total Complexity

5

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	3
A	traverseObject()	0	6	2

<?php

declare(strict_types = 1);

namespace unreal4u\TelegramAPI\Telegram\Types\Custom;

use unreal4u\TelegramAPI\Abstracts\CustomType;
use unreal4u\TelegramAPI\Telegram\Types\Sticker;
use unreal4u\TelegramAPI\Interfaces\CustomArrayType;
use Psr\Log\LoggerInterface;

/**
 * Mockup class to generate a real telegram update representation
 */
class StickerSetArray extends CustomType implements CustomArrayType
{
    public function __construct(array $data = null, LoggerInterface $logger = null)
    {
        if (count($data) !== 0) {
            foreach ($data as $id => $sticker) {

The expression $data of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                $this->data[$id] = new Sticker($sticker, $logger);
            }
        }
    }

    /**
     * Traverses through our $data, yielding the result set
     *
     * @return Sticker[]

Should the return type not be \Generator?

     */
    public function traverseObject()
    {
        foreach ($this->data as $sticker) {
            yield $sticker;
        }
    }
}