Application\Repository\HasNames::getNames()

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes

0

<?php
    public function getNames(?Site $site = null): array
    {
        $connection = $this->getEntityManager()->getConnection();

It seems like getEntityManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $table = $this->getClassMetadata()->getTableName();

It seems like getClassMetadata() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $table = $connection->quoteIdentifier($table);

        $where = $site ? ' WHERE site = ' . $connection->quote($site->value) : '';
        $sql = 'SELECT id, name FROM ' . $table . $where . ' ORDER BY name ASC';

        $records = $connection->executeQuery($sql)->fetchAllAssociative();

        $result = [];
        foreach ($records as $r) {
            $result[$r['name']] = $r['id'];
        }

        return $result;
    }