Application\Repository\HasNames

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getNames()	0	17	3

<?php

declare(strict_types=1);

namespace Application\Repository;

use Application\Enum\Site;

/**
 * Trait for all repositories with a name.
 */
trait HasNames
{
    /**
     * Returns an array of names and their ID for all entries in the DB.
     */
    public function getNames(?Site $site = null): array
    {
        $connection = $this->getEntityManager()->getConnection();

It seems like getEntityManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $table = $this->getClassMetadata()->getTableName();

It seems like getClassMetadata() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $table = $connection->quoteIdentifier($table);

        $where = $site ? ' WHERE site = ' . $connection->quote($site->value) : '';
        $sql = 'SELECT id, name FROM ' . $table . $where . ' ORDER BY name ASC';

        $records = $connection->executeQuery($sql)->fetchAllAssociative();

        $result = [];
        foreach ($records as $r) {
            $result[$r['name']] = $r['id'];
        }

        return $result;
    }
}