YahooController::__construct() - Code Metrics - unicodeveloper/laravel-hackathon-starter - Measure and Improve Code Quality continuously with Scrutinizer

YahooController::__construct() A
last analyzed 2020-07-02 17:45 UTC

↳ Parent: YahooController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use GuzzleHttp\Client;
use App\Http\Requests;

class YahooController extends Controller
{
    const YAHOO_API = 'https://query.yahooapis.com/v1/public/yql';
    /**
     * Instance of Guzzle Client
     * @var object
     */
    protected $client;

    /**
     * BaseUrl
     * @var string
     */
    protected $baseUrl;

    /**
     * Initialize the Controller with necessary arguments
     */
    public function __construct()
    {
         $this->baseUrl = self::YAHOO_API;
         $this->client = new Client(['base_uri' => $this->baseUrl]);

         $query = "SELECT * FROM weather.forecast WHERE (location = 10007)";

         $relativeUrl = '?q=' . $query . '&format=json';
         $this->setGetResponse($relativeUrl);
    }

    /**
     * Get the response from Yahoo API
     * @param string $relativeUrl
     */
    private function setGetResponse($relativeUrl)
    {
        $this->response = $this->client->get($this->baseUrl . $relativeUrl, []);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the whole response from a get operation
     * @return array
     */
    private function getResponse()
    {
        return json_decode($this->response->getBody(), true);
    }

    /**
     * Get the data response from a get operation
     * @return array
     */
    private function getData()
    {
        return $this->getResponse()['query']['results']['channel'];
    }


     /**
     * Return all data to the Yahoo API dashboard
     * @return mixed
     */
    public function getPage()
    {
        $data = $this->getData();

        return view('api.yahoo')->withData($data);
    }

}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use GuzzleHttp\Client;
6			use App\Http\Requests;
7
8			class YahooController extends Controller
9			{
10			const YAHOO_API = 'https://query.yahooapis.com/v1/public/yql';
11			/**
12			* Instance of Guzzle Client
13			* @var object
14			*/
15			protected $client;
16
17			/**
18			* BaseUrl
19			* @var string
20			*/
21			protected $baseUrl;
22
23			/**
24			* Initialize the Controller with necessary arguments
25			*/
26			public function __construct()
27			{
28			$this->baseUrl = self::YAHOO_API;
29			$this->client = new Client(['base_uri' => $this->baseUrl]);
30
31			$query = "SELECT * FROM weather.forecast WHERE (location = 10007)";
32
33			$relativeUrl = '?q=' . $query . '&format=json';
34			$this->setGetResponse($relativeUrl);
35			}
36
37			/**
38			* Get the response from Yahoo API
39			* @param string $relativeUrl
40			*/
41			private function setGetResponse($relativeUrl)
42			{
43			$this->response = $this->client->get($this->baseUrl . $relativeUrl, []);
			0 ignored issues – show Bug introduced 2016-02-19 03:46 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			}
45
46			/**
47			* Get the whole response from a get operation
48			* @return array
49			*/
50			private function getResponse()
51			{
52			return json_decode($this->response->getBody(), true);
53			}
54
55			/**
56			* Get the data response from a get operation
57			* @return array
58			*/
59			private function getData()
60			{
61			return $this->getResponse()['query']['results']['channel'];
62			}
63
64
65			/**
66			* Return all data to the Yahoo API dashboard
67			* @return mixed
68			*/
69			public function getPage()
70			{
71			$data = $this->getData();
72
73			return view('api.yahoo')->withData($data);
74			}
75
76			}
77

unicodeveloper / laravel-hackathon-starter

YahooController::__construct() A last analyzed 2020-07-02 17:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

YahooController::__construct() A
last analyzed 2020-07-02 17:45 UTC