App\Http\Controllers\YahooController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	setGetResponse()	0	4	1
A	getResponse()	0	4	1
A	getData()	0	4	1
A	getPage()	0	6	1

<?php

namespace App\Http\Controllers;

use GuzzleHttp\Client;
use App\Http\Requests;

class YahooController extends Controller
{
    const YAHOO_API = 'https://query.yahooapis.com/v1/public/yql';
    /**
     * Instance of Guzzle Client
     * @var object
     */
    protected $client;

    /**
     * BaseUrl
     * @var string
     */
    protected $baseUrl;

    /**
     * Initialize the Controller with necessary arguments
     */
    public function __construct()
    {
         $this->baseUrl = self::YAHOO_API;
         $this->client = new Client(['base_uri' => $this->baseUrl]);

         $query = "SELECT * FROM weather.forecast WHERE (location = 10007)";

         $relativeUrl = '?q=' . $query . '&format=json';
         $this->setGetResponse($relativeUrl);
    }

    /**
     * Get the response from Yahoo API
     * @param string $relativeUrl
     */
    private function setGetResponse($relativeUrl)
    {
        $this->response = $this->client->get($this->baseUrl . $relativeUrl, []);

The property response does not exist. Did you maybe forget to declare it?

    }

    /**
     * Get the whole response from a get operation
     * @return array
     */
    private function getResponse()
    {
        return json_decode($this->response->getBody(), true);
    }

    /**
     * Get the data response from a get operation
     * @return array
     */
    private function getData()
    {
        return $this->getResponse()['query']['results']['channel'];
    }


     /**
     * Return all data to the Yahoo API dashboard
     * @return mixed
     */
    public function getPage()
    {
        $data = $this->getData();

        return view('api.yahoo')->withData($data);
    }

}