AsyncHandler::send() - Code Metrics - Inspection of "avoid escapeshellarg fatal errors (#46)" - understand/understand-laravel5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a54abf...48ef6d )

by Aivis

created 2020-02-26 08:23 UTC

AsyncHandler::send() A

↳ Parent: AsyncHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php namespace Understand\UnderstandLaravel5\Handlers;

class AsyncHandler extends BaseHandler
{

    /**
     * @param string $escapedData
     * @return string|void
     */
    protected function send($escapedData)
    {
        $parts = [
            'curl',
            '-X POST',
            '--cacert',
            $this->sslBundlePath,
            '-d',
            $escapedData,
            $this->getEndpoint(),
            '> /dev/null 2>&1 &'
        ];

        $cmd = implode(' ', $parts);

        exec($cmd);
    }

    /**
     * @param $requestData
     * @return string|void
     */
    protected function escapeshellarg($requestData)
    {
        // the `escapeshellarg` function throws a fatal error in Unix if the size exceeds 2097152 bytes (~2mb)
        if (strlen($requestData) >= 2000000)
        {
            return;
        }

        return escapeshellarg($requestData);
    }

    /**
     * Serialize data and send to storage
     *
     * @param array $requestData
     * @return void
     */
    public function handle(array $requestData)
    {
        $json = json_encode($requestData);
        $escapedData = $this->escapeshellarg($json);

        if ($escapedData)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
        {
            return $this->send($escapedData);

        }
    }
}


1			<?php namespace Understand\UnderstandLaravel5\Handlers;
2
3			class AsyncHandler extends BaseHandler
4			{
5
6			/**
7			* @param string $escapedData
8			* @return string\|void
9			*/
10			protected function send($escapedData)
11			{
12			$parts = [
13			'curl',
14			'-X POST',
15			'--cacert',
16			$this->sslBundlePath,
17			'-d',
18			$escapedData,
19			$this->getEndpoint(),
20			'> /dev/null 2>&1 &'
21			];
22
23			$cmd = implode(' ', $parts);
24
25			exec($cmd);
26			}
27
28			/**
29			* @param $requestData
30			* @return string\|void
31			*/
32			protected function escapeshellarg($requestData)
33			{
34			// the `escapeshellarg` function throws a fatal error in Unix if the size exceeds 2097152 bytes (~2mb)
35			if (strlen($requestData) >= 2000000)
36			{
37			return;
38			}
39
40			return escapeshellarg($requestData);
41			}
42
43			/**
44			* Serialize data and send to storage
45			*
46			* @param array $requestData
47			* @return void
48			*/
49			public function handle(array $requestData)
50			{
51			$json = json_encode($requestData);
52			$escapedData = $this->escapeshellarg($json);
53
54			if ($escapedData)
			0 ignored issues – show Bug Best Practice introduced 2020-02-26 08:12 UTC by Report Bug Copy Issue Report The expression `$escapedData` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
55			{
56			return $this->send($escapedData);
			0 ignored issues – show Bug Compatibility introduced 2020-02-26 08:12 UTC by Report Bug Copy Issue Report The expression `$this->send($escapedData);` of type `string\|null` adds the type `string` to the return on line 56 which is incompatible with the return type of the parent method `Understand\UnderstandLar...ers\BaseHandler::handle` of type `array`. Loading history...
57			}
58			}
59			}
60

understand / understand-laravel5

Push — master ( a54abf...48ef6d )

AsyncHandler::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like