Understand\UnderstandLaravel5\Handlers\AsyncHandler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	17	1
A	escapeshellarg()	0	10	2
A	handle()	0	10	2

<?php namespace Understand\UnderstandLaravel5\Handlers;

class AsyncHandler extends BaseHandler
{

    /**
     * @param string $escapedData
     * @return string|void
     */
    protected function send($escapedData)
    {
        $parts = [
            'curl',
            '-X POST',
            '--cacert',
            $this->sslBundlePath,
            '-d',
            $escapedData,
            $this->getEndpoint(),
            '> /dev/null 2>&1 &'
        ];

        $cmd = implode(' ', $parts);

        exec($cmd);
    }

    /**
     * @param $requestData
     * @return string|void
     */
    protected function escapeshellarg($requestData)
    {
        // the `escapeshellarg` function throws a fatal error in Unix if the size exceeds 2097152 bytes (~2mb)
        if (strlen($requestData) >= 2000000)
        {
            return;
        }

        return escapeshellarg($requestData);
    }

    /**
     * Serialize data and send to storage
     *
     * @param array $requestData
     * @return void
     */
    public function handle(array $requestData)
    {
        $json = json_encode($requestData);
        $escapedData = $this->escapeshellarg($json);

        if ($escapedData)

The expression $escapedData of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

        {
            return $this->send($escapedData);

The expression $this->send($escapedData); of type string|null adds the type string to the return on line 56 which is incompatible with the return type of the parent method Understand\UnderstandLaravel5\Handlers\BaseHandler::handle of type array.

        }
    }
}