DevicesDataTable::query() - Code Metrics - Inspection of "Merge pull request #15 from uidaho/unit-controller" - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ffe767...90fa06 )

by Brandon

created 2017-09-14 20:48 UTC

DevicesDataTable::query() A

↳ Parent: DevicesDataTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
ccs	0
cts	7
cp	0
rs	9.4285
cc	1
eloc	10
nc	1
nop	0
crap	2

<?php

namespace App\DataTables;

use App\Device;
use Yajra\Datatables\Services\DataTable;

class DevicesDataTable extends DataTable
{
    /**
     * Build DataTable class.
     *
     * @return \Yajra\Datatables\Engines\BaseEngine
     */
    public function dataTable()
    {
        return $this->datatables
            ->eloquent($this->query())
            ->addColumn('action', 'device.action')
            ->blacklist(['action'])
            ->setRowClass(function ($device) {
                return $device->trashed() ? 'alert-danger' : "";
            });
    }

    /**
     * Get the query object to be processed by dataTables.
     *
     * @return \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|\Illuminate\Support\Collection
     */
    public function query()
    {
        $query = Device::query()

                        ->select([
                            'devices.id as id',
                            'devices.name as name',
                            'locations.name as location',
                            'sites.name as site'
                        ])
                        ->leftJoin('locations', 'devices.location_id', '=', 'locations.id')
                        ->leftJoin('sites', 'locations.site_id', '=', 'sites.id');
    
    
        return $this->applyScopes($query);
    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\Datatables\Html\Builder
     */
    public function html()

    {
        return $this->builder()
                    ->columns($this->getColumns())
                    //->minifiedAjax('')
                    //->addAction(['width' => '160px'])

                    ->parameters([
                        'dom'     => 'Bfrtip',
                        'order'   => [[0, 'asc']],
                        'buttons' => [
                            'export',
                            'print',
                            'reset',
                            'reload',
                        ],
                        'paging' => true,
                        'searching' => true,
                        'info' => true,
                        'searchDelay' => 500,
                    ]);
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns()
    {
        return [
            'id',
            'name',
            'location',
            'site',
            ['name' => 'action', 'data' => 'action', 'title' => 'Actions', 'render' => null, 'searchable' => false, 'orderable' => false, 'exportable' => false, 'printable' => true, 'footer' => ''],
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'devices_' . time();
    }
}


1		<?php
2
3		namespace App\DataTables;
4
5		use App\Device;
6		use Yajra\Datatables\Services\DataTable;
7
8		class DevicesDataTable extends DataTable
9		{
10		/**
11		* Build DataTable class.
12		*
13		* @return \Yajra\Datatables\Engines\BaseEngine
14		*/
15		public function dataTable()
16		{
17		return $this->datatables
18		->eloquent($this->query())
19		->addColumn('action', 'device.action')
20		->blacklist(['action'])
21		->setRowClass(function ($device) {
22		return $device->trashed() ? 'alert-danger' : "";
23		});
24		}
25
26		/**
27		* Get the query object to be processed by dataTables.
28		*
29		* @return \Illuminate\Database\Eloquent\Builder\|\Illuminate\Database\Query\Builder\|\Illuminate\Support\Collection
30		*/
31		public function query()
32		{
33		$query = Device::query()
		0 ignored issues – show Bug introduced 2017-09-14 20:50 UTC by Report Bug Copy Issue Report The method `select()` does not exist on `Illuminate\Database\Eloquent\Builder`. Did you maybe mean `createSelectWithConstraint()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
34		->select([
35		'devices.id as id',
36		'devices.name as name',
37		'locations.name as location',
38		'sites.name as site'
39		])
40		->leftJoin('locations', 'devices.location_id', '=', 'locations.id')
41		->leftJoin('sites', 'locations.site_id', '=', 'sites.id');
42
43
44		return $this->applyScopes($query);
45		}
46
47		/**
48		* Optional method if you want to use html builder.
49		*
50		* @return \Yajra\Datatables\Html\Builder
51		*/
52	View Code Duplication	public function html()
		1 ignored issue – show Duplication introduced 2017-09-14 20:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		return $this->builder()
55		->columns($this->getColumns())
56		//->minifiedAjax('')
57		//->addAction(['width' => '160px'])
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-20 06:57 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58		->parameters([
59		'dom' => 'Bfrtip',
60		'order' => [[0, 'asc']],
61		'buttons' => [
62		'export',
63		'print',
64		'reset',
65		'reload',
66		],
67		'paging' => true,
68		'searching' => true,
69		'info' => true,
70		'searchDelay' => 500,
71		]);
72		}
73
74		/**
75		* Get columns.
76		*
77		* @return array
78		*/
79		protected function getColumns()
80		{
81		return [
82		'id',
83		'name',
84		'location',
85		'site',
86		['name' => 'action', 'data' => 'action', 'title' => 'Actions', 'render' => null, 'searchable' => false, 'orderable' => false, 'exportable' => false, 'printable' => true, 'footer' => ''],
87		];
88		}
89
90		/**
91		* Get filename for export.
92		*
93		* @return string
94		*/
95		protected function filename()
96		{
97		return 'devices_' . time();
98		}
99		}
100

uidaho / smartsettia

Push — master ( ffe767...90fa06 )

DevicesDataTable::query() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like