App\DataTables\DevicesDataTable

Complexity

Total Complexity

6

Size/Duplication

Total Lines	92
Duplicated Lines	22.83 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	dataTable()	0	10	2
A	query()	0	15	1
A	html()	21	21	1
A	getColumns()	0	10	1
A	filename()	0	4	1

<?php

namespace App\DataTables;

use App\Device;
use Yajra\Datatables\Services\DataTable;

class DevicesDataTable extends DataTable
{
    /**
     * Build DataTable class.
     *
     * @return \Yajra\Datatables\Engines\BaseEngine
     */
    public function dataTable()
    {
        return $this->datatables
            ->eloquent($this->query())
            ->addColumn('action', 'device.action')
            ->blacklist(['action'])
            ->setRowClass(function ($device) {
                return $device->trashed() ? 'alert-danger' : "";
            });
    }

    /**
     * Get the query object to be processed by dataTables.
     *
     * @return \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|\Illuminate\Support\Collection
     */
    public function query()
    {
        $query = Device::query()

The method select() does not exist on Illuminate\Database\Eloquent\Builder. Did you maybe mean createSelectWithConstraint()?

                        ->select([
                            'devices.id as id',
                            'devices.name as name',
                            'locations.name as location',
                            'sites.name as site'
                        ])
                        ->leftJoin('locations', 'devices.location_id', '=', 'locations.id')
                        ->leftJoin('sites', 'locations.site_id', '=', 'sites.id');
    
    
        return $this->applyScopes($query);
    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\Datatables\Html\Builder
     */
    public function html()

This method seems to be duplicated in your project.

    {
        return $this->builder()
                    ->columns($this->getColumns())
                    //->minifiedAjax('')
                    //->addAction(['width' => '160px'])

73% of this comment could be valid code. Did you maybe forget this after debugging?

                    ->parameters([
                        'dom'     => 'Bfrtip',
                        'order'   => [[0, 'asc']],
                        'buttons' => [
                            'export',
                            'print',
                            'reset',
                            'reload',
                        ],
                        'paging' => true,
                        'searching' => true,
                        'info' => true,
                        'searchDelay' => 500,
                    ]);
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns()
    {
        return [
            'id',
            'name',
            'location',
            'site',
            ['name' => 'action', 'data' => 'action', 'title' => 'Actions', 'render' => null, 'searchable' => false, 'orderable' => false, 'exportable' => false, 'printable' => true, 'footer' => ''],
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'devices_' . time();
    }
}