uidaho / smartsettia

app/Http/Controllers/DashboardController.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Request;
-
 class DashboardController extends Controller
 {
     /**

app/Http/Controllers/HomeController.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Request;
-
 class HomeController extends Controller
 {
     /**

app/Notifications/InvoicePaid.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Bus\Queueable;
 use Illuminate\Notifications\Notification;
-use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Notifications\Messages\NexmoMessage;
 
 class InvoicePaid extends Notification

app/Http/Controllers/ImageController.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Request;
 use Intervention\Image\Facades\Image as Image;
 
 class ImageController extends Controller

Spacing +4 added lines, -4 removed lines

@@ -26,13 +26,13 @@ 
     public function show($device_id)
     {
         $storagePath = storage_path('app/images/devices/');
-        $imagePath = glob($storagePath . $device_id . "*" . ".jpg");
+        $imagePath = glob($storagePath.$device_id."*".".jpg");
         
         if (!empty($imagePath))
-            $image = Image::make($imagePath[0]);
+            $image = Image::make($imagePath[ 0 ]);
         else
         {
-            $imagePath = public_path() . '/img/video_not_found.jpg';
+            $imagePath = public_path().'/img/video_not_found.jpg';
             $image = Image::make($imagePath);
         }
         
@@ -48,7 +48,7 @@ 
      */
     public function store($device_id, $binaryData)
     {
-        $storagePath = storage_path('app/images/devices/') . $device_id . '.jpg';
+        $storagePath = storage_path('app/images/devices/').$device_id.'.jpg';
         $image = Image::make($binaryData);
         $image->save($storagePath, 75);
     }

Braces +3 added lines, -3 removed lines

@@ -28,9 +28,9 @@
         $storagePath = storage_path('app/images/devices/');
         $imagePath = glob($storagePath . $device_id . "*" . ".jpg");
         
-        if (!empty($imagePath))
-            $image = Image::make($imagePath[0]);
-        else
+        if (!empty($imagePath)) {
+                    $image = Image::make($imagePath[0]);
+        } else
         {
             $imagePath = public_path() . '/img/video_not_found.jpg';
             $image = Image::make($imagePath);

app/Device.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\SoftDeletes;
-use Illuminate\Support\Facades\DB;
 
 class Device extends Model
 {

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      *
      * @var array
      */
-    protected $hidden = ['token'];
+    protected $hidden = [ 'token' ];
     
     /**
      * The attributes that are mass assignable.

app/Location.php

Spacing +2 added lines, -2 removed lines

@@ -55,9 +55,9 @@
      */
     public function orderedSiteLocationsBy($site_id, $location_id)
     {
-        $locations = self::query()->select(['id', 'name'])
+        $locations = self::query()->select([ 'id', 'name' ])
                                     ->where('site_id', '=', $site_id)
-                                    ->orderByRaw(DB::raw("(id = " . $location_id . ") DESC"))
+                                    ->orderByRaw(DB::raw("(id = ".$location_id.") DESC"))
                                     ->get();
         return $locations;
     }

app/Http/Controllers/DeviceController.php

Braces +5 added lines, -10 removed lines

@@ -79,8 +79,7 @@ 
         {
             $sites = $this->site_m->orderedSitesBy($location->site_id);
             $locations = $this->location_m->orderedSiteLocationsBy($location->site_id, $device->location_id);
-        }
-        else
+        } else
         {
             $locations = null;
             $sites = $this->site_m->all();
@@ -141,8 +140,7 @@ 
             //Create a new site
             $siteName = $request->input('new_site_name');
             $site_id = $this->site_m->createSite($siteName);
-        }
-        else
+        } else
         {
             $site_id = $request->input('site');
         }
@@ -154,8 +152,7 @@ 
             //Create a new location
             $locationName = $request->input('new_location_name');
             $location_id = $this->location_m->createLocation($locationName, $site_id);
-        }
-        else
+        } else
         {
             $location_id = $request->input('location');
         }
@@ -185,8 +182,7 @@ 
         {
             //If the user was already deleted then permanently delete it
             $this->device_m->destroy($id);
-        }
-        else
+        } else
         {
             //Remove the location from the device
             $oldLocation_id = $device->location_id;
@@ -232,8 +228,7 @@ 
             {
                 //Get the site connected to the location and delete it
                 $this->site_m->findOrFail($site_id)->delete();
-            }
-            else
+            } else
             {
                 //Delete the location that isn't used anymore
                 $oldLocation->delete();

app/Site.php

Spacing +2 added lines, -2 removed lines

@@ -42,8 +42,8 @@
      */
     public function orderedSitesBy($id)
     {
-        $sites = self::query()->select(['id', 'name'])
-                                ->orderByRaw(DB::raw("(id = " . $id . ") DESC"))
+        $sites = self::query()->select([ 'id', 'name' ])
+                                ->orderByRaw(DB::raw("(id = ".$id.") DESC"))
                                 ->get();
         return $sites;
     }

app/Http/Controllers/ApiController.php

Doc Comments +4 added lines, -4 removed lines

@@ -11,7 +11,7 @@ 
     /**
      * Creates a json response for all the devices.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */    
     public function index()
     {
@@ -23,7 +23,7 @@ 
      * Creates a json response for a specifc device.
      *
      * @param  Device  $device
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */    
     public function show(Device $device)
     {
@@ -34,7 +34,7 @@ 
      * Updates the status of a device.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(Request $request)
     {
@@ -105,7 +105,7 @@ 
      * Registers a new device.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function register(Request $request)
     {

Spacing +7 added lines, -7 removed lines

@@ -60,7 +60,7 @@ 
         
         // If validation fails, send the validation error back with status 400
         if ($validator->fails()) {
-            return response()->json(['data' => $validator->toArray()], 400);
+            return response()->json([ 'data' => $validator->toArray() ], 400);
         }
         
         // Get the device record
@@ -68,7 +68,7 @@ 
         
         // If token doesnt match then send 401 unauthorized.
         if ($request->input('token') != $device->token) {
-            return response()->json(['data' => 'Bad token.'], 401);
+            return response()->json([ 'data' => 'Bad token.' ], 401);
         }
         
         // Update the device
@@ -98,7 +98,7 @@ 
         //event(new Registered(true));
         
         // Return the new device info including the token.
-        return response()->json(['data' => $device->toArray()], 201);
+        return response()->json([ 'data' => $device->toArray() ], 201);
     }
     
     /**
@@ -117,12 +117,12 @@ 
         
         // If validation fails, send the validation error back with status 400
         if ($validator->fails()) {
-            return response()->json(['data' => $validator->toArray()], 400);
+            return response()->json([ 'data' => $validator->toArray() ], 400);
         }
         
         // If challenge string doesnt match then send 401 unauthorized.
         if ($request->input('challenge') != 'temppass') {
-            return response()->json(['data' => 'Bad challenge.'], 401);
+            return response()->json([ 'data' => 'Bad challenge.' ], 401);
         }
         
         // If the uuid already exists then just send them the record.
@@ -132,7 +132,7 @@ 
                 'uuid' => $device->uuid,
                 'id' => $device->id,
                 'token' => $device->token,
-            ]], 200);
+            ] ], 200);
         }
         
         // Create the new device
@@ -155,7 +155,7 @@ 
             'uuid' => $device->uuid,
             'id' => $device->id,
             'token' => $device->token,
-        ]], 201);
+        ] ], 201);
     }
 }