ufik / webcookcms-security-bundle

src/Webcook/Cms/SecurityBundle/Common/SecurityHelper.php

Doc Comments -1 removed lines

@@ -18,7 +18,6 @@
     /**
      * Get system resources name.
      *
-     * @param string $rootDir Root directory path.
      *
      * @return array Array of system resources.
      */

src/Webcook/Cms/SecurityBundle/Controller/LoginController.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Webcook\Cms\SecurityBundle\Controller\PublicControllerInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Security\Core\Security;
 use Webcook\Cms\SecurityBundle\Entity\User;
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
 use FOS\RestBundle\Controller\Annotations\Post;

Indentation +16 added lines, -16 removed lines

@@ -24,14 +24,14 @@ 
 class LoginController extends BaseRestController implements PublicControllerInterface
 {
 
-     /**
-     * Send an email with a link to reset user's password.
-     *
-     * @ApiDoc(
-     *  description="Send an email with a link to reset user's password."
-     * )
-     * @Post("password/email/reset", options={"i18n"=false})
-     */
+        /**
+         * Send an email with a link to reset user's password.
+         *
+         * @ApiDoc(
+         *  description="Send an email with a link to reset user's password."
+         * )
+         * @Post("password/email/reset", options={"i18n"=false})
+         */
     public function resetPasswordEmailAction(Request $request): Response
     {        
         $email = $request->request->get('email');
@@ -66,14 +66,14 @@ 
         return $this->handleView($view);
     }
 
-     /**
-     * Reset password view.
-     *
-     * @ApiDoc(
-     *  description="Reset password view."
-     * )
-     * @Get("password/reset", options={"i18n"=false})
-     */
+        /**
+         * Reset password view.
+         *
+         * @ApiDoc(
+         *  description="Reset password view."
+         * )
+         * @Get("password/reset", options={"i18n"=false})
+         */
     public function resetPasswordGetAction(Request $request): Response
     {
         $token = $request->query->get('token');

Spacing +7 added lines, -7 removed lines

@@ -37,7 +37,7 @@ 
         $email = $request->request->get('email');
         $user  = $this->getEntityManager()->getRepository('Webcook\Cms\SecurityBundle\Entity\User')->findOneBy(array('email'=> $email));
 
-        if($user === null) {
+        if ($user === null) {
             $view = $this->getViewWithMessage(null, 404, 'This email does not exist. Please enter a valid email.');
             return $this->handleView($view);
         }
@@ -57,7 +57,7 @@ 
             ->setContentType("text/html");
 
         $result = $this->get('mailer')->send($message);
-        if($result) {
+        if ($result) {
             $view = $this->getViewWithMessage(null, 200, 'Your password reset link was sent to your e-mail address.');
         } else {
             $view = $this->getViewWithMessage(null, 400, 'Cannot send an email.');
@@ -78,7 +78,7 @@ 
     {
         $token = $request->query->get('token');
         $user  = $this->getEntityManager()->getRepository('Webcook\Cms\SecurityBundle\Entity\User')->findOneBy(array('passwordResetToken'=> $token));
-        if($user === null || empty($token)){
+        if ($user === null || empty($token)) {
             $view = $this->getViewWithMessage(null, 404, 'This token is invalid.');
             return $this->handleView($view);
         }
@@ -90,7 +90,7 @@ 
 
         $view          = $this->getViewWithMessage(null, 400, 'This token has expired.');
         $diffInSeconds = $dateDiff->i * 60 + $dateDiff->s;
-        if($diffInSeconds < 600 && $dateDiff->y == 0 && $dateDiff->m == 0 && $dateDiff->d == 0 && $dateDiff->h == 0) {
+        if ($diffInSeconds < 600 && $dateDiff->y == 0 && $dateDiff->m == 0 && $dateDiff->d == 0 && $dateDiff->h == 0) {
             $view = $this->getViewWithMessage(null, 200, 'Please enter your new password.');
         }
 
@@ -110,14 +110,14 @@ 
         $password       = $request->request->get('password');
         $repeatPassword = $request->request->get('repeatPassword');
         $token          = $request->request->get('token');
-        if(empty($password) || empty($repeatPassword) || empty($token)){
+        if (empty($password) || empty($repeatPassword) || empty($token)) {
             $view = $this->getViewWithMessage(null, 400, 'Passwords and token can\'t be empty.');
             return $this->handleView($view);
         }
 
-        if($password == $repeatPassword) {
+        if ($password == $repeatPassword) {
             $user = $this->getEntityManager()->getRepository('Webcook\Cms\SecurityBundle\Entity\User')->findOneBy(array('passwordResetToken'=> $token));
-            if($user === null){
+            if ($user === null) {
                 $view = $this->getViewWithMessage(null, 404, 'This token is invalid.');
                 return $this->handleView($view);
             }

src/Webcook/Cms/SecurityBundle/Controller/SettingController.php

Doc Comments +1 added lines, -3 removed lines

@@ -136,7 +136,7 @@ 
     /**
      * Return form if is not valid, otherwise process form and return setting object.
      *
-     * @param [type] $setting
+     * @param Setting $setting
      * @param string $method
      *
      * @return [type]
@@ -167,8 +167,6 @@ 
      *
      *
      * @param int     $id              [description]
-     * @param int     $expectedVersion [description]
-     * @param boolean $saveLockVersion [description]
      *
      * @return Setting [description]
      */

Unused Use Statements -2 removed lines

@@ -17,8 +17,6 @@
 use FOS\RestBundle\Controller\Annotations\Get;
 use FOS\RestBundle\Controller\Annotations\Post;
 use FOS\RestBundle\Controller\Annotations\Put;
-use FOS\RestBundle\Controller\Annotations\Delete;
-use Doctrine\DBAL\LockMode;
 
 /**
  * REST api controller - setting management.

src/Webcook/Cms/SecurityBundle/Controller/UserController.php

Doc Comments +1 added lines, -2 removed lines

@@ -178,7 +178,7 @@ 
     /**
      * Return form if is not valid, otherwise process form and return role object.
      *
-     * @param [type] $user
+     * @param User $user
      * @param string $method
      *
      * @return [type]
@@ -223,7 +223,6 @@ 
      *
      * @param int     $id              [description]
      * @param int     $expectedVersion [description]
-     * @param boolean $saveLockVersion [description]
      *
      * @return User [description]
      */

src/Webcook/Cms/SecurityBundle/DataFixtures/ORM/LoadUserData.php

Doc Comments +3 added lines, -3 removed lines

@@ -58,7 +58,7 @@ 
     /**
      * Add admin user.
      *
-     * @param [type] $manager [description]
+     * @param ObjectManager $manager [description]
      */
     private function addAdmin($manager)
     {
@@ -81,7 +81,7 @@ 
     /**
      * Add editor user.
      *
-     * @param [type] $manager [description]
+     * @param ObjectManager $manager [description]
      */
     private function addEditor($manager)
     {
@@ -104,7 +104,7 @@ 
     /**
      * Add Test user.
      *
-     * @param [type] $manager [description]
+     * @param ObjectManager $manager [description]
      */
     private function addTestUser($manager)
     {

src/Webcook/Cms/SecurityBundle/Entity/Role.php

Doc Comments +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
     /**
      * Sets the value of name.
      *
-     * @param mixed $name the name
+     * @param string $name the name
      *
      * @return self
      */
@@ -87,7 +87,7 @@ 
     /**
      * Sets the value of role.
      *
-     * @param mixed $role the role
+     * @param string $role the role
      *
      * @return self
      */

src/Webcook/Cms/SecurityBundle/Entity/RoleResource.php

Doc Comments +8 added lines, -8 removed lines

@@ -68,7 +68,7 @@ 
      *
      * @param [type] $attribute [description]
      *
-     * @return boolean [description]
+     * @return boolean|null [description]
      */
     public function isGranted($attribute)
     {
@@ -98,7 +98,7 @@ 
     /**
      * Gets the value of view.
      *
-     * @return mixed
+     * @return boolean
      */
     public function getView()
     {
@@ -122,7 +122,7 @@ 
     /**
      * Gets the value of edit.
      *
-     * @return mixed
+     * @return boolean
      */
     public function getEdit()
     {
@@ -132,7 +132,7 @@ 
     /**
      * Sets the value of edit.
      *
-     * @param mixed $edit the edit
+     * @param boolean $edit the edit
      *
      * @return self
      */
@@ -146,7 +146,7 @@ 
     /**
      * Gets the value of delete.
      *
-     * @return mixed
+     * @return boolean
      */
     public function getDelete()
     {
@@ -156,7 +156,7 @@ 
     /**
      * Sets the value of delete.
      *
-     * @param mixed $delete the delete
+     * @param boolean $delete the delete
      *
      * @return self
      */
@@ -218,7 +218,7 @@ 
     /**
      * Gets the Insert permission.
      *
-     * @return mixed
+     * @return boolean
      */
     public function getInsert()
     {
@@ -228,7 +228,7 @@ 
     /**
      * Sets the Insert permission.
      *
-     * @param mixed $insert the insert
+     * @param boolean $insert the insert
      *
      * @return self
      */

src/Webcook/Cms/SecurityBundle/Entity/User.php

Doc Comments +5 added lines, -5 removed lines

@@ -207,7 +207,7 @@ 
     /**
      * Sets the value of email.
      *
-     * @param mixed $email the email
+     * @param string $email the email
      *
      * @return self
      */
@@ -245,7 +245,7 @@ 
     /**
      * Sets the value of username.
      *
-     * @param mixed $username the username
+     * @param string $username the username
      *
      * @return self
      */
@@ -306,7 +306,7 @@ 
     /**
      * Gets the value of settings.
      *
-     * @return mixed
+     * @return ArrayCollection
      */
     public function getSettings()
     {
@@ -335,7 +335,7 @@ 
     /**
      * Sets the value of password reset token.
      *
-     * @param mixed $passwordResetToken the passwordResetToken
+     * @param null|string $passwordResetToken the passwordResetToken
      *
      * @return self
      */
@@ -359,7 +359,7 @@ 
     /**
      * Sets the value of password reset token.
      *
-     * @param mixed $passwordResetExpiration the passwordResetExpiration
+     * @param null|\DateTime $passwordResetExpiration the passwordResetExpiration
      *
      * @return self
      */

Indentation +5 added lines, -5 removed lines

@@ -322,11 +322,11 @@
         }
     }
 
-     /**
-     * Get passwordResetToken.
-     *
-     * @inheritDoc
-     */
+        /**
+         * Get passwordResetToken.
+         *
+         * @inheritDoc
+         */
     public function getPasswordResetToken()
     {
         return $this->passwordResetToken;

Spacing +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
  * @ORM\Table(name="SecurityUser")
  * @ORM\Entity(repositoryClass="Webcook\Cms\SecurityBundle\Entity\UserRepository")
  */
-class User extends BasicEntity implements UserInterface,\Serializable
+class User extends BasicEntity implements UserInterface, \Serializable
 {
     /**
      * Username of the user.
@@ -316,7 +316,7 @@ 
     public function getSettingsByName($name)
     {
         foreach ($this->getSettings() as &$value) {
-            if($value->getName() == $name) {
+            if ($value->getName() == $name) {
                 return $value;
             }
         }

src/Webcook/Cms/SecurityBundle/Entity/UserRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
     /**
      * {@inheritdoc}
      *
-     * @param  [type] $class [description]
+     * @param  string $class [description]
      * @return [type] [description]
      */
     public function supportsClass($class)