Completed
Pull Request — master (#648)
by
unknown
12:11
created
src/Filter/Filter.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	/**
96 96
 	 * Get filter key
97 97
 	 *
98
-	 * @return mixed
98
+	 * @return string
99 99
 	 */
100 100
 	public function getKey()
101 101
 	{
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Filter;
4 4
 
Please login to merge, or discard this patch.
src/DataGrid.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -643,7 +643,7 @@  discard block
 block discarded – undo
643 643
 	/**
644 644
 	 * Get DataGrid template file
645 645
 	 *
646
-	 * @return static
646
+	 * @return string
647 647
 	 */
648 648
 	public function getTemplateFile(): string
649 649
 	{
@@ -823,6 +823,7 @@  discard block
 block discarded – undo
823 823
 
824 824
 	/**
825 825
 	 * @param  array         $sort
826
+	 * @param callable $sort_callback
826 827
 	 */
827 828
 	protected function createSorting(array $sort, ?callable $sort_callback = null): Sorting
828 829
 	{
@@ -1411,7 +1412,6 @@  discard block
 block discarded – undo
1411 1412
 	/**
1412 1413
 	 * If we want to sent some initial filter
1413 1414
 	 *
1414
-	 * @param array $filter
1415 1415
 	 * @return static
1416 1416
 	 */
1417 1417
 	public function setDefaultFilter(array $default_filter, bool $use_on_reset = true)
@@ -2530,7 +2530,7 @@  discard block
 block discarded – undo
2530 2530
 /**
2531 2531
  * Set options of select "items_per_page"
2532 2532
  *
2533
- * @param array $items_per_page_list
2533
+ * @param integer[] $items_per_page_list
2534 2534
  * @return static
2535 2535
  */
2536 2536
 	public function setItemsPerPageList(array $items_per_page_list, $include_all = true)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use DateTime;
6 6
 use Dibi\Fluent;
7
-use DibiFluent;
8 7
 use Doctrine\ORM\QueryBuilder;
9 8
 use InvalidArgumentException;
10 9
 use Iterator;
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid;
4 4
 
@@ -656,7 +656,7 @@  discard block
 block discarded – undo
656 656
 	 */
657 657
 	public function getOriginalTemplateFile(): string
658 658
 	{
659
-		return __DIR__ . '/templates/datagrid.latte';
659
+		return __DIR__.'/templates/datagrid.latte';
660 660
 	}
661 661
 
662 662
 
@@ -891,7 +891,7 @@  discard block
 block discarded – undo
891 891
 		 * Set tree view template file
892 892
 		 */
893 893
 		if (!$this->template_file) {
894
-			$this->setTemplateFile(__DIR__ . '/templates/datagrid_tree.latte');
894
+			$this->setTemplateFile(__DIR__.'/templates/datagrid_tree.latte');
895 895
 		}
896 896
 
897 897
 		return $this;
@@ -2754,7 +2754,7 @@  discard block
 block discarded – undo
2754 2754
  */
2755 2755
 	public function getSessionSectionName(): string
2756 2756
 	{
2757
-		return $this->getPresenter()->getName() . ':' . $this->getUniqueId();
2757
+		return $this->getPresenter()->getName().':'.$this->getUniqueId();
2758 2758
 	}
2759 2759
 
2760 2760
 
@@ -3265,7 +3265,7 @@  discard block
 block discarded – undo
3265 3265
 
3266 3266
 		if (!($parent instanceof PresenterComponent)) {
3267 3267
 			throw new DataGridHasToBeAttachedToPresenterComponentException(
3268
-				"DataGrid is attached to: '" . get_class($parent) . "', but instance of PresenterComponent is needed."
3268
+				"DataGrid is attached to: '".get_class($parent)."', but instance of PresenterComponent is needed."
3269 3269
 			);
3270 3270
 		}
3271 3271
 
Please login to merge, or discard this patch.
src/Traits/TButtonRenderer.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -23,6 +23,7 @@
 block discarded – undo
23 23
 	/**
24 24
 	 * Try to render item with custom renderer
25 25
 	 *
26
+	 * @param Row $row
26 27
 	 * @return mixed
27 28
 	 * @throws DataGridColumnRendererException
28 29
 	 */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Traits;
4 4
 
Please login to merge, or discard this patch.
src/Traits/TLink.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -69,6 +69,9 @@
 block discarded – undo
69 69
 	}
70 70
 
71 71
 
72
+	/**
73
+	 * @param string $href
74
+	 */
72 75
 	private function throwHierarchyLookupException(DataGrid $grid, $href, $params): void
73 76
 	{
74 77
 		$desiredHandler = get_class($grid->getParent()) . '::handle' . ucfirst($href) . '()';
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Traits;
4 4
 
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
 
72 72
 	private function throwHierarchyLookupException(DataGrid $grid, $href, $params): void
73 73
 	{
74
-		$desiredHandler = get_class($grid->getParent()) . '::handle' . ucfirst($href) . '()';
74
+		$desiredHandler = get_class($grid->getParent()).'::handle'.ucfirst($href).'()';
75 75
 
76 76
 		throw new DataGridLinkCreationException(
77 77
 			'DataGrid could not create link "'
78
-			. $href . '" - did not find any signal handler in componenet hierarchy from '
79
-			. get_class($grid->getParent()) . ' up to the '
80
-			. get_class($grid->getPresenter()) . '. '
81
-			. 'Try adding handler ' . $desiredHandler
78
+			. $href.'" - did not find any signal handler in componenet hierarchy from '
79
+			. get_class($grid->getParent()).' up to the '
80
+			. get_class($grid->getPresenter()).'. '
81
+			. 'Try adding handler '.$desiredHandler
82 82
 		);
83 83
 	}
84 84
 
Please login to merge, or discard this patch.
src/Column/ItemDetail.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Column;
4 4
 
Please login to merge, or discard this patch.
src/Column/FilterableColumn.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Column;
4 4
 
Please login to merge, or discard this patch.
src/Column/ColumnNumber.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Column;
4 4
 
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 	protected $number_format = [
19 19
 		0, // Decimals
20 20
 		'.', // Decimal point
21
-		' ',  // Thousands separator
21
+		' ', // Thousands separator
22 22
 	];
23 23
 
24 24
 	/**
Please login to merge, or discard this patch.
src/Column/ColumnDateTime.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Column;
4 4
 
Please login to merge, or discard this patch.
src/Column/ColumnText.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace Ublaboo\DataGrid\Column;
4 4
 
Please login to merge, or discard this patch.