Completed
Pull Request — master (#230)
by David
02:58
created
src/DataSource/DoctrineDataSource.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 
53 53
 	/**
54 54
 	 * @return Doctrine\ORM\Query
55
-	*/
55
+	 */
56 56
 	public function getQuery()
57 57
 	{
58 58
 		return $this->data_source->getQuery();
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 			return $column;
66 66
 		}
67 67
 
68
-		return current($this->data_source->getRootAliases()) . '.' . $column;
68
+		return current($this->data_source->getRootAliases()).'.'.$column;
69 69
 	}
70 70
 
71 71
 
Please login to merge, or discard this patch.
src/DataGrid.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1928,7 +1928,7 @@
 block discarded – undo
1928 1928
 		$parent = parent::getParent();
1929 1929
 		if (!$parent instanceof PresenterComponent) {
1930 1930
 			throw new DataGridHasToBeAttachedToPresenterComponentException(
1931
-				"DataGrid is attached to: '" . get_class($parent) . "', but instance of PresenterComponent is needed."
1931
+				"DataGrid is attached to: '".get_class($parent)."', but instance of PresenterComponent is needed."
1932 1932
 			);
1933 1933
 		}
1934 1934
 
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1203,7 +1203,6 @@  discard block
 block discarded – undo
1203 1203
 
1204 1204
 	/**
1205 1205
 	 * If we want to sent some initial filter
1206
-	 * @param array $filter
1207 1206
 	 * @param bool  $use_on_reset
1208 1207
 	 * @return static
1209 1208
 	 */
@@ -2049,7 +2048,7 @@  discard block
 block discarded – undo
2049 2048
 
2050 2049
 	/**
2051 2050
 	 * Set options of select "items_per_page"
2052
-	 * @param array $items_per_page_list
2051
+	 * @param integer[] $items_per_page_list
2053 2052
 	 * @return static
2054 2053
 	 */
2055 2054
 	public function setItemsPerPageList(array $items_per_page_list, $include_all = TRUE)
@@ -2356,7 +2355,7 @@  discard block
 block discarded – undo
2356 2355
 
2357 2356
 	/**
2358 2357
 	 * Get items detail parameters
2359
-	 * @return array
2358
+	 * @return Column\ItemDetail
2360 2359
 	 */
2361 2360
 	public function getItemsDetail()
2362 2361
 	{
@@ -2430,7 +2429,7 @@  discard block
 block discarded – undo
2430 2429
 
2431 2430
 
2432 2431
 	/**
2433
-	 * @return Nette\Forms\Container|NULL
2432
+	 * @return Utils\ItemDetailForm|null
2434 2433
 	 */
2435 2434
 	public function getItemDetailForm()
2436 2435
 	{
@@ -2532,7 +2531,7 @@  discard block
 block discarded – undo
2532 2531
 
2533 2532
 
2534 2533
 	/**
2535
-	 * @return InlineEdit|null
2534
+	 * @return InlineEdit
2536 2535
 	 */
2537 2536
 	public function getInlineEdit()
2538 2537
 	{
@@ -2580,7 +2579,7 @@  discard block
 block discarded – undo
2580 2579
 
2581 2580
 
2582 2581
 	/**
2583
-	 * @return InlineEdit|null
2582
+	 * @return InlineEdit
2584 2583
 	 */
2585 2584
 	public function getInlineAdd()
2586 2585
 	{
@@ -2644,7 +2643,7 @@  discard block
 block discarded – undo
2644 2643
 
2645 2644
 
2646 2645
 	/**
2647
-	 * @return ColumnsSummary|NULL
2646
+	 * @return ColumnsSummary
2648 2647
 	 */
2649 2648
 	public function getColumnsSummary()
2650 2649
 	{
Please login to merge, or discard this patch.
src/Column/Action.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 
11 11
 use Nette\Utils\Html;
12 12
 use Ublaboo\DataGrid\DataGrid;
13
-use Ublaboo\DataGrid\Exception\DataGridHasToBeAttachedToPresenterComponentException;
14 13
 use Ublaboo\DataGrid\Exception\DataGridException;
15 14
 use Ublaboo\DataGrid\Row;
16 15
 
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 	/**
186 186
 	 * Set icon
187 187
 	 * @param string|callable $icon
188
-	 * @return static|callable
188
+	 * @return Action
189 189
 	 * @throws DataGridException
190 190
 	 */
191 191
 	public function setIcon($icon)
@@ -270,7 +270,8 @@  discard block
 block discarded – undo
270 270
 
271 271
 	/**
272 272
 	 * Check whether given property is string or callable
273
-	 * @param  mixed $property
273
+	 * @param  callable $property
274
+	 * @param string $name
274 275
 	 * @return void
275 276
 	 * @throws DataGridException
276 277
 	 */
Please login to merge, or discard this patch.
src/Column/ColumnLink.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 
11 11
 use Nette\Utils\Html;
12 12
 use Ublaboo\DataGrid\DataGrid;
13
-use Ublaboo\DataGrid\Exception\DataGridHasToBeAttachedToPresenterComponentException;
14 13
 use Ublaboo\DataGrid\Exception\DataGridException;
15 14
 use Ublaboo\DataGrid\Row;
16 15
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 		]);
91 91
 
92 92
 		if ($this->icon) {
93
-			$a->add(Html::el('span')->class(DataGrid::$icon_prefix . $this->icon));
93
+			$a->add(Html::el('span')->class(DataGrid::$icon_prefix.$this->icon));
94 94
 
95 95
 			if (strlen($this->text)) {
96 96
 				$a->add(' ');
Please login to merge, or discard this patch.
src/DataSource/DibiFluentDataSource.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 namespace Ublaboo\DataGrid\DataSource;
10 10
 
11 11
 use DibiFluent;
12
-use Nette\Utils\Callback;
13 12
 use Nette\Utils\Strings;
14 13
 use Ublaboo\DataGrid\Filter;
15 14
 
Please login to merge, or discard this patch.
src/DataSource/FilterableDataSource.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -8,9 +8,7 @@
 block discarded – undo
8 8
 
9 9
 namespace Ublaboo\DataGrid\DataSource;
10 10
 
11
-use DibiFluent;
12 11
 use Nette\Utils\Callback;
13
-use Nette\Utils\Strings;
14 12
 use Ublaboo\DataGrid\Filter;
15 13
 
16 14
 abstract class FilterableDataSource
Please login to merge, or discard this patch.
src/Column/ColumnStatus.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
 		$this->key = $key;
50 50
 
51
-		$this->setTemplate(__DIR__ . '/../templates/column_status.latte');
51
+		$this->setTemplate(__DIR__.'/../templates/column_status.latte');
52 52
 	}
53 53
 
54 54
 
Please login to merge, or discard this patch.
src/Traits/ButtonIconTrait.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 
11 11
 use Ublaboo\DataGrid\DataGrid;
12 12
 use Nette\Utils\Html;
13
-use Ublaboo\DataGrid\Row;
14 13
 
15 14
 trait ButtonIconTrait
16 15
 {
Please login to merge, or discard this patch.
src/DataSource/ArrayDataSource.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -10,9 +10,7 @@
 block discarded – undo
10 10
 
11 11
 use Ublaboo\DataGrid\Filter\Filter;
12 12
 use Ublaboo\DataGrid\Filter\FilterDate;
13
-use Nette\Utils\Callback;
14 13
 use Nette\Utils\Strings;
15
-use Ublaboo\DataGrid\Exception\DataGridException;
16 14
 use Ublaboo\DataGrid\Exception\DataGridArrayDataSourceException;
17 15
 use Ublaboo\DataGrid\Utils\DateTimeHelper;
18 16
 use Ublaboo\DataGrid\Exception\DataGridDateTimeHelperException;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * Filter by multi select value
170 170
 	 * @param  mixed  $row
171 171
 	 * @param  FilterMultiSelect $filter
172
-	 * @return void
172
+	 * @return boolean
173 173
 	 */
174 174
 	public function applyFilterMultiSelect($row, FilterMultiSelect $filter)
175 175
 	{
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 	/**
184 184
 	 * @param  mixed  $row
185 185
 	 * @param  FilterRange $filter
186
-	 * @return void
186
+	 * @return boolean
187 187
 	 */
188 188
 	public function applyFilterRange($row, FilterRange $filter)
189 189
 	{
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 	/**
210 210
 	 * @param  mixed  $row
211 211
 	 * @param  FilterDateRange $filter
212
-	 * @return void
212
+	 * @return boolean
213 213
 	 */
214 214
 	public function applyFilterDateRange($row, FilterDateRange $filter)
215 215
 	{
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 	 * Apply fitler date and tell whether row value matches or not
271 271
 	 * @param  mixed  $row
272 272
 	 * @param  Filter $filter
273
-	 * @return mixed
273
+	 * @return boolean|null
274 274
 	 */
275 275
 	protected function applyFilterDate($row, FilterDate $filter)
276 276
 	{
Please login to merge, or discard this patch.