tzurbaev / laravel-achievements

src/AchievementsStorage.php

Doc Comments +2 added lines, -2 removed lines

@@ -378,7 +378,7 @@ 
      * @param Achievement                 $achievement
      * @param AchievementCriteriaProgress $progress
      *
-     * @return mixed
+     * @return boolean
      */
     public function setCriteriaProgressUpdated($owner, AchievementCriteria $criteria, Achievement $achievement, AchievementCriteriaProgress $progress)
     {
@@ -401,7 +401,7 @@ 
      * @param mixed $owner
      * @param array $achievements
      *
-     * @return mixed
+     * @return boolean
      */
     public function setAchievementsCompleted($owner, array $achievements)
     {

Spacing +27 added lines, -27 removed lines

@@ -64,7 +64,7 @@ 
      * @param array $args
      * @return mixed
      */
-    protected function dispatchEvent(string $type, array $args = [])
+    protected function dispatchEvent(string $type, array $args = [ ])
     {
         $className = $this->getConfigurableClassName('events', $type);
 
@@ -85,14 +85,14 @@ 
         $criterias = $this->getCriteriasByType($type, $data);
 
         if (!count($criterias)) {
-            return [];
+            return [ ];
         }
 
-        $ownerCriteriaProgress = $this->getOwnerCriteriasProgress($owner, function ($query) use ($type) {
+        $ownerCriteriaProgress = $this->getOwnerCriteriasProgress($owner, function($query) use ($type) {
             $query->where('type', $type);
         });
 
-        return $criterias->map(function ($criteria) use ($ownerCriteriaProgress) {
+        return $criterias->map(function($criteria) use ($ownerCriteriaProgress) {
             /** @var AchievementCriteriaModel $criteria */
 
             return $this->transformCriteriaWithProgress($criteria, $ownerCriteriaProgress->get($criteria->id));
@@ -112,7 +112,7 @@ 
     {
         $query = $owner->achievementCriterias();
 
-        call_user_func_array($callback, [$query]);
+        call_user_func_array($callback, [ $query ]);
 
         return $this->transformOwnerCriteriasToProgress($query->get());
     }
@@ -127,7 +127,7 @@ 
      */
     protected function getCriteriasByType(string $type, $data = null)
     {
-        return $this->getModelClass(static::MODEL_CRITERIA, function (string $className) use ($type) {
+        return $this->getModelClass(static::MODEL_CRITERIA, function(string $className) use ($type) {
             return $className::where('type', $type)->get();
         });
     }
@@ -141,14 +141,14 @@ 
      */
     protected function transformOwnerCriteriasToProgress(Collection $criterias)
     {
-        return $criterias->keyBy('id')->map(function ($criteria) {
+        return $criterias->keyBy('id')->map(function($criteria) {
             /** @var AchievementCriteriaModel $criteria */
 
             return new AchievementCriteriaProgress(
                 intval($criteria->pivot->value),
                 false,
                 intval($criteria->pivot->completed) === 1,
-                is_string($criteria->pivot->progress_data) ? json_decode($criteria->pivot->progress_data, true) : []
+                is_string($criteria->pivot->progress_data) ? json_decode($criteria->pivot->progress_data, true) : [ ]
             );
         });
     }
@@ -168,12 +168,12 @@ 
             'achievement_id' => $criteria->achievement_id,
             'type' => $criteria->type,
             'name' => $criteria->name,
-            'requirements' => $criteria->requirements ?? [],
+            'requirements' => $criteria->requirements ?? [ ],
             'max_value' => $criteria->max_value,
         ];
 
         if (!is_null($progress)) {
-            $data['progress'] = [
+            $data[ 'progress' ] = [
                 'value' => $progress->value,
                 'changed' => false,
                 'completed' => $progress->completed,
@@ -193,14 +193,14 @@ 
      */
     public function getAchievementsByCriterias(array $criterias)
     {
-        $achievementIds = array_map(function (AchievementCriteria $criteria) {
+        $achievementIds = array_map(function(AchievementCriteria $criteria) {
             return $criteria->achievementId();
         }, $criterias);
 
         $achievements = $this->getAchievementsByIds(array_unique($achievementIds));
 
         if (!count($achievements)) {
-            return [];
+            return [ ];
         }
 
         return $this->transformAchievements($achievements, $criterias)->toArray();
@@ -215,7 +215,7 @@ 
      */
     public function getAchievementsByIds(array $achievementIds)
     {
-        return $this->getModelClass(static::MODEL_ACHIEVEMENT, function (string $className) use ($achievementIds) {
+        return $this->getModelClass(static::MODEL_ACHIEVEMENT, function(string $className) use ($achievementIds) {
             return $className::whereIn('id', array_unique($achievementIds))->get();
         });
     }
@@ -234,7 +234,7 @@ 
             $achievements->load('criterias');
         }
 
-        return $achievements->map([$this, 'convertAchievementModelWithCriterias'])->toArray();
+        return $achievements->map([ $this, 'convertAchievementModelWithCriterias' ])->toArray();
     }
 
     /**
@@ -246,7 +246,7 @@ 
      */
     public function convertAchievementModelWithCriterias($achievement)
     {
-        $criterias = $achievement->criterias->map(function ($criteria) {
+        $criterias = $achievement->criterias->map(function($criteria) {
             /** @var AchievementCriteriaModel $criteria */
 
             return $this->transformCriteriaWithProgress($criteria);
@@ -265,7 +265,7 @@ 
      */
     protected function transformAchievements(Collection $achievements, array $criterias)
     {
-        return $achievements->map(function ($achievement) use ($criterias) {
+        return $achievements->map(function($achievement) use ($criterias) {
             /** @var AchievementModel $achievement */
 
             return $this->transformSingleAchievement($achievement, $criterias);
@@ -282,14 +282,14 @@ 
      */
     protected function transformSingleAchievement($achievement, array $criterias)
     {
-        $achievementCriterias = array_filter($criterias, function (AchievementCriteria $criteria) use ($achievement) {
+        $achievementCriterias = array_filter($criterias, function(AchievementCriteria $criteria) use ($achievement) {
             return $criteria->achievementId() === $achievement->id;
         });
 
         // Since we're dealing with owner-related criterias (progress exists if owner has any value),
         // we can simply count completed criterias & determine if achievement has been completed.
         $completedCriteriasCount = array_sum(
-            array_map(function (AchievementCriteria $criteria) {
+            array_map(function(AchievementCriteria $criteria) {
                 return $criteria->completed() ? 1 : 0;
             }, $achievementCriterias)
         );
@@ -316,7 +316,7 @@ 
     {
         $collection = collect($achievements);
 
-        $index = $collection->search(function (Achievement $achievement) use ($criteria) {
+        $index = $collection->search(function(Achievement $achievement) use ($criteria) {
             return $achievement->id() === $criteria->achievementId();
         });
 
@@ -340,14 +340,14 @@ 
         $criterias = $this->getCriteriasByAchievementIds($achievementIds);
 
         if (!count($criterias)) {
-            return [];
+            return [ ];
         }
 
-        $ownerCriteriaProgress = $this->getOwnerCriteriasProgress($owner, function ($query) use ($criterias) {
+        $ownerCriteriaProgress = $this->getOwnerCriteriasProgress($owner, function($query) use ($criterias) {
             $query->whereIn('achievement_criteria_model_id', $criterias->pluck('id'));
         });
 
-        $achievementsCriterias = $criterias->map(function ($criteria) use ($ownerCriteriaProgress) {
+        $achievementsCriterias = $criterias->map(function($criteria) use ($ownerCriteriaProgress) {
             /** @var AchievementCriteriaModel $criteria */
 
             return $this->transformCriteriaWithProgress($criteria, $ownerCriteriaProgress->get($criteria->id));
@@ -365,7 +365,7 @@ 
      */
     public function getCriteriasByAchievementIds(array $achievementIds)
     {
-        return $this->getModelClass(static::MODEL_CRITERIA, function (string $className) use ($achievementIds) {
+        return $this->getModelClass(static::MODEL_CRITERIA, function(string $className) use ($achievementIds) {
             return $className::whereIn('achievement_id', $achievementIds)->get();
         });
     }
@@ -390,7 +390,7 @@ 
             ],
         ]);
 
-        $this->dispatchEvent('criteria_updated', [$owner, $criteria, $achievement, $progress]);
+        $this->dispatchEvent('criteria_updated', [ $owner, $criteria, $achievement, $progress ]);
 
         return true;
     }
@@ -406,15 +406,15 @@ 
     public function setAchievementsCompleted($owner, array $achievements)
     {
         $now = Carbon::now();
-        $patch = [];
+        $patch = [ ];
 
         foreach ($achievements as $achievement) {
-            $patch[$achievement->id()] = ['completed_at' => $now];
+            $patch[ $achievement->id() ] = [ 'completed_at' => $now ];
         }
 
         $owner->achievements()->syncWithoutDetaching($patch);
 
-        $this->dispatchEvent('achievements_completed', [$owner, $achievements]);
+        $this->dispatchEvent('achievements_completed', [ $owner, $achievements ]);
 
         return true;
     }