Inspection of "Use Parsedown's parse() instead of line()" - typicalname0/4grounds - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dca0ac...77d4d0 )

by Maxwell

created 2020-08-19 20:06 UTC

Status

Indentation +106 added lines, -106 removed lines patch added patch discarded remove patch

@@ -11,142 +11,142 @@
 block discarded – undo
 }
 
 function validateCSS($validate) {
-	$DISALLOWED = array("<?php", "?>", "behavior: url", ".php", "@import", "@\import", "@/import"); 
+    $DISALLOWED = array("<?php", "?>", "behavior: url", ".php", "@import", "@\import", "@/import"); 
 
-	$validated = str_replace($DISALLOWED, "", $validate);
+    $validated = str_replace($DISALLOWED, "", $validate);
     return $validated;
 }
 function validateMarkdown($comment) {
-	$comment = htmlspecialchars($comment);
-	$Parsedown = new Parsedown();
-	$Parsedown->setSafeMode(true);
+    $comment = htmlspecialchars($comment);
+    $Parsedown = new Parsedown();
+    $Parsedown->setSafeMode(true);
 
-	return $Parsedown->parse($comment);
+    return $Parsedown->parse($comment);
 }
 
 
 function validateCaptcha($privatekey, $response) {
-	$responseData = json_decode(file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.$privatekey.'&response='.$response));
-	return $responseData->success;
+    $responseData = json_decode(file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.$privatekey.'&response='.$response));
+    return $responseData->success;
 }
 
 function requireLogin() {
-	if (!isset($_SESSION['user'])) {
-		header("Location: /login.php?r_login"); die();
-	}
+    if (!isset($_SESSION['user'])) {
+        header("Location: /login.php?r_login"); die();
+    }
 }
 
 function getGroup($id, $conn) {
-	$stmt = $conn->prepare("SELECT * FROM `groups` WHERE `id` = ?");
-	$stmt->bind_param("i", $id);
-	$stmt->execute();
-	$result = $stmt->get_result();
-	if ($result->num_rows === 0) return 'error';
-	return $result->fetch_assoc();
+    $stmt = $conn->prepare("SELECT * FROM `groups` WHERE `id` = ?");
+    $stmt->bind_param("i", $id);
+    $stmt->execute();
+    $result = $stmt->get_result();
+    if ($result->num_rows === 0) return 'error';
+    return $result->fetch_assoc();
 }
 
 function getID($user, $connection) {
-	$stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
-	$stmt->bind_param("s", $user);
-	$stmt->execute();
-	$result = $stmt->get_result();
-	if($result->num_rows === 0) return 'error';
-	while($row = $result->fetch_assoc()) {
-		$id = $row['id'];
-	} 
-	$stmt->close();
-	return $id;
+    $stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
+    $stmt->bind_param("s", $user);
+    $stmt->execute();
+    $result = $stmt->get_result();
+    if($result->num_rows === 0) return 'error';
+    while($row = $result->fetch_assoc()) {
+        $id = $row['id'];
+    } 
+    $stmt->close();
+    return $id;
 }
 
 function getName($id, $connection) {
-	$stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
-	$stmt->bind_param("s", $id);
-	$stmt->execute();
-	$result = $stmt->get_result();
-	if($result->num_rows === 0) return('error');
-	while($row = $result->fetch_assoc()) {
-		$name = htmlspecialchars($row['username']);
-	} 
-	$stmt->close();
-	return $name;
+    $stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
+    $stmt->bind_param("s", $id);
+    $stmt->execute();
+    $result = $stmt->get_result();
+    if($result->num_rows === 0) return('error');
+    while($row = $result->fetch_assoc()) {
+        $name = htmlspecialchars($row['username']);
+    } 
+    $stmt->close();
+    return $name;
 }
 
 function getPFP($user, $connection) {
-	$stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
-	$stmt->bind_param("s", $user);
-	$stmt->execute();
-	$result = $stmt->get_result();
-	if($result->num_rows === 0) return('error');
-	while($row = $result->fetch_assoc()) {
-		$pfp = htmlspecialchars($row['pfp']);
-	} 
-	$stmt->close();
-	return $pfp;
+    $stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
+    $stmt->bind_param("s", $user);
+    $stmt->execute();
+    $result = $stmt->get_result();
+    if($result->num_rows === 0) return('error');
+    while($row = $result->fetch_assoc()) {
+        $pfp = htmlspecialchars($row['pfp']);
+    } 
+    $stmt->close();
+    return $pfp;
 }
 
 function checkIfFriended($friend1, $friend2, $connection)
 {
-	$stmt = $connection->prepare("SELECT * FROM `friends` WHERE reciever = ? AND sender = ? OR reciever = ? AND sender = ?");
-	$stmt->bind_param("ssss", $friend1, $friend2, $friend2, $friend1);
-	$stmt->execute();
-	$result = $stmt->get_result();
-	if($result->num_rows === 1){ return true; }
-	return false;
+    $stmt = $connection->prepare("SELECT * FROM `friends` WHERE reciever = ? AND sender = ? OR reciever = ? AND sender = ?");
+    $stmt->bind_param("ssss", $friend1, $friend2, $friend2, $friend1);
+    $stmt->execute();
+    $result = $stmt->get_result();
+    if($result->num_rows === 1){ return true; }
+    return false;
 }
 
 function getUser($id, $connection) {
-	$userResult = array();
-	$stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
-	$stmt->bind_param("i", $id);
-	$stmt->execute();
-	$result = $stmt->get_result();
-	if($result->num_rows === 0) echo('That user does not exist.');
-	while($row = $result->fetch_assoc()) {
-		$userResult['username'] = $row['username'];
-		$userResult['id'] = $row['id'];
-		$userResult['date'] = $row['date'];
-		$userResult['bio'] = $row['bio'];
-		$userResult['css'] = $row['css'];
-		$userResult['pfp'] = $row['pfp'];
-		$userResult['badges'] = explode(';', $row['badges']);
-		$userResult['music'] = $row['music'];
-		$userResult['rank'] = $row['rank'];
-		$userResult['currentgroup'] = $row['currentgroup'];
-	}
-	$stmt->close();
-
-	$stmt = $connection->prepare("SELECT * FROM gamecomments WHERE author = ?");
-	$stmt->bind_param("s", $userResult['username']);
-	$stmt->execute();
-	$result = $stmt->get_result();
-
-	$userResult['comments'] = 0;
-	while($row = $result->fetch_assoc()) {
-		$userResult['comments']++;
-	}
-	$stmt->close();
-
-	$stmt = $connection->prepare("SELECT * FROM comments WHERE author = ?");
-	$stmt->bind_param("s", $userResult['username']);
-	$stmt->execute();
-	$result = $stmt->get_result();
-
-	$userResult['profilecomments'] = 0;
-	while($row = $result->fetch_assoc()) {
-		$userResult['profilecomments']++;
-	}
-	$stmt->close();
-
-	$stmt = $connection->prepare("SELECT * FROM files WHERE author = ? AND status='y'");
-	$stmt->bind_param("s", $userResult['username']);
-	$stmt->execute();
-	$result = $stmt->get_result();
-
-	$userResult['filesuploaded'] = 0;
-	while($row = $result->fetch_assoc()) {
-		$userResult['filesuploaded']++;
-	}
-	$stmt->close();
-	return $userResult;
+    $userResult = array();
+    $stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
+    $stmt->bind_param("i", $id);
+    $stmt->execute();
+    $result = $stmt->get_result();
+    if($result->num_rows === 0) echo('That user does not exist.');
+    while($row = $result->fetch_assoc()) {
+        $userResult['username'] = $row['username'];
+        $userResult['id'] = $row['id'];
+        $userResult['date'] = $row['date'];
+        $userResult['bio'] = $row['bio'];
+        $userResult['css'] = $row['css'];
+        $userResult['pfp'] = $row['pfp'];
+        $userResult['badges'] = explode(';', $row['badges']);
+        $userResult['music'] = $row['music'];
+        $userResult['rank'] = $row['rank'];
+        $userResult['currentgroup'] = $row['currentgroup'];
+    }
+    $stmt->close();
+
+    $stmt = $connection->prepare("SELECT * FROM gamecomments WHERE author = ?");
+    $stmt->bind_param("s", $userResult['username']);
+    $stmt->execute();
+    $result = $stmt->get_result();
+
+    $userResult['comments'] = 0;
+    while($row = $result->fetch_assoc()) {
+        $userResult['comments']++;
+    }
+    $stmt->close();
+
+    $stmt = $connection->prepare("SELECT * FROM comments WHERE author = ?");
+    $stmt->bind_param("s", $userResult['username']);
+    $stmt->execute();
+    $result = $stmt->get_result();
+
+    $userResult['profilecomments'] = 0;
+    while($row = $result->fetch_assoc()) {
+        $userResult['profilecomments']++;
+    }
+    $stmt->close();
+
+    $stmt = $connection->prepare("SELECT * FROM files WHERE author = ? AND status='y'");
+    $stmt->bind_param("s", $userResult['username']);
+    $stmt->execute();
+    $result = $stmt->get_result();
+
+    $userResult['filesuploaded'] = 0;
+    while($row = $result->fetch_assoc()) {
+        $userResult['filesuploaded']++;
+    }
+    $stmt->close();
+    return $userResult;
 }
 ?>
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -11,142 +11,142 @@
		block discarded – undo
11	11	}
12	12
13	13	function validateCSS($validate) {
14		- $DISALLOWED = array("<?php", "?>", "behavior: url", ".php", "@import", "@\import", "@/import");
	14	+ $DISALLOWED = array("<?php", "?>", "behavior: url", ".php", "@import", "@\import", "@/import");
15	15
16		- $validated = str_replace($DISALLOWED, "", $validate);
	16	+ $validated = str_replace($DISALLOWED, "", $validate);
17	17	return $validated;
18	18	}
19	19	function validateMarkdown($comment) {
20		- $comment = htmlspecialchars($comment);
21		- $Parsedown = new Parsedown();
22		- $Parsedown->setSafeMode(true);
	20	+ $comment = htmlspecialchars($comment);
	21	+ $Parsedown = new Parsedown();
	22	+ $Parsedown->setSafeMode(true);
23	23
24		- return $Parsedown->parse($comment);
	24	+ return $Parsedown->parse($comment);
25	25	}
26	26
27	27
28	28	function validateCaptcha($privatekey, $response) {
29		- $responseData = json_decode(file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.$privatekey.'&response='.$response));
30		- return $responseData->success;
	29	+ $responseData = json_decode(file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.$privatekey.'&response='.$response));
	30	+ return $responseData->success;
31	31	}
32	32
33	33	function requireLogin() {
34		- if (!isset($_SESSION['user'])) {
35		- header("Location: /login.php?r_login"); die();
36		- }
	34	+ if (!isset($_SESSION['user'])) {
	35	+ header("Location: /login.php?r_login"); die();
	36	+ }
37	37	}
38	38
39	39	function getGroup($id, $conn) {
40		- $stmt = $conn->prepare("SELECT * FROM `groups` WHERE `id` = ?");
41		- $stmt->bind_param("i", $id);
42		- $stmt->execute();
43		- $result = $stmt->get_result();
44		- if ($result->num_rows === 0) return 'error';
45		- return $result->fetch_assoc();
	40	+ $stmt = $conn->prepare("SELECT * FROM `groups` WHERE `id` = ?");
	41	+ $stmt->bind_param("i", $id);
	42	+ $stmt->execute();
	43	+ $result = $stmt->get_result();
	44	+ if ($result->num_rows === 0) return 'error';
	45	+ return $result->fetch_assoc();
46	46	}
47	47
48	48	function getID($user, $connection) {
49		- $stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
50		- $stmt->bind_param("s", $user);
51		- $stmt->execute();
52		- $result = $stmt->get_result();
53		- if($result->num_rows === 0) return 'error';
54		- while($row = $result->fetch_assoc()) {
55		- $id = $row['id'];
56		- }
57		- $stmt->close();
58		- return $id;
	49	+ $stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
	50	+ $stmt->bind_param("s", $user);
	51	+ $stmt->execute();
	52	+ $result = $stmt->get_result();
	53	+ if($result->num_rows === 0) return 'error';
	54	+ while($row = $result->fetch_assoc()) {
	55	+ $id = $row['id'];
	56	+ }
	57	+ $stmt->close();
	58	+ return $id;
59	59	}
60	60
61	61	function getName($id, $connection) {
62		- $stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
63		- $stmt->bind_param("s", $id);
64		- $stmt->execute();
65		- $result = $stmt->get_result();
66		- if($result->num_rows === 0) return('error');
67		- while($row = $result->fetch_assoc()) {
68		- $name = htmlspecialchars($row['username']);
69		- }
70		- $stmt->close();
71		- return $name;
	62	+ $stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
	63	+ $stmt->bind_param("s", $id);
	64	+ $stmt->execute();
	65	+ $result = $stmt->get_result();
	66	+ if($result->num_rows === 0) return('error');
	67	+ while($row = $result->fetch_assoc()) {
	68	+ $name = htmlspecialchars($row['username']);
	69	+ }
	70	+ $stmt->close();
	71	+ return $name;
72	72	}
73	73
74	74	function getPFP($user, $connection) {
75		- $stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
76		- $stmt->bind_param("s", $user);
77		- $stmt->execute();
78		- $result = $stmt->get_result();
79		- if($result->num_rows === 0) return('error');
80		- while($row = $result->fetch_assoc()) {
81		- $pfp = htmlspecialchars($row['pfp']);
82		- }
83		- $stmt->close();
84		- return $pfp;
	75	+ $stmt = $connection->prepare("SELECT * FROM users WHERE username = ?");
	76	+ $stmt->bind_param("s", $user);
	77	+ $stmt->execute();
	78	+ $result = $stmt->get_result();
	79	+ if($result->num_rows === 0) return('error');
	80	+ while($row = $result->fetch_assoc()) {
	81	+ $pfp = htmlspecialchars($row['pfp']);
	82	+ }
	83	+ $stmt->close();
	84	+ return $pfp;
85	85	}
86	86
87	87	function checkIfFriended($friend1, $friend2, $connection)
88	88	{
89		- $stmt = $connection->prepare("SELECT * FROM `friends` WHERE reciever = ? AND sender = ? OR reciever = ? AND sender = ?");
90		- $stmt->bind_param("ssss", $friend1, $friend2, $friend2, $friend1);
91		- $stmt->execute();
92		- $result = $stmt->get_result();
93		- if($result->num_rows === 1){ return true; }
94		- return false;
	89	+ $stmt = $connection->prepare("SELECT * FROM `friends` WHERE reciever = ? AND sender = ? OR reciever = ? AND sender = ?");
	90	+ $stmt->bind_param("ssss", $friend1, $friend2, $friend2, $friend1);
	91	+ $stmt->execute();
	92	+ $result = $stmt->get_result();
	93	+ if($result->num_rows === 1){ return true; }
	94	+ return false;
95	95	}
96	96
97	97	function getUser($id, $connection) {
98		- $userResult = array();
99		- $stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
100		- $stmt->bind_param("i", $id);
101		- $stmt->execute();
102		- $result = $stmt->get_result();
103		- if($result->num_rows === 0) echo('That user does not exist.');
104		- while($row = $result->fetch_assoc()) {
105		- $userResult['username'] = $row['username'];
106		- $userResult['id'] = $row['id'];
107		- $userResult['date'] = $row['date'];
108		- $userResult['bio'] = $row['bio'];
109		- $userResult['css'] = $row['css'];
110		- $userResult['pfp'] = $row['pfp'];
111		- $userResult['badges'] = explode(';', $row['badges']);
112		- $userResult['music'] = $row['music'];
113		- $userResult['rank'] = $row['rank'];
114		- $userResult['currentgroup'] = $row['currentgroup'];
115		- }
116		- $stmt->close();
117		-
118		- $stmt = $connection->prepare("SELECT * FROM gamecomments WHERE author = ?");
119		- $stmt->bind_param("s", $userResult['username']);
120		- $stmt->execute();
121		- $result = $stmt->get_result();
122		-
123		- $userResult['comments'] = 0;
124		- while($row = $result->fetch_assoc()) {
125		- $userResult['comments']++;
126		- }
127		- $stmt->close();
128		-
129		- $stmt = $connection->prepare("SELECT * FROM comments WHERE author = ?");
130		- $stmt->bind_param("s", $userResult['username']);
131		- $stmt->execute();
132		- $result = $stmt->get_result();
133		-
134		- $userResult['profilecomments'] = 0;
135		- while($row = $result->fetch_assoc()) {
136		- $userResult['profilecomments']++;
137		- }
138		- $stmt->close();
139		-
140		- $stmt = $connection->prepare("SELECT * FROM files WHERE author = ? AND status='y'");
141		- $stmt->bind_param("s", $userResult['username']);
142		- $stmt->execute();
143		- $result = $stmt->get_result();
144		-
145		- $userResult['filesuploaded'] = 0;
146		- while($row = $result->fetch_assoc()) {
147		- $userResult['filesuploaded']++;
148		- }
149		- $stmt->close();
150		- return $userResult;
	98	+ $userResult = array();
	99	+ $stmt = $connection->prepare("SELECT * FROM users WHERE id = ?");
	100	+ $stmt->bind_param("i", $id);
	101	+ $stmt->execute();
	102	+ $result = $stmt->get_result();
	103	+ if($result->num_rows === 0) echo('That user does not exist.');
	104	+ while($row = $result->fetch_assoc()) {
	105	+ $userResult['username'] = $row['username'];
	106	+ $userResult['id'] = $row['id'];
	107	+ $userResult['date'] = $row['date'];
	108	+ $userResult['bio'] = $row['bio'];
	109	+ $userResult['css'] = $row['css'];
	110	+ $userResult['pfp'] = $row['pfp'];
	111	+ $userResult['badges'] = explode(';', $row['badges']);
	112	+ $userResult['music'] = $row['music'];
	113	+ $userResult['rank'] = $row['rank'];
	114	+ $userResult['currentgroup'] = $row['currentgroup'];
	115	+ }
	116	+ $stmt->close();
	117	+
	118	+ $stmt = $connection->prepare("SELECT * FROM gamecomments WHERE author = ?");
	119	+ $stmt->bind_param("s", $userResult['username']);
	120	+ $stmt->execute();
	121	+ $result = $stmt->get_result();
	122	+
	123	+ $userResult['comments'] = 0;
	124	+ while($row = $result->fetch_assoc()) {
	125	+ $userResult['comments']++;
	126	+ }
	127	+ $stmt->close();
	128	+
	129	+ $stmt = $connection->prepare("SELECT * FROM comments WHERE author = ?");
	130	+ $stmt->bind_param("s", $userResult['username']);
	131	+ $stmt->execute();
	132	+ $result = $stmt->get_result();
	133	+
	134	+ $userResult['profilecomments'] = 0;
	135	+ while($row = $result->fetch_assoc()) {
	136	+ $userResult['profilecomments']++;
	137	+ }
	138	+ $stmt->close();
	139	+
	140	+ $stmt = $connection->prepare("SELECT * FROM files WHERE author = ? AND status='y'");
	141	+ $stmt->bind_param("s", $userResult['username']);
	142	+ $stmt->execute();
	143	+ $result = $stmt->get_result();
	144	+
	145	+ $userResult['filesuploaded'] = 0;
	146	+ while($row = $result->fetch_assoc()) {
	147	+ $userResult['filesuploaded']++;
	148	+ }
	149	+ $stmt->close();
	150	+ return $userResult;
151	151	}
152	152	?>
153	153	\ No newline at end of file

typicalname0 / 4grounds

Push — master ( dca0ac...77d4d0 )

Status

Category

Indentation +106 added lines, -106 removed lines patch added patch discarded remove patch