typearea / dembelo

www/src/DembeloMain/Tests/Model/ReadpathTest.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
                 $this->assertEquals($textnodeMockId, $readpathDocument->getTextnodeId());
                 $this->assertEquals($userMockId, $readpathDocument->getUserId());
                 $this->assertInstanceOf(\MongoDate::class, $readpathDocument->getTimestamp());
-                $this->assertLessThanOrEqual(1, abs($readpathDocument->getTimestamp()->sec-time()));
+                $this->assertLessThanOrEqual(1, abs($readpathDocument->getTimestamp()->sec - time()));
             });
 
         $readpath = new Readpath($readpathRepositoryMock, $this->session);

www/src/DembeloMain/Model/FavoriteManager.php

Spacing +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
     public function setFavorite(Textnode $textnode, User $user = null): void
     {
         if (null === $user) {
-            $this->session->set('favorite_'.$textnode->getTopicId(), $textnode->getArbitraryId());
+            $this->session->set('favorite_' . $textnode->getTopicId(), $textnode->getArbitraryId());
 
             return;
         }
@@ -66,7 +66,7 @@ 
     public function getFavorite(Topic $topic, User $user = null): ?string
     {
         if (null === $user) {
-            return $this->session->get('favorite_'.$topic->getId());
+            return $this->session->get('favorite_' . $topic->getId());
         }
 
         return $user->getFavorite($topic->getId());

www/src/DembeloMain/Model/FeatureToggle.php

Spacing +1 added lines, -1 removed lines

@@ -70,6 +70,6 @@
 
     private function buildParameterName(string $featureKey): string
     {
-        return 'features.'.$featureKey;
+        return 'features.' . $featureKey;
     }
 }

www/src/DembeloMain/Controller/DefaultController.php

Spacing +3 added lines, -3 removed lines

@@ -154,7 +154,7 @@ 
         $textnode = $this->textnodeRepository->getTextnodeToRead($topicId);
 
         if (null === $textnode) {
-            throw $this->createNotFoundException('No Textnode for Topic \''.$topicId.'\' found.');
+            throw $this->createNotFoundException('No Textnode for Topic \'' . $topicId . '\' found.');
         }
 
         $user = $this->getUser();
@@ -186,7 +186,7 @@ 
         $textnode = $this->textnodeRepository->findOneActiveByArbitraryId($textnodeArbitraryId);
 
         if (null === $textnode) {
-            throw $this->createNotFoundException('No Textnode with arbitrary ID \''.$textnodeArbitraryId.'\' found.');
+            throw $this->createNotFoundException('No Textnode with arbitrary ID \'' . $textnodeArbitraryId . '\' found.');
         }
 
         if ($textnode->isFinanceNode()) {
@@ -310,7 +310,7 @@ 
         $textnode = $this->textnodeRepository->findOneActiveById($textnodeId);
 
         if (null === $textnode) {
-            throw $this->createNotFoundException('No Textnode with ID \''.$textnodeId.'\' found.');
+            throw $this->createNotFoundException('No Textnode with ID \'' . $textnodeId . '\' found.');
         }
 
         $hitch = $textnode->getHitch($hitchIndex);

www/src/AdminBundle/Model/ImportTwine.php

Spacing +30 added lines, -30 removed lines

@@ -108,7 +108,7 @@ 
         $fileHandler = fopen($filenameExtracted, "rb");
 
         if ($fileHandler === false) {
-            throw new Exception("Couldn't open file '".$this->importfile->getFilename()."'");
+            throw new Exception("Couldn't open file '" . $this->importfile->getFilename() . "'");
         }
 
         $this->xmlParser = xml_parser_create("UTF-8");
@@ -136,12 +136,12 @@ 
             throw new Exception('no filename available');
         }
 
-        $extractedFilename = $this->importfile->getFilename().'.extracted';
+        $extractedFilename = $this->importfile->getFilename() . '.extracted';
 
         $fileHandle = fopen($this->importfile->getFilename(), 'r');
         $extractedFileHandle = fopen($extractedFilename, 'w');
         if ($fileHandle === false) {
-            throw new Exception("Failed to read data from file '".$this->importfile->getFilename()."'.");
+            throw new Exception("Failed to read data from file '" . $this->importfile->getFilename() . "'.");
         }
         $writing = false;
         $matches = array();
@@ -174,13 +174,13 @@ 
         $peekData = fread($fileHandler, 1024);
 
         if ($peekData === false) {
-            throw new Exception("Failed to read data from file '".$this->importfile->getFilename()."'.");
+            throw new Exception("Failed to read data from file '" . $this->importfile->getFilename() . "'.");
         }
 
         $peekDataLength = strlen($peekData);
 
         if ($peekDataLength <= 0) {
-            throw new Exception("File '".$this->importfile->getFilename()."' seems to be empty.");
+            throw new Exception("File '" . $this->importfile->getFilename() . "' seems to be empty.");
         }
 
         for ($i = 0; $i < $peekDataLength; $i++) {
@@ -193,21 +193,21 @@ 
             }
 
             if ($peekDataLength - $i < $magicStringLength) {
-                throw new Exception("File '".$this->importfile->getFilename()."' isn't a Twine archive file.");
+                throw new Exception("File '" . $this->importfile->getFilename() . "' isn't a Twine archive file.");
             }
 
             if (substr($peekData, $i, $magicStringLength) !== $magicString) {
-                throw new Exception("File '".$this->importfile->getFilename()."' isn't a Twine archive file.");
+                throw new Exception("File '" . $this->importfile->getFilename() . "' isn't a Twine archive file.");
             }
 
             if (fseek($fileHandler, 0) !== 0) {
-                throw new Exception("Couldn't reset reading position after the magic string in the Twine archive file '".$this->importfile->getFilename()."' was checked.");
+                throw new Exception("Couldn't reset reading position after the magic string in the Twine archive file '" . $this->importfile->getFilename() . "' was checked.");
             }
 
             return true;
         }
 
-        throw new Exception("File '".$this->importfile->getFilename()."' doesn't seem to be a Twine archive file.");
+        throw new Exception("File '" . $this->importfile->getFilename() . "' doesn't seem to be a Twine archive file.");
     }
 
     private function setXmlHandler(): void
@@ -229,7 +229,7 @@ 
             $errorCode = xml_get_error_code($this->xmlParser);
             $errorDescription = xml_error_string($errorCode);
 
-            throw new Exception("Error #".$errorCode.": '".$errorDescription."' occurred while the envelope head for the Twine archive was parsed.");
+            throw new Exception("Error #" . $errorCode . ": '" . $errorDescription . "' occurred while the envelope head for the Twine archive was parsed.");
         }
     }
 
@@ -239,7 +239,7 @@ 
             $errorCode = xml_get_error_code($this->xmlParser);
             $errorDescription = xml_error_string($errorCode);
 
-            throw new Exception("Error #".$errorCode.": '".$errorDescription."' occurred while the envelope foot for the Twine archive was parsed.");
+            throw new Exception("Error #" . $errorCode . ": '" . $errorDescription . "' occurred while the envelope foot for the Twine archive was parsed.");
         }
     }
 
@@ -262,7 +262,7 @@ 
                 $errorColumnNumber = xml_get_current_column_number($this->xmlParser);
                 $errorByteIndex = xml_get_current_byte_index($this->xmlParser);
 
-                throw new Exception("Error #".$errorCode.": '".$errorDescription."' occurred while parsing the Twine archive file '".$this->importfile->getFilename()."' in line ".$errorRowNumber.", character ".$errorColumnNumber." (at byte index ".$errorByteIndex.").");
+                throw new Exception("Error #" . $errorCode . ": '" . $errorDescription . "' occurred while parsing the Twine archive file '" . $this->importfile->getFilename() . "' in line " . $errorRowNumber . ", character " . $errorColumnNumber . " (at byte index " . $errorByteIndex . ").");
             }
         } while (feof($fileHandler) === false);
 
@@ -281,7 +281,7 @@ 
     private function startElementStoryData(string $name, array $attrs)
     {
         if ($this->twineRelevant === true) {
-            throw new Exception("Nested '".$name."' found in Twine archive file '".$this->importfile->getFilename()."'.");
+            throw new Exception("Nested '" . $name . "' found in Twine archive file '" . $this->importfile->getFilename() . "'.");
         }
 
         if (isset($attrs['startnode']) !== true) {
@@ -293,13 +293,13 @@ 
         }
 
         if (isset($attrs['name']) !== true) {
-            throw new Exception("There is a '".$name."' in the Twine archive file '".$this->importfile->getFilename()."' which is missing its 'name' attribute.");
+            throw new Exception("There is a '" . $name . "' in the Twine archive file '" . $this->importfile->getFilename() . "' which is missing its 'name' attribute.");
         }
 
         $twineStory = explode("-->", $attrs['name'], 2);
 
         if (count($twineStory) !== 2) {
-            throw new Exception("There is a '".$name."' in the Twine archive file '".$this->importfile->getFilename()."' which has an incomplete 'name' attribute. Twine stories must use the naming schema '?-->story name', where '?' is an existing Dembelo Topic Id. Instead, '".$attrs['name']."' was found.");
+            throw new Exception("There is a '" . $name . "' in the Twine archive file '" . $this->importfile->getFilename() . "' which has an incomplete 'name' attribute. Twine stories must use the naming schema '?-->story name', where '?' is an existing Dembelo Topic Id. Instead, '" . $attrs['name'] . "' was found.");
         }
 
         $this->topicId = $twineStory[0];
@@ -307,7 +307,7 @@ 
         $topic = $this->topicRepository->find($this->topicId);
 
         if (null === $topic) {
-            throw new Exception("The Dembelo Topic with Id '".$this->topicId."', referenced by Twine story '".$attrs['name']."' in the Twine archive file '".$this->importfile->getFilename()."', doesn't exist.");
+            throw new Exception("The Dembelo Topic with Id '" . $this->topicId . "', referenced by Twine story '" . $attrs['name'] . "' in the Twine archive file '" . $this->importfile->getFilename() . "', doesn't exist.");
         }
 
         $this->twineStartnodeId = $attrs['startnode'];
@@ -318,7 +318,7 @@ 
     private function getTwineId(string $tagString, string $textnodeTitle): string
     {
         if (empty($tagString) || !is_string($tagString)) {
-            throw new Exception('no ID given for Textnode "'.$textnodeTitle.'"');
+            throw new Exception('no ID given for Textnode "' . $textnodeTitle . '"');
         }
         $tagArray = explode(" ", $tagString);
 
@@ -331,7 +331,7 @@ 
         }
 
         if ($twineId === false) {
-            throw new Exception('no ID given for Textnode "'.$textnodeTitle.'"');
+            throw new Exception('no ID given for Textnode "' . $textnodeTitle . '"');
         }
 
         return $twineId;
@@ -340,21 +340,21 @@ 
     private function startElementPassageData(string $name, array $attrs)
     {
         if ($this->twineText !== false) {
-            throw new Exception("Nested '".$name."' found in Twine archive file '".$this->importfile->getFilename()."'.");
+            throw new Exception("Nested '" . $name . "' found in Twine archive file '" . $this->importfile->getFilename() . "'.");
         }
 
         if (isset($attrs['pid']) !== true) {
-            throw new Exception("There is a '".$name."' in the Twine archive file '".$this->importfile->getFilename()."' which is missing its 'pid' attribute.");
+            throw new Exception("There is a '" . $name . "' in the Twine archive file '" . $this->importfile->getFilename() . "' which is missing its 'pid' attribute.");
         }
 
         if (is_numeric($attrs['pid']) !== true) {
-            throw new Exception("There is a '".$name."' in the Twine archive file '".$this->importfile->getFilename()."' which hasn't a numeric value in its 'pid' attribute ('".$attrs['pid']."' was found instead).");
+            throw new Exception("There is a '" . $name . "' in the Twine archive file '" . $this->importfile->getFilename() . "' which hasn't a numeric value in its 'pid' attribute ('" . $attrs['pid'] . "' was found instead).");
         }
 
         $this->twineId = $this->getTwineId($attrs['tags'], $attrs['name']);
 
         if (array_key_exists($this->twineId, $this->textnodeMapping) === true) {
-            throw new Exception("There is a '".$name."' in the Twine archive file '".$this->importfile->getFilename()."' which has a non unique 'id' tag [".$this->twineId."], in node '".$attrs['name']."'");
+            throw new Exception("There is a '" . $name . "' in the Twine archive file '" . $this->importfile->getFilename() . "' which has a non unique 'id' tag [" . $this->twineId . "], in node '" . $attrs['name'] . "'");
         }
 
         $this->twineTextnodeName = $attrs['name'];
@@ -386,7 +386,7 @@ 
                 $this->textnode->setAccess(true);
                 $this->accessSet = true;
             } else {
-                throw new Exception("There is more than one '".$name."' in the Twine archive file '".$this->importfile->getFilename()."' with the startnode value '".$attrs['pid']."' in its 'pid' attribute.");
+                throw new Exception("There is more than one '" . $name . "' in the Twine archive file '" . $this->importfile->getFilename() . "' with the startnode value '" . $attrs['pid'] . "' in its 'pid' attribute.");
             }
         } else {
             $this->textnode->setAccess(false);
@@ -407,7 +407,7 @@ 
     private function characterData($parser, string $data)
     {
         if ($this->twineRelevant === true && $this->twineText === true) {
-            $this->textnode->setText($this->textnode->getText().$data);
+            $this->textnode->setText($this->textnode->getText() . $data);
         }
     }
 
@@ -417,7 +417,7 @@ 
         $twineName = array_search($dembeloId, $this->nodeNameMapping);
 
         if (null === $textnode) {
-            throw new Exception("The Dembelo Textnode with Id '".$dembeloId."' doesn't exist, but should by now.");
+            throw new Exception("The Dembelo Textnode with Id '" . $dembeloId . "' doesn't exist, but should by now.");
         }
 
         /** @todo The links should be exported as XML as well instead of a custom Twine inline format. */
@@ -432,7 +432,7 @@ 
                 $endPos = strpos($textnodeText, "]]", $startPos + strlen("[["));
 
                 if ($endPos === false) {
-                    throw new Exception("The Twine archive file '".$this->importfile->getFilename()."' has a textnode named '".$twineName."' which contains a malformed link that starts with '[[' but has no corresponding ']]'.");
+                    throw new Exception("The Twine archive file '" . $this->importfile->getFilename() . "' has a textnode named '" . $twineName . "' which contains a malformed link that starts with '[[' but has no corresponding ']]'.");
                 }
 
                 $content = substr($textnodeText, $startPos + strlen("[["), $endPos - ($startPos + strlen("[[")));
@@ -455,11 +455,11 @@ 
 
                 if ($hitch !== null) {
                     if ($textnode->getHitchCount() >= Textnode::HITCHES_MAXIMUM_COUNT) {
-                        throw new Exception("There is a textnode named '".$twineName."' in the Twine archive file which has more than ".Textnode::HITCHES_MAXIMUM_COUNT." links.");
+                        throw new Exception("There is a textnode named '" . $twineName . "' in the Twine archive file which has more than " . Textnode::HITCHES_MAXIMUM_COUNT . " links.");
                     }
 
                     if ($textnode->appendHitch($hitch) !== true) {
-                        throw new Exception("Failed to append hitch for the textnode named '".$twineName."' from the Twine archive file.");
+                        throw new Exception("Failed to append hitch for the textnode named '" . $twineName . "' from the Twine archive file.");
                     }
                 }
 
@@ -493,7 +493,7 @@ 
         $contentArray = explode(">:<", $content, 2);
 
         if (strlen($contentArray[0]) <= 0 || strlen($contentArray[1]) <= 0) {
-            throw new Exception("The Twine archive file contains a '".$name."' with the invalid element '[[".$contentArray[0].">:<".$contentArray[1]."]]'.");
+            throw new Exception("The Twine archive file contains a '" . $name . "' with the invalid element '[[" . $contentArray[0] . ">:<" . $contentArray[1] . "]]'.");
         }
 
         $metadata = $textnode->getMetadata();
@@ -503,7 +503,7 @@ 
         }
 
         if (array_key_exists($contentArray[0], $metadata) === true) {
-            throw new Exception("There is a textnode in the Twine archive file which contains the metadata field '".$contentArray[0]."' twice or would overwrite the already existing value of that field.");
+            throw new Exception("There is a textnode in the Twine archive file which contains the metadata field '" . $contentArray[0] . "' twice or would overwrite the already existing value of that field.");
         }
 
         $metadata[$contentArray[0]] = $contentArray[1];