Passed
Pull Request — master (#374)
by Michael
09:12 queued 03:58
created
www/src/AdminBundle/Controller/ImportController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $importfile = $this->importfileRepository->find($importfileId);
123 123
         try {
124 124
             if (null === $importfile) {
125
-                throw new \Exception('file with id ['.$importfileId.'] not found');
125
+                throw new \Exception('file with id [' . $importfileId . '] not found');
126 126
             }
127 127
             $returnValue = $this->importTwine->run($importfile);
128 128
 
@@ -159,9 +159,9 @@  discard block
 block discarded – undo
159 159
             return new Response(\json_encode($output));
160 160
         }
161 161
 
162
-        $filename = md5(uniqid('', true).$file['name']);
162
+        $filename = md5(uniqid('', true) . $file['name']);
163 163
 
164
-        move_uploaded_file($file['tmp_name'], $this->configTwineDirectory.$filename);
164
+        move_uploaded_file($file['tmp_name'], $this->configTwineDirectory . $filename);
165 165
 
166 166
         $output['filename'] = $filename;
167 167
         $output['orgname'] = $file['name'];
Please login to merge, or discard this patch.
www/src/AdminBundle/Tests/Controller/DefaultControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         /* @var $response \Symfony\Component\HttpFoundation\Response */
178 178
         $response = $this->controller->usersAction($request);
179 179
         $this->assertInstanceOf(Response::class, $response);
180
-        $this->assertJsonStringEqualsJsonString('[{"id":"id1","gender":null,"email":"email1","roles":"ROLE_ADMIN","licenseeId":"lic1","status":null,"source":null,"reason":null,"created":"'.date('Y-m-d H:i:s', 0).'","updated":"'.date('Y-m-d H:i:s', 0).'"},{"id":"id2","email":"email2","roles":"ROLE_USER","licenseeId":"lic2","status":null,"source":null,"reason":null,"gender":null,"created":"'.date('Y-m-d H:i:s', 0).'","updated":"'.date('Y-m-d H:i:s', 0).'"}]', $response->getContent());
180
+        $this->assertJsonStringEqualsJsonString('[{"id":"id1","gender":null,"email":"email1","roles":"ROLE_ADMIN","licenseeId":"lic1","status":null,"source":null,"reason":null,"created":"' . date('Y-m-d H:i:s', 0) . '","updated":"' . date('Y-m-d H:i:s', 0) . '"},{"id":"id2","email":"email2","roles":"ROLE_USER","licenseeId":"lic2","status":null,"source":null,"reason":null,"gender":null,"created":"' . date('Y-m-d H:i:s', 0) . '","updated":"' . date('Y-m-d H:i:s', 0) . '"}]', $response->getContent());
181 181
         $this->assertEquals('200', $response->getStatusCode());
182 182
     }
183 183
 
@@ -546,7 +546,7 @@  discard block
 block discarded – undo
546 546
         $this->repository = $this->getMockBuilder(DocumentRepository::class)->disableOriginalConstructor()->getMock();
547 547
         $this->container->expects($this->once())
548 548
             ->method('get')
549
-            ->with($this->equalTo('app.model_repository_'.$repository))
549
+            ->with($this->equalTo('app.model_repository_' . $repository))
550 550
             ->will($this->returnValue($this->repository));
551 551
     }
552 552
 }
Please login to merge, or discard this patch.
www/src/AdminBundle/Controller/DefaultController.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
                     //$value = $value === 'aktiv' ? 1 : 0;
99 99
                     $query->field($field)->equals((int) $value);
100 100
                 } else {
101
-                    $query->field($field)->equals(new \MongoRegex('/.*'.$value.'.*/i'));
101
+                    $query->field($field)->equals(new \MongoRegex('/.*' . $value . '.*/i'));
102 102
                 }
103 103
             }
104 104
         }
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         /* @var $repository \Doctrine\ODM\MongoDB\DocumentRepository */
164 164
         $repository = $mongo->getRepository('DembeloMain:Licensee');
165 165
 
166
-        $licensees = $repository->findBy(array('name' => new \MongoRegex('/'.$searchString.'/')), null, 10);
166
+        $licensees = $repository->findBy(array('name' => new \MongoRegex('/' . $searchString . '/')), null, 10);
167 167
 
168 168
         $output = array();
169 169
         /* @var $licensee \DembeloMain\Document\Licensee */
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
         $repository = $mongo->getRepository('DembeloMain:Topic');
195 195
 
196 196
         /* @var $topics \DembeloMain\Document\Topic[] */
197
-        $topics = $repository->findBy(array('name' => new \MongoRegex('/'.$searchString.'/')), null, 10);
197
+        $topics = $repository->findBy(array('name' => new \MongoRegex('/' . $searchString . '/')), null, 10);
198 198
 
199 199
         $output = [];
200 200
         foreach ($topics as $topic) {
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         $formtype = $params['formtype'];
252 252
 
253 253
         /* @var $repository AbstractRepository */
254
-        $repository = $this->get('app.model_repository_'.$formtype);
254
+        $repository = $this->get('app.model_repository_' . $formtype);
255 255
 
256 256
         if (isset($params['id']) && $params['id'] == 'new') {
257 257
             $className = $repository->getClassName();
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
             } elseif ($param === 'imported' && $value === '') {
278 278
                 $value = null;
279 279
             }
280
-            $method = 'set'.ucfirst($param);
280
+            $method = 'set' . ucfirst($param);
281 281
             if (method_exists($item, $method)) {
282 282
                 $item->$method($value);
283 283
             }
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
         if (null === $user) {
329 329
             return new Response(\json_encode(['error' => false]));
330 330
         }
331
-        $user->setActivationHash(sha1($user->getEmail().$user->getPassword().\time()));
331
+        $user->setActivationHash(sha1($user->getEmail() . $user->getPassword() . \time()));
332 332
 
333 333
         $dm->persist($user);
334 334
         $dm->flush();
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
             $obj->access = $textnode->getAccess() ? 'ja' : 'nein';
375 375
             $obj->licensee = $licenseeIndex[$textnode->getLicenseeId()];
376 376
             $obj->importfile = isset($importfileIndex[$textnode->getImportfileId()]) ? $importfileIndex[$textnode->getImportfileId()] : 'unbekannt';
377
-            $obj->beginning = substr(htmlentities(strip_tags($textnode->getText())), 0, 200)."...";
377
+            $obj->beginning = substr(htmlentities(strip_tags($textnode->getText())), 0, 200) . "...";
378 378
             $obj->financenode = $textnode->isFinanceNode() ? 'ja' : 'nein';
379 379
             $obj->twineId = $textnode->getTwineId();
380 380
             $obj->metadata = $this->formatMetadata($textnode->getMetadata());
@@ -400,17 +400,17 @@  discard block
 block discarded – undo
400 400
         }
401 401
 
402 402
         $directory = $this->configTwineDirectory;
403
-        $file = $directory.$filename;
403
+        $file = $directory . $filename;
404 404
         if (!file_exists($file)) {
405 405
             return;
406 406
         }
407
-        $finalDirectory = $directory.$item->getLicenseeId().'/';
407
+        $finalDirectory = $directory . $item->getLicenseeId() . '/';
408 408
         if (!is_dir($finalDirectory)) {
409 409
             if (!mkdir($finalDirectory) && !is_dir($finalDirectory)) {
410 410
                 throw new \RuntimeException(sprintf('Directory "%s" was not created', $finalDirectory));
411 411
             }
412 412
         }
413
-        $finalName = $finalDirectory.$item->getId();
413
+        $finalName = $finalDirectory . $item->getId();
414 414
 
415 415
         rename($file, $finalName);
416 416
 
@@ -455,12 +455,12 @@  discard block
 block discarded – undo
455 455
             return;
456 456
         }
457 457
         $directory = $this->container->getParameter('topic_image_directory');
458
-        $finalDirectory = $directory.$item->getId().'/';
458
+        $finalDirectory = $directory . $item->getId() . '/';
459 459
         if (!is_dir($finalDirectory)) {
460 460
             mkdir($finalDirectory);
461 461
         }
462
-        $finalName = $finalDirectory.$orgname;
463
-        $file = $directory.$filename;
462
+        $finalName = $finalDirectory . $orgname;
463
+        $file = $directory . $filename;
464 464
         rename($file, $finalName);
465 465
         $item->setOriginalImageName($orgname);
466 466
         $item->setImageFilename($finalName);
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
     {
471 471
         $string = '';
472 472
         foreach ($metadata as $key => $value) {
473
-            $string .= $key.': '.$value."\n";
473
+            $string .= $key . ': ' . $value . "\n";
474 474
         }
475 475
 
476 476
         return $string;
Please login to merge, or discard this patch.