typearea / dembelo

www/src/AdminBundle/Tests/Service/TwineImport/FileExtractorTest.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     public function testExtract(): void
     {
         $tmpName = tempnam('/tmp', 'unittest');
-        $createdFilename = $tmpName.'.extracted';
+        $createdFilename = $tmpName . '.extracted';
         $content = <<< END
 nonsens
 lots of stuff

www/src/AdminBundle/Service/TwineImport/FileExtractor.php

Spacing +2 added lines, -2 removed lines

@@ -32,9 +32,9 @@
     public function extract(string $filename): string
     {
         if (!is_readable($filename)) {
-            throw new \InvalidArgumentException('Failed to read data from file ['.$filename.'].');
+            throw new \InvalidArgumentException('Failed to read data from file [' . $filename . '].');
         }
-        $extractedFilename = $filename.'.extracted';
+        $extractedFilename = $filename . '.extracted';
         $fileHandle = fopen($filename, 'r');
         $extractedFileHandle = fopen($extractedFilename, 'w');
         $writing = false;

www/src/AdminBundle/Service/TwineImport/HitchParser.php

Spacing +8 added lines, -8 removed lines

@@ -67,13 +67,13 @@ 
         $contentArray = explode('-->', $content, 2);
 
         if (strlen($contentArray[0]) <= 0 || strlen($contentArray[1]) <= 0) {
-            throw new Exception("The Twine archive file contains a '".$name."' with the invalid element '[[".$contentArray[0]."-->".$contentArray[1]."]]'.");
+            throw new Exception("The Twine archive file contains a '" . $name . "' with the invalid element '[[" . $contentArray[0] . "-->" . $contentArray[1] . "]]'.");
         }
 
         $externalTextnode = $this->textnodeRepository->find($contentArray[1]);
 
         if (null === $externalTextnode) {
-            throw new Exception("There is a textnode which references the external Dembelo Textnode '".$contentArray[1]."', but a Dembelo Textnode with such an Id doesn't exist.");
+            throw new Exception("There is a textnode which references the external Dembelo Textnode '" . $contentArray[1] . "', but a Dembelo Textnode with such an Id doesn't exist.");
         }
 
         $hitch = array();
@@ -95,11 +95,11 @@ 
         $contentArray = explode("->", $content, 2);
 
         if (strlen($contentArray[0]) <= 0 || strlen($contentArray[1]) <= 0) {
-            throw new Exception("The Twine archive file contains a '".$name."' with the invalid element '[[".$contentArray[0]."->".$contentArray[1]."]]'.");
+            throw new Exception("The Twine archive file contains a '" . $name . "' with the invalid element '[[" . $contentArray[0] . "->" . $contentArray[1] . "]]'.");
         }
 
         if (array_key_exists($contentArray[1], $this->nodeNameMapping) !== true) {
-            throw new Exception("There is a textnode which references another textnode named '".$contentArray[1]."', but this textnode doesn't exist within the same story.");
+            throw new Exception("There is a textnode which references another textnode named '" . $contentArray[1] . "', but this textnode doesn't exist within the same story.");
         }
 
         $hitch = array();
@@ -121,11 +121,11 @@ 
         $contentArray = explode("<-", $content, 2);
 
         if (strlen($contentArray[0]) <= 0 || strlen($contentArray[1]) <= 0) {
-            throw new Exception("The Twine archive file contains a '".$name."' with the invalid element '[[".$contentArray[0]."<-".$contentArray[1]."]]'.");
+            throw new Exception("The Twine archive file contains a '" . $name . "' with the invalid element '[[" . $contentArray[0] . "<-" . $contentArray[1] . "]]'.");
         }
 
         if (array_key_exists($contentArray[0], $this->nodeNameMapping) !== true) {
-            throw new Exception("There is a textnode in the Twine archive file which references another textnode named '".$contentArray[0]."', but this textnode doesn't exist within the same story.");
+            throw new Exception("There is a textnode in the Twine archive file which references another textnode named '" . $contentArray[0] . "', but this textnode doesn't exist within the same story.");
         }
 
         $hitch = array();
@@ -145,11 +145,11 @@ 
     public function parseSimpleHitch(string $content, string $name): array
     {
         if (strlen($content) <= 0) {
-            throw new Exception("The Twine archive file contains a '".$name."' with the invalid element '[[".$content."]]'.");
+            throw new Exception("The Twine archive file contains a '" . $name . "' with the invalid element '[[" . $content . "]]'.");
         }
 
         if (array_key_exists($content, $this->nodeNameMapping) !== true) {
-            throw new Exception("There is a textnode in the Twine archive file which references another textnode named '".$content."', but this textnode doesn't exist within the same story.");
+            throw new Exception("There is a textnode in the Twine archive file which references another textnode named '" . $content . "', but this textnode doesn't exist within the same story.");
         }
 
         $hitch = array();

www/src/AdminBundle/Service/TwineImport/FileCheck.php

Spacing +6 added lines, -6 removed lines

@@ -40,13 +40,13 @@ 
         $peekData = fread($fileHandler, 1024);
 
         if ($peekData === false) {
-            throw new \Exception("Failed to read data from file '".$filename."'.");
+            throw new \Exception("Failed to read data from file '" . $filename . "'.");
         }
 
         $peekDataLength = strlen($peekData);
 
         if ($peekDataLength <= 0) {
-            throw new \Exception("File '".$filename."' seems to be empty.");
+            throw new \Exception("File '" . $filename . "' seems to be empty.");
         }
 
         for ($i = 0; $i < $peekDataLength; $i++) {
@@ -59,20 +59,20 @@ 
             }
 
             if ($peekDataLength - $i < $magicStringLength) {
-                throw new \Exception("File '".$filename."' isn't a Twine archive file.");
+                throw new \Exception("File '" . $filename . "' isn't a Twine archive file.");
             }
 
             if (substr($peekData, $i, $magicStringLength) !== self::OPENING_STRING) {
-                throw new \Exception("File '".$filename."' isn't a Twine archive file.");
+                throw new \Exception("File '" . $filename . "' isn't a Twine archive file.");
             }
 
             if (fseek($fileHandler, 0) !== 0) {
-                throw new \Exception("Couldn't reset reading position after the magic string in the Twine archive file '".$filename."' was checked.");
+                throw new \Exception("Couldn't reset reading position after the magic string in the Twine archive file '" . $filename . "' was checked.");
             }
 
             return true;
         }
 
-        throw new \Exception("File '".$filename."' doesn't seem to be a Twine archive file.");
+        throw new \Exception("File '" . $filename . "' doesn't seem to be a Twine archive file.");
     }
 }

www/src/AdminBundle/Tests/Service/TwineImport/FileCheckTest.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     {
         $tmpName = @tempnam('/tmp/phpunit', 'filecheck');
         $fileHandler = fopen($tmpName, 'r+');
-        fwrite($fileHandler, '  '."\n".'<tw-storydata hurz');
+        fwrite($fileHandler, '  ' . "\n" . '<tw-storydata hurz');
         fseek($fileHandler, 0);
 
         $fileCheck = new FileCheck();

www/src/DembeloMain/Document/Textnode.php

Spacing +1 added lines, -1 removed lines

@@ -228,7 +228,7 @@
      *
      * @return array
      */
-    public function getMetadata(): ?array
+    public function getMetadata(): ? array
     {
         return $this->metadata;
     }

www/src/AdminBundle/Service/TwineImport/PassageDataParser.php

Spacing +7 added lines, -7 removed lines

@@ -64,21 +64,21 @@ 
     public function startElement(string $name, array $attrs): void
     {
         if ($this->parserContext->isTwineText()) {
-            throw new \Exception("Nested '".$name."' found in Twine archive file '".$this->parserContext->getFilename()."'.");
+            throw new \Exception("Nested '" . $name . "' found in Twine archive file '" . $this->parserContext->getFilename() . "'.");
         }
 
         if (isset($attrs['pid']) !== true) {
-            throw new \Exception("There is a '".$name."' in the Twine archive file '".$this->parserContext->getFilename()."' which is missing its 'pid' attribute.");
+            throw new \Exception("There is a '" . $name . "' in the Twine archive file '" . $this->parserContext->getFilename() . "' which is missing its 'pid' attribute.");
         }
 
         if (is_numeric($attrs['pid']) !== true) {
-            throw new \Exception("There is a '".$name."' in the Twine archive file '".$this->parserContext->getFilename()."' which hasn't a numeric value in its 'pid' attribute ('".$attrs['pid']."' was found instead).");
+            throw new \Exception("There is a '" . $name . "' in the Twine archive file '" . $this->parserContext->getFilename() . "' which hasn't a numeric value in its 'pid' attribute ('" . $attrs['pid'] . "' was found instead).");
         }
 
         $twineId = $this->getTwineId($attrs['tags'], $attrs['name']);
 
         if (array_key_exists($twineId, $this->parserContext->getTextnodeMapping()) === true) {
-            throw new \Exception("There is a '".$name."' in the Twine archive file '".$this->parserContext->getFilename()."' which has a non unique 'id' tag [".$twineId."], in node '".$attrs['name']."'");
+            throw new \Exception("There is a '" . $name . "' in the Twine archive file '" . $this->parserContext->getFilename() . "' which has a non unique 'id' tag [" . $twineId . "], in node '" . $attrs['name'] . "'");
         }
 
         $textnode = $this->textnodeRepository->findByTwineId($this->parserContext->getImportfile(), $twineId);
@@ -102,7 +102,7 @@ 
                 $textnode->setAccess(true);
                 $this->parserContext->setAccessSet(true);
             } else {
-                throw new \Exception('There is more than one \''.$name.'\' in the Twine archive file \''.$this->parserContext->getFilename().'\' with the startnode value \''.$attrs['pid'].'\' in its \'pid\' attribute.');
+                throw new \Exception('There is more than one \'' . $name . '\' in the Twine archive file \'' . $this->parserContext->getFilename() . '\' with the startnode value \'' . $attrs['pid'] . '\' in its \'pid\' attribute.');
             }
         } else {
             $textnode->setAccess(false);
@@ -139,7 +139,7 @@ 
     private function getTwineId(string $tagString, string $textnodeTitle): string
     {
         if (empty($tagString)) {
-            throw new \Exception('no ID given for Textnode "'.$textnodeTitle.'"');
+            throw new \Exception('no ID given for Textnode "' . $textnodeTitle . '"');
         }
         $tagArray = explode(' ', $tagString);
 
@@ -152,7 +152,7 @@ 
         }
 
         if ($twineId === false) {
-            throw new \Exception('no ID given for Textnode "'.$textnodeTitle.'"');
+            throw new \Exception('no ID given for Textnode "' . $textnodeTitle . '"');
         }
 
         return $twineId;

www/src/AdminBundle/Service/TwineImport/StoryDataParser.php

Spacing +7 added lines, -7 removed lines

@@ -108,7 +108,7 @@ 
         $textnode = $this->textnodeRepository->find($dembeloId);
 
         if (null === $textnode) {
-            throw new \Exception('The Dembelo Textnode with Id \''.$dembeloId.'\' doesn\'t exist, but should by now.');
+            throw new \Exception('The Dembelo Textnode with Id \'' . $dembeloId . '\' doesn\'t exist, but should by now.');
         }
 
         $textnodeText = $textnode->getText();
@@ -125,7 +125,7 @@ 
     private function checkElementStoryData(string $name, array $attributes): bool
     {
         if ($this->parserContext->isTwineRelevant()) {
-            throw new \Exception("Nested '".$name."' found in Twine archive file '".$this->parserContext->getFilename()."'.");
+            throw new \Exception("Nested '" . $name . "' found in Twine archive file '" . $this->parserContext->getFilename() . "'.");
         }
 
         if (!isset($attributes['startnode']) || !is_numeric($attributes['startnode'])) {
@@ -133,7 +133,7 @@ 
         }
 
         if (isset($attributes['name']) !== true) {
-            throw new \Exception("There is a '".$name."' in the Twine archive file '".$this->parserContext->getFilename()."' which is missing its 'name' attribute.");
+            throw new \Exception("There is a '" . $name . "' in the Twine archive file '" . $this->parserContext->getFilename() . "' which is missing its 'name' attribute.");
         }
 
         return true;
@@ -197,13 +197,13 @@ 
      * @param array|null $hitch
      * @throws \Exception
      */
-    private function appendHitchToTextnode(Textnode $textnode, ?array $hitch): void
+    private function appendHitchToTextnode(Textnode $textnode, ? array $hitch) : void
     {
         if ($hitch === null) {
             return;
         }
         if ($textnode->getHitchCount() >= Textnode::HITCHES_MAXIMUM_COUNT) {
-            throw new \Exception('There is a textnode in the Twine archive file which has more than '.Textnode::HITCHES_MAXIMUM_COUNT.' links.');
+            throw new \Exception('There is a textnode in the Twine archive file which has more than ' . Textnode::HITCHES_MAXIMUM_COUNT . ' links.');
         }
 
         if ($textnode->appendHitch($hitch) !== true) {
@@ -223,13 +223,13 @@ 
         $contentArray = explode('>:<', $content, 2);
 
         if (strlen($contentArray[0]) <= 0 || strlen($contentArray[1]) <= 0) {
-            throw new \Exception('The Twine archive file contains a \''.$name.'\' with the invalid element \'[['.$contentArray[0].'>:<'.$contentArray[1].']]\'.');
+            throw new \Exception('The Twine archive file contains a \'' . $name . '\' with the invalid element \'[[' . $contentArray[0] . '>:<' . $contentArray[1] . ']]\'.');
         }
 
         $metadata = $textnode->getMetadata() ?? [];
 
         if (array_key_exists($contentArray[0], $metadata) === true) {
-            throw new \Exception('There is a textnode in the Twine archive file which contains the metadata field \''.$contentArray[0].'\' twice or would overwrite the already existing value of that field.');
+            throw new \Exception('There is a textnode in the Twine archive file which contains the metadata field \'' . $contentArray[0] . '\' twice or would overwrite the already existing value of that field.');
         }
 
         $metadata[$contentArray[0]] = $contentArray[1];

www/src/AdminBundle/Tests/Service/TwineImport/StoryDataParserTest.php

Spacing +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
         $textnodeMock = $this->createMock(Textnode::class);
         $textnodeMock->expects(self::any())
             ->method('getText')
-            ->willReturn('someText'."\n"."someOtherText ");
+            ->willReturn('someText' . "\n" . "someOtherText ");
         $textnodeMock->expects(self::once())
             ->method('setText')
             ->willReturnCallback(function (string $textNew) {