trivago / chapi

src/Entity/DatePeriod/Iso8601Entity.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     private function parseIsoString()
     {

src/Commands/DiffCommand.php

Braces +3 added lines, -6 removed lines

@@ -37,8 +37,7 @@ 
         if (!empty($_sJobName))
         {
             $this->printJobDiff($_sJobName);
-        }
-        else
+        } else
         {
             $_aLocalJobUpdates = $_oJobComparisonBusinessCase->getLocalJobUpdates();
             if (!empty($_aLocalJobUpdates))
@@ -76,12 +75,10 @@ 
                 if ($_sDiffSign == '+')
                 {
                     $this->oOutput->writeln(sprintf("<info>%s\t%s: %s</info>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1)));
-                }
-                elseif ($_sDiffSign == '-')
+                } elseif ($_sDiffSign == '-')
                 {
                     $this->oOutput->writeln(sprintf("<fg=red>%s\t%s: %s</>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1)));
-                }
-                else
+                } else
                 {
                     $this->oOutput->writeln(sprintf("\t%s: %s", $_sProperty, $_sDiffLine));
                 }

src/Commands/InfoCommand.php

Braces +1 added lines, -2 removed lines

@@ -49,8 +49,7 @@
                 $_mValue = (!empty($_mValue))
                     ? '[ ' . implode(', ', $_mValue) . ' ]'
                     : '[ ]';
-            }
-            elseif (is_bool($_mValue))
+            } elseif (is_bool($_mValue))
             {
                 $_mValue = (true === $_mValue)
                     ? 'true'

src/Commands/ResetCommand.php

Braces +1 added lines, -2 removed lines

@@ -49,8 +49,7 @@
         if (JobUtils::isWildcard($aJobNames))
         {
             $_oJobIndexService->resetJobIndex();
-        }
-        else
+        } else
         {
             $_oJobIndexService->removeJobs($aJobNames);
         }

src/Commands/SchedulingViewCommand.php

Braces +5 added lines, -10 removed lines

@@ -250,13 +250,11 @@ 
                 {
                     $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, $_oTime->format('H>i'), $_oTime->format('H:i'));
 
-                }
-                else
+                } else
                 {
                     $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, str_repeat('>', 5), str_repeat($_sSpacer, 5));
                 }
-            }
-            else
+            } else
             {
                 $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, '>', $_sSpacer);
             }
@@ -284,18 +282,15 @@ 
         if ($bPrintJobStart && $bPrintJobEnd)
         {
             $_sTimelineSnippet = sprintf('<comment>%s</comment>', $sStartStopMark);
-        }
-        elseif ($bPrintJobStart)
+        } elseif ($bPrintJobStart)
         {
             $_sTimelineSnippet = sprintf('<comment>%s', $sStartStopMark);
             $bHasToCloseFinalTag = true;
-        }
-        elseif ($bPrintJobEnd)
+        } elseif ($bPrintJobEnd)
         {
             $_sTimelineSnippet = sprintf('%s</comment>', $sStartStopMark);
             $bHasToCloseFinalTag = false;
-        }
-        else
+        } else
         {
             $_sTimelineSnippet = $sSpacer;
         }

Spacing +4 added lines, -4 removed lines

@@ -73,7 +73,7 @@ 
         $_iStartTime = ($_sStartTime == null) ? $_iCurrentTime : strtotime($_sStartTime);
         if ($_sStartTime != null && $_iStartTime < $_iCurrentTime)
         {
-            $_iStartTime = strtotime($_sStartTime . ' + 24 hours');
+            $_iStartTime = strtotime($_sStartTime.' + 24 hours');
         }
 
         $_iEndTime = ($_sEndTime == null) ? $_iStartTime + 7200 : strtotime($_sEndTime);
@@ -95,7 +95,7 @@ 
         $_oTable = new Table($this->oOutput);
         $_oTable->setHeaders(array(
             'Job',
-            'Timeline for ' . date('Y-m-d H:i', $iStartTime) . ' till ' . date('Y-m-d H:i', $iEndTime)
+            'Timeline for '.date('Y-m-d H:i', $iStartTime).' till '.date('Y-m-d H:i', $iEndTime)
         ));
 
         $_aJobs = $this->getJobsWhichShouldStartInPeriod($iStartTime, $iEndTime);
@@ -163,7 +163,7 @@ 
 
             $oTable->addRow(
                 array(
-                    str_repeat('   ', $iCurrentChildLevel) . '|_ ' . $_sChildJobName,
+                    str_repeat('   ', $iCurrentChildLevel).'|_ '.$_sChildJobName,
                     $this->getTimelineStr(
                         $oDisplayPeriod,
                         $oJobDatePeriod,
@@ -317,7 +317,7 @@ 
         {
             if ($iJobStartTimeDelay > 0)
             {
-                $_oJobTime->add(new \DateInterval('PT' . $iJobStartTimeDelay . 'S'));
+                $_oJobTime->add(new \DateInterval('PT'.$iJobStartTimeDelay.'S'));
             }
 
             $_aStartTimes[$_oJobTime->format('YmdHi')] = $_oJobTime;

src/Component/DatePeriod/DatePeriodFactory.php

Braces +2 added lines, -4 removed lines

@@ -38,8 +38,7 @@ 
         try
         {
             return self::$aIso8601Entity[$_sKey] = new Iso8601Entity($sIso8601);
-        }
-        catch (\InvalidArgumentException $_oException)
+        } catch (\InvalidArgumentException $_oException)
         {
             throw new DatePeriodException(sprintf("Can't init Iso8601Entity for '%s' iso 8601 string.", $sIso8601), 1, $_oException);
         }
@@ -58,8 +57,7 @@ 
         {
             $_oDateStart = new \DateTime(str_replace('Z', '', $_oIso8601Entity->sStartTime));
             $_oDateStart->setTimezone(new \DateTimeZone($sTimeZone));
-        }
-        else
+        } else
         {
             $_oDateStart = new \DateTime($_oIso8601Entity->sStartTime);
         }

src/Component/Http/HttpGuzzlClient.php

Braces +1 added lines, -2 removed lines

@@ -51,8 +51,7 @@
             );
 
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getBaseUrl() . $sUrl),

Unused Use Statements +1 added lines, -1 removed lines

@@ -9,8 +9,8 @@
 
 namespace Chapi\Component\Http;
 
-use Chapi\Exception\HttpConnectionException;
 use Chapi\Entity\Http\AuthEntity;
+use Chapi\Exception\HttpConnectionException;
 use GuzzleHttp\ClientInterface;
 
 class HttpGuzzlClient implements HttpClientInterface

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         catch (\Exception $oException)
         {
             throw new HttpConnectionException(
-                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 0,
                 $oException
             );

src/Service/JobRepository/BridgeFileSystem.php

Braces +1 added lines, -2 removed lines

@@ -230,8 +230,7 @@
                     // set path to job file map
                     $this->setJobFileToMap($_oJobEntity->name, $_sJobFilePath);
                 }
-            }
-            else
+            } else
             {
                 throw new JobLoadException(
                     sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $_sJobFilePath),

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
-     * @package: chapi
-     *
-     * @author:  msiebeneicher
-     * @since:   2015-07-29
-     *
-     */
+ * @package: chapi
+ *
+ * @author:  msiebeneicher
+ * @since:   2015-07-29
+ *
+ */
 
 namespace Chapi\Service\JobRepository;
 

Spacing +2 added lines, -2 removed lines

@@ -125,7 +125,7 @@ 
             DIRECTORY_SEPARATOR,
             $oJobEntity->name
         );
-        return $this->sRepositoryDir . DIRECTORY_SEPARATOR . $_sJobPath . '.json';
+        return $this->sRepositoryDir.DIRECTORY_SEPARATOR.$_sJobPath.'.json';
     }
 
     /**
@@ -140,7 +140,7 @@ 
             throw new \RuntimeException(sprintf('Path "%s" is not valid', $sPath));
         }
 
-        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . '*');
+        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.'*');
 
         foreach ($_aTemp as $_sPath)
         {

src/Service/JobRepository/JobRepository.php

Braces +3 added lines, -1 removed lines

@@ -84,10 +84,12 @@
     {
         if ($this->oRepositoryBridge->addJob($oJobEntity))
         {
-            if (!is_null($this->oJobCollection)) // if no collection inited the new job will init by chronos request
+            if (!is_null($this->oJobCollection)) {
+                // if no collection inited the new job will init by chronos request
             {
                 $this->oJobCollection->offsetSet($oJobEntity->name, $oJobEntity);
             }
+            }
 
             return true;
         }