trivago / chapi

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Braces +3 added lines, -6 removed lines

@@ -250,12 +250,10 @@ 
     {
         if (is_array($mValueA) && is_array($mValueB)) {
             return $this->isArrayEqual($mValueA, $mValueB);
-        }
-        elseif (is_object($mValueA) && is_object($mValueB))
+        } elseif (is_object($mValueA) && is_object($mValueB))
         {
             return $this->isArrayEqual(get_object_vars($mValueA), get_object_vars($mValueB));
-        }
-        elseif ((is_scalar($mValueA) && is_scalar($mValueB)) || (is_null($mValueA) && is_null($mValueB)))
+        } elseif ((is_scalar($mValueA) && is_scalar($mValueB)) || (is_null($mValueA) && is_null($mValueB)))
         {
             return $mValueA == $mValueB;
         }
@@ -288,8 +286,7 @@ 
                 {
                     return false;
                 }
-            }
-            else
+            } else
             {
                 foreach ($aValuesB as $_mValueB)
                 {

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->oDiffCompare = $oDiffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         if (
             !$oLocalJob instanceof MarathonAppEntity ||

src/Service/JobRepository/JobRepository.php

Braces +3 added lines, -1 removed lines

@@ -99,10 +99,12 @@
     {
         if ($this->oRepositoryBridge->addJob($oJobEntity))
         {
-            if (!is_null($this->oJobCollection)) // if no collection inited the new job will init by chronos request
+            if (!is_null($this->oJobCollection)) {
+                // if no collection inited the new job will init by chronos request
             {
                 $this->oJobCollection->offsetSet($oJobEntity->getKey(), $oJobEntity);
             }
+            }
 
             return true;
         }

src/Commands/InfoCommand.php

Braces +1 added lines, -2 removed lines

@@ -55,8 +55,7 @@
                 $_mValue = (!empty($_mValue))
                     ? json_encode($_mValue, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)
                     : $_sEmptyString;
-            }
-            elseif (is_bool($_mValue))
+            } elseif (is_bool($_mValue))
             {
                 $_mValue = (true === $_mValue)
                     ? 'true'

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $iImmediateChildren
+     */
     private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 
 use Chapi\BusinessCase\Comparison\JobComparisonInterface;
-use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobIndex\JobIndexServiceInterface;
 use Chapi\Service\JobRepository\JobRepositoryInterface;

Spacing +5 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
             }
 
             // check if dependency is satisfied
-            if ( $_oJobEntityLocal->isDependencyJob())
+            if ($_oJobEntityLocal->isDependencyJob())
             {
                 try {
                     $circular = $this->isDependencyCircular($_oJobEntityLocal, count($_oJobEntityLocal->dependencies));
@@ -84,10 +84,10 @@ 
                         return false;
                     }
                 }
-                catch(\Exception $e)
+                catch (\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
-                        'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()
+                        'Job %s cannot be added to remote : %s', $sAppId, $e->getMessage()
                     ));
                     return false;
                 }
@@ -133,7 +133,7 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
-    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
+    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path = [])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
         if ($this->hasDuplicates($path))
@@ -186,7 +186,7 @@ 
             // for B intermediate Child will be 2.
             // when we process D, it will be reduced to 1 and with C to 0
             // then we will pop B to generate path [A, E] when we reach E.
-            $iImmediateChildren = $iImmediateChildren -1;
+            $iImmediateChildren = $iImmediateChildren - 1;
             if ($iImmediateChildren == 0)
             {
                 array_pop($path);

Braces +1 added lines, -2 removed lines

@@ -83,8 +83,7 @@
                         ));
                         return false;
                     }
-                }
-                catch(\Exception $e)
+                } catch(\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()

src/Service/JobRepository/BridgeFactory.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use Chapi\Component\Cache\CacheInterface;
 use Chapi\Component\RemoteClients\ApiClientInterface;
-use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobValidator\JobValidatorServiceInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Filesystem\Filesystem;

src/Entity/Marathon/AppEntity/PortDefinition.php

Spacing +4 added lines, -4 removed lines

@@ -23,12 +23,12 @@
 
     public function __construct($aData = [])
     {
-        MarathonEntityUtils::setAllPossibleProperties((array)$aData, $this);
-        if(isset($aData['labels']))
+        MarathonEntityUtils::setAllPossibleProperties((array) $aData, $this);
+        if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         } else {
-            $this->labels = (object)[];
+            $this->labels = (object) [];
         }
 
     }

src/Entity/Marathon/AppEntity/Container.php

Spacing +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 
         if (isset($aData['docker']))
         {
-            $this->docker = new Docker((array)$aData['docker']);
+            $this->docker = new Docker((array) $aData['docker']);
         }
 
         if (isset($aData['volumes']))
         {
             foreach ($aData['volumes'] as $volume)
             {
-                $this->volumes[] = new ContainerVolume((array)$volume);
+                $this->volumes[] = new ContainerVolume((array) $volume);
             }
         }
 

src/Entity/Marathon/AppEntity/Docker.php

Spacing +4 added lines, -4 removed lines

@@ -39,17 +39,17 @@
 
         if (isset($aData['portMappings']))
         {
-            foreach($aData['portMappings'] as $portMapping)
+            foreach ($aData['portMappings'] as $portMapping)
             {
-                $this->portMappings[] = new DockerPortMapping((array)$portMapping);
+                $this->portMappings[] = new DockerPortMapping((array) $portMapping);
             }
         }
 
         if (isset($aData['parameters']))
         {
-            foreach($aData['parameters'] as $parameter)
+            foreach ($aData['parameters'] as $parameter)
             {
-                $this->parameters[] = new DockerParameters((array)$parameter);
+                $this->parameters[] = new DockerParameters((array) $parameter);
             }
         }
 

src/Entity/Marathon/AppEntity/HealthCheck.php

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['command']))
+        if (isset($aData['command']))
         {
-            $this->command = new HealthCheckCommand((array)$aData['command']);
+            $this->command = new HealthCheckCommand((array) $aData['command']);
         }
     }