trivago / chapi

src/Commands/StatusCommand.php

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
                 {
                     $_aFilteredJobList[] = $_sJobName;
                 }
-            }
-            else
+            } else
             {
                 if (!$this->oJobIndexService->isJobInIndex($_sJobName))
                 {

src/Service/JobRepository/BridgeFileSystem.php

Doc Comments +3 added lines

@@ -347,6 +347,9 @@
     }
 
 
+    /**
+     * @param string $sJobFile
+     */
     private function dumpFileWithGroup($sJobFile, JobEntityInterface $oJobEntity, $bAdd = true)
     {
         $_sGroupConfig = file_get_contents($sJobFile);

Spacing +2 added lines, -2 removed lines

@@ -161,7 +161,7 @@ 
             $_sJobPath = $oJobEntity->getKey();
         }
 
-        return $this->sRepositoryDir . DIRECTORY_SEPARATOR . $_sJobPath . '.json';
+        return $this->sRepositoryDir.DIRECTORY_SEPARATOR.$_sJobPath.'.json';
     }
 
     /**
@@ -176,7 +176,7 @@ 
             throw new \RuntimeException(sprintf('Path "%s" is not valid', $sPath));
         }
 
-        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . '*');
+        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.'*');
 
         foreach ($_aTemp as $_sPath)
         {

Braces +9 added lines, -8 removed lines

@@ -155,8 +155,7 @@ 
                 DIRECTORY_SEPARATOR,
                 $oJobEntity->getKey()
             );
-        }
-        else
+        } else
         {
             $_sJobPath = $oJobEntity->getKey();
         }
@@ -268,15 +267,19 @@ 
 
             if ($_aTemp)
             {
-                if (property_exists($_aTemp, 'name')) // chronos
+                if (property_exists($_aTemp, 'name')) {
+                    // chronos
                 {
                     $_aJobEntities[] = new ChronosJobEntity($_aTemp);
+                }
 
-                } else if (property_exists($_aTemp, 'id')) //marathon
+                } else if (property_exists($_aTemp, 'id')) {
+                    //marathon
                 {
                     foreach ($this->getMarathonEntitiesForConfig($_aTemp) as $_oApp)
                     {
                         $_aJobEntities[] = $_oApp;
+                }
                     }
                 } else {
                     throw new JobLoadException(
@@ -297,8 +300,7 @@ 
                     $_aJobs[] = $_oJobEntity;
                 }
 
-            }
-            else
+            } else
             {
                 throw new JobLoadException(
                     sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $_sJobFilePath),
@@ -323,8 +325,7 @@ 
                 $this->aGroupedApps[] = $_oApp->id;
                 $_aRet[] = $_oGroupEntity;
             }
-        }
-        else
+        } else
         {
             $_aRet[] = new MarathonAppEntity($aEntityData);
         }

src/Service/JobValidator/PropertyValidator/AbstractPropertyValidator.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace Chapi\Service\JobValidator\PropertyValidator;
 
 
-use Chapi\Entity\Chronos\JobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Service\JobValidator\PropertyValidatorInterface;
 

src/Entity/Marathon/MarathonEntityUtils.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      */
     public static function setAllPossibleProperties($oData, $oTarget)
     {
-        foreach($oData as $attrName => $attrValue)
+        foreach ($oData as $attrName => $attrValue)
         {
             // dont set array or objects.
             // Because this would need further type information to properly set.

src/Component/Http/HttpGuzzlClient.php

Braces +1 added lines, -2 removed lines

@@ -54,8 +54,7 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),

Doc Comments +2 added lines, -2 removed lines

@@ -98,8 +98,8 @@
     }
 
     /**
-     * @param $sMethod
-     * @param $sUrl
+     * @param string $sMethod
+     * @param string $sUrl
      * @param $mData
      * @return HttpGuzzlResponse
      */

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Braces +1 added lines, -2 removed lines

@@ -317,8 +317,7 @@
         {
             $_oDateTime = new \DateTime(str_replace('Z', '', $_oIso8601Entity->sStartTime));
             $_oDateTime->setTimezone(new \DateTimeZone($sTimeZone));
-        }
-        else
+        } else
         {
             $_oDateTime = new \DateTime($_oIso8601Entity->sStartTime);
         }

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     }
 
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         // no modification needed
         return;

src/BusinessCase/Comparison/CompositeJobComparisonBusinessCase.php

Spacing +7 added lines, -7 removed lines

@@ -34,10 +34,10 @@ 
     public function getLocalMissingJobs()
     {
         $_aMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $missing = $jobComparers->getLocalMissingJobs();
-            $_aMissingJobs = array_merge($_aMissingJobs,  $missing);
+            $_aMissingJobs = array_merge($_aMissingJobs, $missing);
         }
         return $_aMissingJobs;
     }
@@ -48,7 +48,7 @@ 
     public function getRemoteMissingJobs()
     {
         $_aChronosMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aChronosMissingJobs = array_merge($_aChronosMissingJobs, $jobComparers->getRemoteMissingJobs());
         }
@@ -61,7 +61,7 @@ 
     public function getLocalJobUpdates()
     {
         $_aLocalJobUpdates = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aLocalJobUpdates = array_merge($_aLocalJobUpdates, $jobComparers->getLocalJobUpdates());
         }
@@ -75,7 +75,7 @@ 
     public function getJobDiff($sJobName)
     {
         $_aJobDiffs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             // NOTE: only gets the first one.
             // does it make sense?
@@ -99,7 +99,7 @@ 
         }
         /** @var JobComparisonInterface $comparer */
         $comparer = null;
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($oJobEntityA->getKey()))
             {
@@ -123,7 +123,7 @@ 
      */
     public function isJobAvailable($sJobName)
     {
-        foreach($this->aComposites as $child) {
+        foreach ($this->aComposites as $child) {
             if ($child->isJobAvailable($sJobName))
             {
                 return true;

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Braces +3 added lines, -6 removed lines

@@ -250,12 +250,10 @@ 
     {
         if (is_array($mValueA) && is_array($mValueB)) {
             return $this->isArrayEqual($mValueA, $mValueB);
-        }
-        elseif (is_object($mValueA) && is_object($mValueB))
+        } elseif (is_object($mValueA) && is_object($mValueB))
         {
             return $this->isArrayEqual(get_object_vars($mValueA), get_object_vars($mValueB));
-        }
-        elseif ((is_scalar($mValueA) && is_scalar($mValueB)) || (is_null($mValueA) && is_null($mValueB)))
+        } elseif ((is_scalar($mValueA) && is_scalar($mValueB)) || (is_null($mValueA) && is_null($mValueB)))
         {
             return $mValueA == $mValueB;
         }
@@ -288,8 +286,7 @@ 
                 {
                     return false;
                 }
-            }
-            else
+            } else
             {
                 foreach ($aValuesB as $_mValueB)
                 {

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->oDiffCompare = $oDiffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         if (
             !$oLocalJob instanceof MarathonAppEntity ||

src/Service/JobRepository/JobRepository.php

Braces +3 added lines, -1 removed lines

@@ -99,10 +99,12 @@
     {
         if ($this->oRepositoryBridge->addJob($oJobEntity))
         {
-            if (!is_null($this->oJobCollection)) // if no collection inited the new job will init by chronos request
+            if (!is_null($this->oJobCollection)) {
+                // if no collection inited the new job will init by chronos request
             {
                 $this->oJobCollection->offsetSet($oJobEntity->getKey(), $oJobEntity);
             }
+            }
 
             return true;
         }