trivago / chapi

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $iImmediateChildren
+     */
     private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 
 use Chapi\BusinessCase\Comparison\JobComparisonInterface;
-use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobIndex\JobIndexServiceInterface;
 use Chapi\Service\JobRepository\JobRepositoryInterface;

Spacing +5 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
             }
 
             // check if dependency is satisfied
-            if ( $_oJobEntityLocal->isDependencyJob())
+            if ($_oJobEntityLocal->isDependencyJob())
             {
                 try {
                     $circular = $this->isDependencyCircular($_oJobEntityLocal, count($_oJobEntityLocal->dependencies));
@@ -84,10 +84,10 @@ 
                         return false;
                     }
                 }
-                catch(\Exception $e)
+                catch (\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
-                        'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()
+                        'Job %s cannot be added to remote : %s', $sAppId, $e->getMessage()
                     ));
                     return false;
                 }
@@ -133,7 +133,7 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
-    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
+    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path = [])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
         if ($this->hasDuplicates($path))
@@ -186,7 +186,7 @@ 
             // for B intermediate Child will be 2.
             // when we process D, it will be reduced to 1 and with C to 0
             // then we will pop B to generate path [A, E] when we reach E.
-            $iImmediateChildren = $iImmediateChildren -1;
+            $iImmediateChildren = $iImmediateChildren - 1;
             if ($iImmediateChildren == 0)
             {
                 array_pop($path);

Braces +1 added lines, -2 removed lines

@@ -83,8 +83,7 @@
                         ));
                         return false;
                     }
-                }
-                catch(\Exception $e)
+                } catch(\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()

src/Service/JobRepository/BridgeFactory.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use Chapi\Component\Cache\CacheInterface;
 use Chapi\Component\RemoteClients\ApiClientInterface;
-use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobValidator\JobValidatorServiceInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Filesystem\Filesystem;

src/Entity/Marathon/AppEntity/PortDefinition.php

Spacing +4 added lines, -4 removed lines

@@ -23,12 +23,12 @@
 
     public function __construct($aData = [])
     {
-        MarathonEntityUtils::setAllPossibleProperties((array)$aData, $this);
-        if(isset($aData['labels']))
+        MarathonEntityUtils::setAllPossibleProperties((array) $aData, $this);
+        if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         } else {
-            $this->labels = (object)[];
+            $this->labels = (object) [];
         }
 
     }

src/Entity/Marathon/AppEntity/Container.php

Spacing +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 
         if (isset($aData['docker']))
         {
-            $this->docker = new Docker((array)$aData['docker']);
+            $this->docker = new Docker((array) $aData['docker']);
         }
 
         if (isset($aData['volumes']))
         {
             foreach ($aData['volumes'] as $volume)
             {
-                $this->volumes[] = new ContainerVolume((array)$volume);
+                $this->volumes[] = new ContainerVolume((array) $volume);
             }
         }
 

src/Entity/Marathon/AppEntity/Docker.php

Spacing +4 added lines, -4 removed lines

@@ -39,17 +39,17 @@
 
         if (isset($aData['portMappings']))
         {
-            foreach($aData['portMappings'] as $portMapping)
+            foreach ($aData['portMappings'] as $portMapping)
             {
-                $this->portMappings[] = new DockerPortMapping((array)$portMapping);
+                $this->portMappings[] = new DockerPortMapping((array) $portMapping);
             }
         }
 
         if (isset($aData['parameters']))
         {
-            foreach($aData['parameters'] as $parameter)
+            foreach ($aData['parameters'] as $parameter)
             {
-                $this->parameters[] = new DockerParameters((array)$parameter);
+                $this->parameters[] = new DockerParameters((array) $parameter);
             }
         }
 

src/Entity/Marathon/AppEntity/HealthCheck.php

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['command']))
+        if (isset($aData['command']))
         {
-            $this->command = new HealthCheckCommand((array)$aData['command']);
+            $this->command = new HealthCheckCommand((array) $aData['command']);
         }
     }
 

src/Entity/Marathon/AppEntity/IpAddress.php

Spacing +2 added lines, -2 removed lines

@@ -25,13 +25,13 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['groups']))
+        if (isset($aData['groups']))
         {
             $this->groups = $aData['groups'];
         }
         if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         }
     }
 }
\ No newline at end of file

src/Entity/Marathon/MarathonAppEntity.php

Spacing +10 added lines, -10 removed lines

@@ -33,7 +33,7 @@ 
     /**
      * @var PortDefinition[]
      */
-    public $portDefinitions =[];
+    public $portDefinitions = [];
 
     public $requirePorts = false;
 
@@ -51,7 +51,7 @@ 
     /**
      * @var array
      */
-    public $constraints  = [];
+    public $constraints = [];
 
 
     public $acceptedResourceRoles = [];
@@ -101,39 +101,39 @@ 
 
         if (isset($aData['portDefinitions'])) {
             foreach ($aData['portDefinitions'] as $portDefinition) {
-                $this->portDefinitions[] = new PortDefinition((array)$portDefinition);
+                $this->portDefinitions[] = new PortDefinition((array) $portDefinition);
             }
         }
 
         if (isset($aData['container'])) {
-            $this->container = new Container((array)$aData['container']);
+            $this->container = new Container((array) $aData['container']);
         }
 
         if (isset($aData['healthChecks']))
         {
-            foreach($aData['healthChecks'] as $healthCheck)
+            foreach ($aData['healthChecks'] as $healthCheck)
             {
-                $this->healthChecks[] = new HealthCheck((array)$healthCheck);
+                $this->healthChecks[] = new HealthCheck((array) $healthCheck);
             }
         }
 
         if (isset($aData['upgradeStrategy']))
         {
-            $this->upgradeStrategy = new UpgradeStrategy((array)$aData['upgradeStrategy']);
+            $this->upgradeStrategy = new UpgradeStrategy((array) $aData['upgradeStrategy']);
         } else {
             $this->upgradeStrategy = new UpgradeStrategy();
         }
 
         if (isset($aData['ipAddress']))
         {
-            $this->ipAddress = new IpAddress((array)$aData['ipAddress']);
+            $this->ipAddress = new IpAddress((array) $aData['ipAddress']);
         }
 
         if (isset($aData['env']))
         {
-            $this->env =  (object) $aData['env'];
+            $this->env = (object) $aData['env'];
         } else {
-            $this->env = (object)[];
+            $this->env = (object) [];
         }
 
         if (isset($aData['labels']))

src/BusinessCase/Comparison/AbstractJobComparisionBusinessCase.php

Spacing +2 added lines, -2 removed lines

@@ -166,7 +166,7 @@ 
             $_aDifferences[$_sProperty] = $this->oDiffCompare->compare(
                 $_oRemoteEntity->{$_sProperty},
                 $_oLocalEntity->{$_sProperty}
-            ) ;
+            );
         }
 
         return $_aDifferences;
@@ -219,7 +219,7 @@ 
      * @param JobEntityInterface $oRemoteJob
      * @return null
      */
-    abstract protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob);
+    abstract protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob);
 
     /**
      * Gets entity for each system with defaults set