Command::isCommandPropertyValid() - Code Metrics - Inspection of "Feature/add marathon support" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#68)

by Bidesh

created 2017-02-16 13:12 UTC

Command::isCommandPropertyValid() B

↳ Parent: Command

Complexity

Conditions	5
Paths	5

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	5.0729

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	13
ccs	6
cts	7
cp	0.8571
rs	8.8571
c	1
b	0
f	1
cc	5
eloc	6
nc	5
nop	1
crap	5.0729

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 *
 */


namespace Chapi\Service\JobValidator\PropertyValidator;

use Chapi\Entity\Chronos\ChronosJobEntity;
use Chapi\Entity\Chronos\JobEntity;
use Chapi\Entity\JobEntityInterface;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Command extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'CommandValidator';
    const MESSAGE_TEMPLATE = '"%s" is not allowed to be empty for non docker jobs';

    /**
     * @inheritDoc
     */
    public function isValid($sProperty, JobEntityInterface $oJobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isCommandPropertyValid($oJobEntity),
            $sProperty,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param JobEntityInterface $oJobEntity
     * @return bool
     */
    private function isCommandPropertyValid(JobEntityInterface $oJobEntity)
    {
        if (!$oJobEntity instanceof ChronosJobEntity) {
            throw new \RuntimeException('Required ChronosJobEntity. Something else found.');
        }

        if (is_null($oJobEntity->container))
        {
            return (!empty($oJobEntity->command) && is_string($oJobEntity->command));
        }
        
        return (empty($oJobEntity->command) || is_string($oJobEntity->command));
    }
}

1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*
8		*/
9
10
11		namespace Chapi\Service\JobValidator\PropertyValidator;
12
13		use Chapi\Entity\Chronos\ChronosJobEntity;
14		use Chapi\Entity\Chronos\JobEntity;
15		use Chapi\Entity\JobEntityInterface;
16		use Chapi\Service\JobValidator\PropertyValidatorInterface;
17
18		class Command extends AbstractPropertyValidator implements PropertyValidatorInterface
19		{
20		const DIC_NAME = 'CommandValidator';
21		const MESSAGE_TEMPLATE = '"%s" is not allowed to be empty for non docker jobs';
22
23		/**
24		* @inheritDoc
25		*/
26	3	public function isValid($sProperty, JobEntityInterface $oJobEntity)
27		{
28	3	return $this->returnIsValidHelper(
29	3	$this->isCommandPropertyValid($oJobEntity),
30	3	$sProperty,
31		self::MESSAGE_TEMPLATE
32	3	);
33		}
34
35		/**
36		* @param JobEntityInterface $oJobEntity
37		* @return bool
38		*/
39	3	private function isCommandPropertyValid(JobEntityInterface $oJobEntity)
40		{
41	3	if (!$oJobEntity instanceof ChronosJobEntity) {
42		throw new \RuntimeException('Required ChronosJobEntity. Something else found.');
43		}
44
45	3	if (is_null($oJobEntity->container))
46	3	{
47	3	return (!empty($oJobEntity->command) && is_string($oJobEntity->command));
48		}
49
50	1	return (empty($oJobEntity->command) \|\| is_string($oJobEntity->command));
51		}
52		}

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#68)

Command::isCommandPropertyValid() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like