| @@ -47,7 +47,7 @@ | ||
| 47 | 47 | } | 
| 48 | 48 | |
| 49 | 49 | /** | 
| 50 | - * @return array | |
| 50 | + * @return string[] | |
| 51 | 51 | */ | 
| 52 | 52 | private function parseIsoString() | 
| 53 | 53 |      { | 
| @@ -1,12 +1,12 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-09-25 | |
| 7 | - * | |
| 8 | - * @link: https://github.com/msiebeneicher/chapi/issues/36 | |
| 9 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-09-25 | |
| 7 | + * | |
| 8 | + * @link: https://github.com/msiebeneicher/chapi/issues/36 | |
| 9 | + */ | |
| 10 | 10 | |
| 11 | 11 | |
| 12 | 12 | namespace Chapi\Entity\DatePeriod; | 
| @@ -85,8 +85,7 @@ discard block | ||
| 85 | 85 | 'Job "%s" successfully added to chronos', | 
| 86 | 86 | $_sJobName | 
| 87 | 87 | )); | 
| 88 | - } | |
| 89 | - else | |
| 88 | + } else | |
| 90 | 89 |                  { | 
| 91 | 90 | $this->oLogger->error(sprintf( | 
| 92 | 91 | 'Failed to add job "%s" to chronos', | 
| @@ -109,8 +108,7 @@ discard block | ||
| 109 | 108 | 'Job "%s" successfully removed from chronos', | 
| 110 | 109 | $_sJobName | 
| 111 | 110 | )); | 
| 112 | - } | |
| 113 | - else | |
| 111 | + } else | |
| 114 | 112 |                  { | 
| 115 | 113 | $this->oLogger->error(sprintf( | 
| 116 | 114 | 'Failed to remove job "%s" from chronos', | 
| @@ -134,8 +132,7 @@ discard block | ||
| 134 | 132 | 'Job "%s" successfully updated in chronos', | 
| 135 | 133 | $_sJobName | 
| 136 | 134 | )); | 
| 137 | - } | |
| 138 | - else | |
| 135 | + } else | |
| 139 | 136 |                  { | 
| 140 | 137 | $this->oLogger->error(sprintf( | 
| 141 | 138 | 'Failed to update job "%s" in chronos', | 
| @@ -154,8 +151,7 @@ discard block | ||
| 154 | 151 | if (empty($aJobNames)) | 
| 155 | 152 |          { | 
| 156 | 153 | $_aChronosJobs = $this->oJobRepositoryChronos->getJobs(); | 
| 157 | - } | |
| 158 | - else | |
| 154 | + } else | |
| 159 | 155 |          { | 
| 160 | 156 | $_aChronosJobs = []; | 
| 161 | 157 | foreach ($aJobNames as $_sJobName) | 
| @@ -177,8 +173,7 @@ discard block | ||
| 177 | 173 | 'Job "%s" successfully stored in local repository', | 
| 178 | 174 | $_oJobEntity->name | 
| 179 | 175 | )); | 
| 180 | - } | |
| 181 | - else | |
| 176 | + } else | |
| 182 | 177 |                  { | 
| 183 | 178 | $this->oLogger->error(sprintf( | 
| 184 | 179 | 'Failed to store job "%s" in local repository', | 
| @@ -209,8 +204,7 @@ discard block | ||
| 209 | 204 | 'Job "%s" successfully updated in local repository', | 
| 210 | 205 | $_oJobEntity->name | 
| 211 | 206 | )); | 
| 212 | - } | |
| 213 | - else | |
| 207 | + } else | |
| 214 | 208 |                  { | 
| 215 | 209 | $this->oLogger->error(sprintf( | 
| 216 | 210 | 'Failed to update job "%s" in local repository', | 
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: Chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-31 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: Chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-31 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | |
| 10 | 10 | |
| 11 | 11 | namespace Chapi\Service\JobIndex; | 
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: Chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-28 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: Chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-28 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | namespace Chapi; | 
| 10 | 10 | |
| 11 | 11 | use Symfony\Component\Console\Application; | 
| @@ -1,11 +1,11 @@ discard block | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-21 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-21 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | |
| 10 | 10 | |
| 11 | 11 | namespace Chapi\Commands; | 
| @@ -44,22 +44,22 @@ discard block | ||
| 44 | 44 | private static $sHomeDir = ''; | 
| 45 | 45 | |
| 46 | 46 | /** | 
| 47 | - * Executes the current command. | |
| 48 | - * | |
| 49 | - * This method is not abstract because you can use this class | |
| 50 | - * as a concrete class. In this case, instead of defining the | |
| 51 | - * execute() method, you set the code to execute by passing | |
| 52 | - * a Closure to the setCode() method. | |
| 53 | - * | |
| 54 | - * @param InputInterface $oInput An InputInterface instance | |
| 55 | - * @param OutputInterface $oOutput An OutputInterface instance | |
| 56 | - * | |
| 57 | - * @return integer null or 0 if everything went fine, or an error code | |
| 58 | - * | |
| 59 | - * @throws \LogicException When this abstract method is not implemented | |
| 60 | - * | |
| 61 | - * @see setCode() | |
| 62 | - */ | |
| 47 | + * Executes the current command. | |
| 48 | + * | |
| 49 | + * This method is not abstract because you can use this class | |
| 50 | + * as a concrete class. In this case, instead of defining the | |
| 51 | + * execute() method, you set the code to execute by passing | |
| 52 | + * a Closure to the setCode() method. | |
| 53 | + * | |
| 54 | + * @param InputInterface $oInput An InputInterface instance | |
| 55 | + * @param OutputInterface $oOutput An OutputInterface instance | |
| 56 | + * | |
| 57 | + * @return integer null or 0 if everything went fine, or an error code | |
| 58 | + * | |
| 59 | + * @throws \LogicException When this abstract method is not implemented | |
| 60 | + * | |
| 61 | + * @see setCode() | |
| 62 | + */ | |
| 63 | 63 | protected function execute(InputInterface $oInput, OutputInterface $oOutput) | 
| 64 | 64 |      { | 
| 65 | 65 | $this->oInput = $oInput; | 
| @@ -125,12 +125,14 @@ | ||
| 125 | 125 | if ( | 
| 126 | 126 | !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml') | 
| 127 | 127 | AND !file_exists(getcwd() . DIRECTORY_SEPARATOR . '.chapiconfig') | 
| 128 | - ) // one file have to exist | |
| 128 | +        ) { | |
| 129 | + // one file have to exist | |
| 129 | 130 |          { | 
| 130 | 131 | $this->oOutput->writeln(sprintf( | 
| 131 | 132 | '<error>%s</error>', | 
| 132 | 133 | 'No parameter file found. Please run "configure" command for initial setup or add a local `.chapiconfig` to your working directory.' | 
| 133 | 134 | )); | 
| 135 | + } | |
| 134 | 136 | return false; | 
| 135 | 137 | } | 
| 136 | 138 | |
| @@ -37,8 +37,7 @@ discard block | ||
| 37 | 37 | if (!empty($_sJobName)) | 
| 38 | 38 |          { | 
| 39 | 39 | $this->printJobDiff($_sJobName); | 
| 40 | - } | |
| 41 | - else | |
| 40 | + } else | |
| 42 | 41 |          { | 
| 43 | 42 | $_aLocalJobUpdates = $_oJobComparisonBusinessCase->getLocalJobUpdates(); | 
| 44 | 43 | if (!empty($_aLocalJobUpdates)) | 
| @@ -76,12 +75,10 @@ discard block | ||
| 76 | 75 | if ($_sDiffSign == '+') | 
| 77 | 76 |                  { | 
| 78 | 77 |                      $this->oOutput->writeln(sprintf("<info>%s\t%s: %s</info>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1))); | 
| 79 | - } | |
| 80 | - elseif ($_sDiffSign == '-') | |
| 78 | + } elseif ($_sDiffSign == '-') | |
| 81 | 79 |                  { | 
| 82 | 80 |                      $this->oOutput->writeln(sprintf("<fg=red>%s\t%s: %s</>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1))); | 
| 83 | - } | |
| 84 | - else | |
| 81 | + } else | |
| 85 | 82 |                  { | 
| 86 | 83 |                      $this->oOutput->writeln(sprintf("\t%s: %s", $_sProperty, $_sDiffLine)); | 
| 87 | 84 | } | 
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-30 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-30 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | namespace Chapi\Component\Comparison; | 
| 10 | 10 | |
| 11 | 11 | |
| @@ -49,8 +49,7 @@ | ||
| 49 | 49 | $_mValue = (!empty($_mValue)) | 
| 50 | 50 |                      ? '[ ' . implode(', ', $_mValue) . ' ]' | 
| 51 | 51 | : '[ ]'; | 
| 52 | - } | |
| 53 | - elseif (is_bool($_mValue)) | |
| 52 | + } elseif (is_bool($_mValue)) | |
| 54 | 53 |              { | 
| 55 | 54 | $_mValue = (true === $_mValue) | 
| 56 | 55 | ? 'true' | 
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-30 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-30 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | namespace Chapi\Component\Comparison; | 
| 10 | 10 | |
| 11 | 11 | |
| @@ -50,12 +50,10 @@ | ||
| 50 | 50 |                  { | 
| 51 | 51 | |
| 52 | 52 |                      $this->oOutput->writeln(sprintf("\t<fg=red>%s</>", $_oJobEntity->name)); | 
| 53 | - } | |
| 54 | - elseif ($_oJobEntity->errorCount > 0) | |
| 53 | + } elseif ($_oJobEntity->errorCount > 0) | |
| 55 | 54 |                  { | 
| 56 | 55 |                      $this->oOutput->writeln(sprintf("\t<comment>%s</comment>", $_oJobEntity->name)); | 
| 57 | - } | |
| 58 | - else | |
| 56 | + } else | |
| 59 | 57 |                  { | 
| 60 | 58 |                      $this->oOutput->writeln(sprintf("\t<info>%s</info>", $_oJobEntity->name)); | 
| 61 | 59 | } | 
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-28 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-28 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | |
| 10 | 10 | namespace Chapi\Service\JobRepository; | 
| 11 | 11 | |
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-08-02 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-08-02 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | |
| 10 | 10 | |
| 11 | 11 | namespace Chapi\Commands; | 
| @@ -49,8 +49,7 @@ | ||
| 49 | 49 | if (JobUtils::isWildcard($aJobNames)) | 
| 50 | 50 |          { | 
| 51 | 51 | $_oJobIndexService->resetJobIndex(); | 
| 52 | - } | |
| 53 | - else | |
| 52 | + } else | |
| 54 | 53 |          { | 
| 55 | 54 | $_oJobIndexService->removeJobs($aJobNames); | 
| 56 | 55 | } | 
| @@ -1,11 +1,11 @@ | ||
| 1 | 1 | <?php | 
| 2 | 2 | /** | 
| 3 | - * @package: chapi | |
| 4 | - * | |
| 5 | - * @author: msiebeneicher | |
| 6 | - * @since: 2015-07-31 | |
| 7 | - * | |
| 8 | - */ | |
| 3 | + * @package: chapi | |
| 4 | + * | |
| 5 | + * @author: msiebeneicher | |
| 6 | + * @since: 2015-07-31 | |
| 7 | + * | |
| 8 | + */ | |
| 9 | 9 | |
| 10 | 10 | |
| 11 | 11 | namespace Chapi\Service\JobRepository; |