trivago / chapi

src/Service/JobValidator/PropertyValidator/Epsilon.php

Braces +4 added lines, -3 removed lines

@@ -57,9 +57,11 @@ 
                 $_oDateIntervalEpsilon = new \DateInterval($oJobEntity->epsilon);
                 $_iIntervalEpsilon = (int) $_oDateIntervalEpsilon->format('%Y%M%D%H%I%S');
 
-                if ($_iIntervalEpsilon > 30) // if epsilon > "PT30S"
+                if ($_iIntervalEpsilon > 30) {
+                    // if epsilon > "PT30S"
                 {
                     $_oIso8601Entity = $this->oDatePeriodFactory->createIso8601Entity($oJobEntity->schedule);
+                }
 
                     $_oDateIntervalScheduling = new \DateInterval($_oIso8601Entity->sInterval);
                     $_iIntervalScheduling = (int) $_oDateIntervalScheduling->format('%Y%M%D%H%I%S');
@@ -69,8 +71,7 @@ 
 
                 // if epsilon is less or equal than 30sec the not empty check is enough
                 return true;
-            }
-            catch (\Exception $_oException)
+            } catch (\Exception $_oException)
             {
                 // can't init \DateInterval instance
                 return false;

src/Service/JobValidator/PropertyValidator/Schedule.php

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
             {
                 $_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone);
                 return (false !== $_oDataPeriod);
-            }
-            catch (\Exception $oException)
+            } catch (\Exception $oException)
             {
                 // invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod
             }

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->oDiffCompare = $oDiffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         if (
             !$oLocalJob instanceof MarathonAppEntity ||

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     }
 
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         // no modification needed
         return;

src/Component/Http/HttpGuzzlClient.php

Braces +6 added lines, -12 removed lines

@@ -59,48 +59,42 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (ClientException $oException) // 400 level errors
+        } catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (ServerException $oException) // 500 level errors
+        } catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (TooManyRedirectsException $oException) // too many redirects to follow
+        } catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
                 sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (ConnectException $oException) // networking error
+        } catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
+        } catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),

src/Component/DatePeriod/DatePeriodFactory.php

Braces +1 added lines, -2 removed lines

@@ -38,8 +38,7 @@
         try
         {
             return self::$aIso8601Entity[$_sKey] = new Iso8601Entity($sIso8601);
-        }
-        catch (\InvalidArgumentException $_oException)
+        } catch (\InvalidArgumentException $_oException)
         {
             throw new DatePeriodException(sprintf("Can't init Iso8601Entity for '%s' iso 8601 string.", $sIso8601), 1, $_oException);
         }

src/BusinessCase/Comparison/AbstractJobComparisionBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -219,7 +219,7 @@
      * @param JobEntityInterface $oRemoteJob
      * @return null
      */
-    abstract protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob);
+    abstract protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob);
 
     /**
      * Gets entity for each system with defaults set

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Braces +1 added lines, -2 removed lines

@@ -95,8 +95,7 @@
                         ));
                         return false;
                     }
-                }
-                catch (\Exception $e)
+                } catch (\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         'Job %s cannot be added to remote : %s', $sAppId, $e->getMessage()

src/Commands/ConfigureCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
     }
 
     /**
-     * @param null $sProfile
+     * @param string $sProfile
      * @return array|mixed
      */
     private function loadConfigFile($sProfile = null)

Unused Use Statements -2 removed lines

@@ -9,8 +9,6 @@
 
 namespace Chapi\Commands;
 
-use Chapi\Component\DependencyInjection\Loader\YamChapiConfigLoader;
-use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;