trivago / chapi

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,9 +46,9 @@
 
 
     /**
-     * @param JobRepositoryInterface $oJobRepositoryLocal
+     * @param JobRepositoryInterface $oJobRepositoryLocalChronos
      * @param JobRepositoryInterface $oJobRepositoryChronos
-     * @param JobRepositoryInterface $oJobRepositoryMarathon
+     * @param JobRepositoryInterface $oJobRepositoryLocalChronos
      * @param DiffCompareInterface $oDiffCompare
      * @param DatePeriodFactoryInterface $oDatePeriodFactory
      * @param LoggerInterface $oLogger

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,8 +11,8 @@
 
 use Chapi\Component\Comparison\DiffCompareInterface;
 use Chapi\Component\DatePeriod\DatePeriodFactoryInterface;
-use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\Chronos\ChronosJobEntity;
+use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 use Psr\Log\LoggerInterface;

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Unused Use Statements -2 removed lines

@@ -15,8 +15,6 @@
 use Chapi\Entity\Chronos\ChronosJobEntity;
 use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\AppEntity\FetchUrl;
-use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +6 added lines

@@ -150,6 +150,9 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $immediateChildren
+     */
     private function isDependencyCircular(JobEntityInterface $oEntity, $immediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
@@ -310,6 +313,9 @@ 
         }
     }
 
+    /**
+     * @param boolean $bForceOverwrite
+     */
     private function updateJobInLocalRepository($oAppRemote, $bForceOverwrite)
     {
         $_aDiff = $this->oJobComparisionBusinessCase->getJobDiff($oAppRemote->getKey());

src/BusinessCase/JobManagement/StoreJobBusinessCaseFactoryInterface.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     /**
      * @param StoreJobBusinessCaseInterface $oStoreJob
      * @return
-     */
+     void
     public function addBusinesCase(StoreJobBusinessCaseInterface $oStoreJob);
 
     /**

src/Commands/ListCommand.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 use Chapi\Entity\Chronos\ChronosJobEntity;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputOption;

src/Component/RemoteClients/ChronosApiClient.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,8 +11,8 @@
 namespace Chapi\Component\RemoteClients;
 
 
-use Chapi\Component\RemoteClients\ApiClientInterface;
 use Chapi\Component\Http\HttpClientInterface;
+use Chapi\Component\RemoteClients\ApiClientInterface;
 use Chapi\Entity\Chronos\ChronosJobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Exception\ApiClientException;

src/Entity/Marathon/AppSubEntityFactory.php

Unused Use Statements -2 removed lines

@@ -9,13 +9,11 @@
 
 namespace Chapi\Entity\Marathon;
 
-use Chapi\Entity\Marathon\AppEntity;
 use Chapi\Entity\Marathon\AppEntity\Container;
 use Chapi\Entity\Marathon\AppEntity\FetchUrl;
 use Chapi\Entity\Marathon\AppEntity\HealthCheck;
 use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\AppEntity\UpgradeStrategy;
-use SebastianBergmann\Comparator\ExceptionComparatorTest;
 
 class AppSubEntityFactory implements AppSubEntityFactoryInterface
 {

src/Service/JobRepository/BridgeFileSystem.php

Doc Comments +3 added lines

@@ -347,6 +347,9 @@
     }
 
 
+    /**
+     * @param string $sJobFile
+     */
     private function dumpFileWithGroup($sJobFile, JobEntityInterface $oJobEntity, $bAdd = true)
     {
         $_sGroupConfig = file_get_contents($sJobFile);

src/Service/JobRepository/BridgeMarathon.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 use Chapi\Component\Cache\CacheInterface;
 use Chapi\Component\RemoteClients\ApiClientInterface;
-use Chapi\Entity\Chronos\ChronosJobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobValidator\JobValidatorServiceInterface;