trivago / chapi

src/Commands/DiffCommand.php

Braces +3 added lines, -6 removed lines

@@ -37,8 +37,7 @@ 
         if (!empty($_sJobName))
         {
             $this->printJobDiff($_sJobName);
-        }
-        else
+        } else
         {
             $_aLocalJobUpdates = $_oJobComparisonBusinessCase->getLocalJobUpdates();
             if (!empty($_aLocalJobUpdates))
@@ -76,12 +75,10 @@ 
                 if ($_sDiffSign == '+')
                 {
                     $this->oOutput->writeln(sprintf("<info>%s\t%s: %s</info>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1)));
-                }
-                elseif ($_sDiffSign == '-')
+                } elseif ($_sDiffSign == '-')
                 {
                     $this->oOutput->writeln(sprintf("<fg=red>%s\t%s: %s</>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1)));
-                }
-                else
+                } else
                 {
                     $this->oOutput->writeln(sprintf("\t%s: %s", $_sProperty, $_sDiffLine));
                 }

src/Commands/ResetCommand.php

Braces +1 added lines, -2 removed lines

@@ -49,8 +49,7 @@
         if (JobUtils::isWildcard($aJobNames))
         {
             $_oJobIndexService->resetJobIndex();
-        }
-        else
+        } else
         {
             $_oJobIndexService->removeJobs($aJobNames);
         }

src/Commands/SchedulingViewCommand.php

Braces +5 added lines, -10 removed lines

@@ -250,13 +250,11 @@ 
                 {
                     $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, $_oTime->format('H>i'), $_oTime->format('H:i'));
 
-                }
-                else
+                } else
                 {
                     $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, str_repeat('>', 5), str_repeat($_sSpacer, 5));
                 }
-            }
-            else
+            } else
             {
                 $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, '>', $_sSpacer);
             }
@@ -284,18 +282,15 @@ 
         if ($bPrintJobStart && $bPrintJobEnd)
         {
             $_sTimelineSnippet = sprintf('<comment>%s</comment>', $sStartStopMark);
-        }
-        elseif ($bPrintJobStart)
+        } elseif ($bPrintJobStart)
         {
             $_sTimelineSnippet = sprintf('<comment>%s', $sStartStopMark);
             $bHasToCloseFinalTag = true;
-        }
-        elseif ($bPrintJobEnd)
+        } elseif ($bPrintJobEnd)
         {
             $_sTimelineSnippet = sprintf('%s</comment>', $sStartStopMark);
             $bHasToCloseFinalTag = false;
-        }
-        else
+        } else
         {
             $_sTimelineSnippet = $sSpacer;
         }

Spacing +4 added lines, -4 removed lines

@@ -73,7 +73,7 @@ 
         $_iStartTime = ($_sStartTime == null) ? $_iCurrentTime : strtotime($_sStartTime);
         if ($_sStartTime != null && $_iStartTime < $_iCurrentTime)
         {
-            $_iStartTime = strtotime($_sStartTime . ' + 24 hours');
+            $_iStartTime = strtotime($_sStartTime.' + 24 hours');
         }
 
         $_iEndTime = ($_sEndTime == null) ? $_iStartTime + 7200 : strtotime($_sEndTime);
@@ -95,7 +95,7 @@ 
         $_oTable = new Table($this->oOutput);
         $_oTable->setHeaders(array(
             'Job',
-            'Timeline for ' . date('Y-m-d H:i', $iStartTime) . ' till ' . date('Y-m-d H:i', $iEndTime)
+            'Timeline for '.date('Y-m-d H:i', $iStartTime).' till '.date('Y-m-d H:i', $iEndTime)
         ));
 
         $_aJobs = $this->getJobsWhichShouldStartInPeriod($iStartTime, $iEndTime);
@@ -163,7 +163,7 @@ 
 
             $oTable->addRow(
                 array(
-                    str_repeat('   ', $iCurrentChildLevel) . '|_ ' . $_sChildJobName,
+                    str_repeat('   ', $iCurrentChildLevel).'|_ '.$_sChildJobName,
                     $this->getTimelineStr(
                         $oDisplayPeriod,
                         $oJobDatePeriod,
@@ -317,7 +317,7 @@ 
         {
             if ($iJobStartTimeDelay > 0)
             {
-                $_oJobTime->add(new \DateInterval('PT' . $iJobStartTimeDelay . 'S'));
+                $_oJobTime->add(new \DateInterval('PT'.$iJobStartTimeDelay.'S'));
             }
 
             $_aStartTimes[$_oJobTime->format('YmdHi')] = $_oJobTime;

src/Commands/StatusCommand.php

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
                 {
                     $_aFilteredJobList[] = $_sJobName;
                 }
-            }
-            else
+            } else
             {
                 if (!$this->oJobIndexService->isJobInIndex($_sJobName))
                 {

src/Commands/ListCommand.php

Spacing +2 added lines, -2 removed lines

@@ -129,12 +129,12 @@
                 ? 100 / $oJobEntity->successCount * $oJobEntity->errorCount
                 : 100;
 
-            $_aJobInfoText[] = 'errors rate: ' . round($_fErrorRate, 2) . '%';
+            $_aJobInfoText[] = 'errors rate: '.round($_fErrorRate, 2).'%';
         }
 
         if ($oJobEntity->errorsSinceLastSuccess > 0)
         {
-            $_aJobInfoText[] = 'errors since last success:' . $oJobEntity->errorsSinceLastSuccess;
+            $_aJobInfoText[] = 'errors since last success:'.$oJobEntity->errorsSinceLastSuccess;
         }
 
         return (!empty($_aJobInfoText))

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 use Chapi\Entity\Chronos\ChronosJobEntity;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputOption;

src/Commands/AbstractCommand.php

Spacing +6 added lines, -6 removed lines

@@ -99,7 +99,7 @@ 
             $this->loadParameterConfig($this->getWorkingDir(), '.chapiconfig', $_oContainer);
 
             // load services
-            $_oLoader = new YamlFileLoader($_oContainer, new FileLocator(__DIR__ . self::FOLDER_RESOURCES));
+            $_oLoader = new YamlFileLoader($_oContainer, new FileLocator(__DIR__.self::FOLDER_RESOURCES));
             $_oLoader->load('services.yml');
 
             self::$oContainer = $_oContainer;
@@ -114,8 +114,8 @@ 
     protected function isAppRunable()
     {
         if (
-            !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml')
-            && !file_exists($this->getWorkingDir() . DIRECTORY_SEPARATOR . '.chapiconfig')
+            !file_exists($this->getHomeDir().DIRECTORY_SEPARATOR.'parameters.yml')
+            && !file_exists($this->getWorkingDir().DIRECTORY_SEPARATOR.'.chapiconfig')
         ) // one file have to exist
         {
             $this->oOutput->writeln(sprintf(
@@ -141,7 +141,7 @@ 
         $_sHomeDir = getenv('CHAPI_HOME');
         if (!$_sHomeDir)
         {
-            $_sHomeDir = CommandUtils::getOsHomeDir() . DIRECTORY_SEPARATOR . '.chapi';
+            $_sHomeDir = CommandUtils::getOsHomeDir().DIRECTORY_SEPARATOR.'.chapi';
         }
 
         CommandUtils::hasCreateDirectoryIfNotExists($_sHomeDir);
@@ -154,7 +154,7 @@ 
      */
     protected function getCacheDir()
     {
-        $_sCacheDir = $this->getHomeDir() . DIRECTORY_SEPARATOR . 'cache';
+        $_sCacheDir = $this->getHomeDir().DIRECTORY_SEPARATOR.'cache';
         CommandUtils::hasCreateDirectoryIfNotExists($_sCacheDir);
 
         return $_sCacheDir;
@@ -176,7 +176,7 @@ 
     private function loadParameterConfig($sPath, $sFile, $oContainer)
     {
         // load local parameters
-        if (file_exists($sPath . DIRECTORY_SEPARATOR . $sFile))
+        if (file_exists($sPath.DIRECTORY_SEPARATOR.$sFile))
         {
             $_oLoader = new YamlFileLoader($oContainer, new FileLocator($sPath));
             $_oLoader->load($sFile);

Braces +3 added lines, -1 removed lines

@@ -116,12 +116,14 @@
         if (
             !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml')
             && !file_exists($this->getWorkingDir() . DIRECTORY_SEPARATOR . '.chapiconfig')
-        ) // one file have to exist
+        ) {
+            // one file have to exist
         {
             $this->oOutput->writeln(sprintf(
                 '<error>%s</error>',
                 'No parameter file found. Please run "configure" command for initial setup or add a local `.chapiconfig` to your working directory.'
             ));
+        }
             return false;
         }
 

src/Commands/ConfigureCommand.php

Spacing +2 added lines, -2 removed lines

@@ -136,7 +136,7 @@ 
         $_sYaml = $_oDumper->dump(array('parameters' => $aToStore));
 
         $_oFileSystem = new Filesystem();
-        $_oFileSystem->dumpFile($this->getHomeDir() . '/parameters.yml', $_sYaml);
+        $_oFileSystem->dumpFile($this->getHomeDir().'/parameters.yml', $_sYaml);
     }
 
     /**
@@ -165,7 +165,7 @@ 
     private function getParameterValue($sKey, $mDefaultValue = null)
     {
         $_oParser = new Parser();
-        $_sParameterFile = $this->getHomeDir() . '/parameters.yml';
+        $_sParameterFile = $this->getHomeDir().'/parameters.yml';
 
         if (file_exists($_sParameterFile))
         {

src/Component/Cache/DoctrineCache.php

Spacing +5 added lines, -5 removed lines

@@ -36,7 +36,7 @@ 
             md5($sCachePrefix),
             0,
             6
-        ) . '.';
+        ).'.';
     }
 
     /**
@@ -47,7 +47,7 @@ 
      */
     public function set($sKey, $mValue, $iTTL = 0)
     {
-        return $this->oDoctrineCache->save($this->sCachePrefix . $sKey, $mValue, $iTTL);
+        return $this->oDoctrineCache->save($this->sCachePrefix.$sKey, $mValue, $iTTL);
     }
 
     /**
@@ -56,8 +56,8 @@ 
      */
     public function get($sKey)
     {
-        return ($this->oDoctrineCache->contains($this->sCachePrefix . $sKey))
-            ? $this->oDoctrineCache->fetch($this->sCachePrefix . $sKey)
+        return ($this->oDoctrineCache->contains($this->sCachePrefix.$sKey))
+            ? $this->oDoctrineCache->fetch($this->sCachePrefix.$sKey)
             : null
         ;
     }
@@ -68,6 +68,6 @@ 
      */
     public function delete($sKey)
     {
-        return $this->oDoctrineCache->delete($this->sCachePrefix . $sKey);
+        return $this->oDoctrineCache->delete($this->sCachePrefix.$sKey);
     }
 }
\ No newline at end of file

src/Component/Http/HttpGuzzlClient.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         catch (\Exception $oException)
         {
             throw new HttpConnectionException(
-                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 0,
                 $oException
             );

Braces +1 added lines, -2 removed lines

@@ -54,8 +54,7 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),