trivago / chapi

src/Commands/ListCommand.php

Spacing +2 added lines, -2 removed lines

@@ -129,12 +129,12 @@
                 ? 100 / $oJobEntity->successCount * $oJobEntity->errorCount
                 : 100;
 
-            $_aJobInfoText[] = 'errors rate: ' . round($_fErrorRate, 2) . '%';
+            $_aJobInfoText[] = 'errors rate: '.round($_fErrorRate, 2).'%';
         }
 
         if ($oJobEntity->errorsSinceLastSuccess > 0)
         {
-            $_aJobInfoText[] = 'errors since last success:' . $oJobEntity->errorsSinceLastSuccess;
+            $_aJobInfoText[] = 'errors since last success:'.$oJobEntity->errorsSinceLastSuccess;
         }
 
         return (!empty($_aJobInfoText))

src/Commands/AbstractCommand.php

Spacing +6 added lines, -6 removed lines

@@ -99,7 +99,7 @@ 
             $this->loadParameterConfig($this->getWorkingDir(), '.chapiconfig', $_oContainer);
 
             // load services
-            $_oLoader = new YamlFileLoader($_oContainer, new FileLocator(__DIR__ . self::FOLDER_RESOURCES));
+            $_oLoader = new YamlFileLoader($_oContainer, new FileLocator(__DIR__.self::FOLDER_RESOURCES));
             $_oLoader->load('services.yml');
 
             self::$oContainer = $_oContainer;
@@ -114,8 +114,8 @@ 
     protected function isAppRunable()
     {
         if (
-            !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml')
-            && !file_exists($this->getWorkingDir() . DIRECTORY_SEPARATOR . '.chapiconfig')
+            !file_exists($this->getHomeDir().DIRECTORY_SEPARATOR.'parameters.yml')
+            && !file_exists($this->getWorkingDir().DIRECTORY_SEPARATOR.'.chapiconfig')
         ) // one file have to exist
         {
             $this->oOutput->writeln(sprintf(
@@ -141,7 +141,7 @@ 
         $_sHomeDir = getenv('CHAPI_HOME');
         if (!$_sHomeDir)
         {
-            $_sHomeDir = CommandUtils::getOsHomeDir() . DIRECTORY_SEPARATOR . '.chapi';
+            $_sHomeDir = CommandUtils::getOsHomeDir().DIRECTORY_SEPARATOR.'.chapi';
         }
 
         CommandUtils::hasCreateDirectoryIfNotExists($_sHomeDir);
@@ -154,7 +154,7 @@ 
      */
     protected function getCacheDir()
     {
-        $_sCacheDir = $this->getHomeDir() . DIRECTORY_SEPARATOR . 'cache';
+        $_sCacheDir = $this->getHomeDir().DIRECTORY_SEPARATOR.'cache';
         CommandUtils::hasCreateDirectoryIfNotExists($_sCacheDir);
 
         return $_sCacheDir;
@@ -176,7 +176,7 @@ 
     private function loadParameterConfig($sPath, $sFile, $oContainer)
     {
         // load local parameters
-        if (file_exists($sPath . DIRECTORY_SEPARATOR . $sFile))
+        if (file_exists($sPath.DIRECTORY_SEPARATOR.$sFile))
         {
             $_oLoader = new YamlFileLoader($oContainer, new FileLocator($sPath));
             $_oLoader->load($sFile);

src/Commands/ConfigureCommand.php

Spacing +2 added lines, -2 removed lines

@@ -136,7 +136,7 @@ 
         $_sYaml = $_oDumper->dump(array('parameters' => $aToStore));
 
         $_oFileSystem = new Filesystem();
-        $_oFileSystem->dumpFile($this->getHomeDir() . '/parameters.yml', $_sYaml);
+        $_oFileSystem->dumpFile($this->getHomeDir().'/parameters.yml', $_sYaml);
     }
 
     /**
@@ -165,7 +165,7 @@ 
     private function getParameterValue($sKey, $mDefaultValue = null)
     {
         $_oParser = new Parser();
-        $_sParameterFile = $this->getHomeDir() . '/parameters.yml';
+        $_sParameterFile = $this->getHomeDir().'/parameters.yml';
 
         if (file_exists($_sParameterFile))
         {

src/Commands/SchedulingViewCommand.php

Spacing +4 added lines, -4 removed lines

@@ -73,7 +73,7 @@ 
         $_iStartTime = ($_sStartTime == null) ? $_iCurrentTime : strtotime($_sStartTime);
         if ($_sStartTime != null && $_iStartTime < $_iCurrentTime)
         {
-            $_iStartTime = strtotime($_sStartTime . ' + 24 hours');
+            $_iStartTime = strtotime($_sStartTime.' + 24 hours');
         }
 
         $_iEndTime = ($_sEndTime == null) ? $_iStartTime + 7200 : strtotime($_sEndTime);
@@ -95,7 +95,7 @@ 
         $_oTable = new Table($this->oOutput);
         $_oTable->setHeaders(array(
             'Job',
-            'Timeline for ' . date('Y-m-d H:i', $iStartTime) . ' till ' . date('Y-m-d H:i', $iEndTime)
+            'Timeline for '.date('Y-m-d H:i', $iStartTime).' till '.date('Y-m-d H:i', $iEndTime)
         ));
 
         $_aJobs = $this->getJobsWhichShouldStartInPeriod($iStartTime, $iEndTime);
@@ -163,7 +163,7 @@ 
 
             $oTable->addRow(
                 array(
-                    str_repeat('   ', $iCurrentChildLevel) . '|_ ' . $_sChildJobName,
+                    str_repeat('   ', $iCurrentChildLevel).'|_ '.$_sChildJobName,
                     $this->getTimelineStr(
                         $oDisplayPeriod,
                         $oJobDatePeriod,
@@ -317,7 +317,7 @@ 
         {
             if ($iJobStartTimeDelay > 0)
             {
-                $_oJobTime->add(new \DateInterval('PT' . $iJobStartTimeDelay . 'S'));
+                $_oJobTime->add(new \DateInterval('PT'.$iJobStartTimeDelay.'S'));
             }
 
             $_aStartTimes[$_oJobTime->format('YmdHi')] = $_oJobTime;

src/Component/Cache/DoctrineCache.php

Spacing +5 added lines, -5 removed lines

@@ -36,7 +36,7 @@ 
             md5($sCachePrefix),
             0,
             6
-        ) . '.';
+        ).'.';
     }
 
     /**
@@ -47,7 +47,7 @@ 
      */
     public function set($sKey, $mValue, $iTTL = 0)
     {
-        return $this->oDoctrineCache->save($this->sCachePrefix . $sKey, $mValue, $iTTL);
+        return $this->oDoctrineCache->save($this->sCachePrefix.$sKey, $mValue, $iTTL);
     }
 
     /**
@@ -56,8 +56,8 @@ 
      */
     public function get($sKey)
     {
-        return ($this->oDoctrineCache->contains($this->sCachePrefix . $sKey))
-            ? $this->oDoctrineCache->fetch($this->sCachePrefix . $sKey)
+        return ($this->oDoctrineCache->contains($this->sCachePrefix.$sKey))
+            ? $this->oDoctrineCache->fetch($this->sCachePrefix.$sKey)
             : null
         ;
     }
@@ -68,6 +68,6 @@ 
      */
     public function delete($sKey)
     {
-        return $this->oDoctrineCache->delete($this->sCachePrefix . $sKey);
+        return $this->oDoctrineCache->delete($this->sCachePrefix.$sKey);
     }
 }
\ No newline at end of file

src/Component/Http/HttpGuzzlClient.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         catch (\Exception $oException)
         {
             throw new HttpConnectionException(
-                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 0,
                 $oException
             );

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,9 +46,9 @@
 
 
     /**
-     * @param JobRepositoryInterface $oJobRepositoryLocal
+     * @param JobRepositoryInterface $oJobRepositoryLocalChronos
      * @param JobRepositoryInterface $oJobRepositoryChronos
-     * @param JobRepositoryInterface $oJobRepositoryMarathon
+     * @param JobRepositoryInterface $oJobRepositoryLocalChronos
      * @param DiffCompareInterface $oDiffCompare
      * @param DatePeriodFactoryInterface $oDatePeriodFactory
      * @param LoggerInterface $oLogger

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
      */
     public function getRemoteMissingJobs()
     {
-        $_ret =  $this->getMissingJobsInCollectionA(
+        $_ret = $this->getMissingJobsInCollectionA(
             $this->oJobRepositoryChronos->getJobs(),
             $this->oJobRepositoryLocalChronos->getJobs()
         );

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +6 added lines

@@ -150,6 +150,9 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $immediateChildren
+     */
     private function isDependencyCircular(JobEntityInterface $oEntity, $immediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
@@ -310,6 +313,9 @@ 
         }
     }
 
+    /**
+     * @param boolean $bForceOverwrite
+     */
     private function updateJobInLocalRepository($oAppRemote, $bForceOverwrite)
     {
         $_aDiff = $this->oJobComparisionBusinessCase->getJobDiff($oAppRemote->getKey());

Spacing +5 added lines, -5 removed lines

@@ -89,7 +89,7 @@ 
             $_oJobEntityLocal = $this->oJobRepositoryLocal->getJob($sAppId);
 
             // check if dependency is satisfied
-            if ( $_oJobEntityLocal->isDependencyJob())
+            if ($_oJobEntityLocal->isDependencyJob())
             {
                 try {
                     $circular = $this->isDependencyCircular($_oJobEntityLocal, count($_oJobEntityLocal->dependencies));
@@ -101,10 +101,10 @@ 
                         return false;
                     }
                 }
-                catch(\Exception $e)
+                catch (\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
-                        "Job %s cannot be added to remote : %s",$sAppId, $e->getMessage()
+                        "Job %s cannot be added to remote : %s", $sAppId, $e->getMessage()
                     ));
                     return false;
                 }
@@ -150,7 +150,7 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
-    private function isDependencyCircular(JobEntityInterface $oEntity, $immediateChildren, &$path=[])
+    private function isDependencyCircular(JobEntityInterface $oEntity, $immediateChildren, &$path = [])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
         if ($this->hasDuplicates($path))
@@ -196,7 +196,7 @@ 
             // for B intermediate Child will be 2.
             // when we process D, it will be reduced to 1 and with C to 0
             // then we will pop B to generate path [A, E] when we reach E.
-            $immediateChildren = $immediateChildren -1;
+            $immediateChildren = $immediateChildren - 1;
             if ($immediateChildren == 0)
             {
                 array_pop($path);

src/BusinessCase/JobManagement/StoreJobBusinessCaseFactoryInterface.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     /**
      * @param StoreJobBusinessCaseInterface $oStoreJob
      * @return
-     */
+     void
     public function addBusinesCase(StoreJobBusinessCaseInterface $oStoreJob);
 
     /**