trivago / chapi

src/Commands/DiffCommand.php

Braces +3 added lines, -6 removed lines

@@ -37,8 +37,7 @@ 
         if (!empty($_sJobName))
         {
             $this->printJobDiff($_sJobName);
-        }
-        else
+        } else
         {
             $_aLocalJobUpdates = $_oJobComparisonBusinessCase->getLocalJobUpdates();
             if (!empty($_aLocalJobUpdates))
@@ -76,12 +75,10 @@ 
                 if ($_sDiffSign == '+')
                 {
                     $this->oOutput->writeln(sprintf("<info>%s\t%s: %s</info>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1)));
-                }
-                elseif ($_sDiffSign == '-')
+                } elseif ($_sDiffSign == '-')
                 {
                     $this->oOutput->writeln(sprintf("<fg=red>%s\t%s: %s</>", $_sDiffSign, $_sProperty, substr($_sDiffLine, 1)));
-                }
-                else
+                } else
                 {
                     $this->oOutput->writeln(sprintf("\t%s: %s", $_sProperty, $_sDiffLine));
                 }

src/Commands/ResetCommand.php

Braces +1 added lines, -2 removed lines

@@ -49,8 +49,7 @@
         if (JobUtils::isWildcard($aJobNames))
         {
             $_oJobIndexService->resetJobIndex();
-        }
-        else
+        } else
         {
             $_oJobIndexService->removeJobs($aJobNames);
         }

src/Commands/SchedulingViewCommand.php

Braces +5 added lines, -10 removed lines

@@ -250,13 +250,11 @@ 
                 {
                     $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, $_oTime->format('H>i'), $_oTime->format('H:i'));
 
-                }
-                else
+                } else
                 {
                     $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, str_repeat('>', 5), str_repeat($_sSpacer, 5));
                 }
-            }
-            else
+            } else
             {
                 $_sTimeline .= $this->parseTimeLineStrMark($_bPrintJobStart, $_bPrintJobEnd, $_bHasToCloseFinalTag, '>', $_sSpacer);
             }
@@ -284,18 +282,15 @@ 
         if ($bPrintJobStart && $bPrintJobEnd)
         {
             $_sTimelineSnippet = sprintf('<comment>%s</comment>', $sStartStopMark);
-        }
-        elseif ($bPrintJobStart)
+        } elseif ($bPrintJobStart)
         {
             $_sTimelineSnippet = sprintf('<comment>%s', $sStartStopMark);
             $bHasToCloseFinalTag = true;
-        }
-        elseif ($bPrintJobEnd)
+        } elseif ($bPrintJobEnd)
         {
             $_sTimelineSnippet = sprintf('%s</comment>', $sStartStopMark);
             $bHasToCloseFinalTag = false;
-        }
-        else
+        } else
         {
             $_sTimelineSnippet = $sSpacer;
         }

src/Commands/StatusCommand.php

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
                 {
                     $_aFilteredJobList[] = $_sJobName;
                 }
-            }
-            else
+            } else
             {
                 if (!$this->oJobIndexService->isJobInIndex($_sJobName))
                 {

src/Entity/Chronos/JobEntity/ContainerEntity.php

Braces +3 added lines, -6 removed lines

@@ -26,23 +26,20 @@
                     if ($_sKey == 'type')
                     {
                         $this->{$_sKey} = strtolower($_mValue);
-                    }
-                    elseif ($_sKey == 'volumes')
+                    } elseif ($_sKey == 'volumes')
                     {
                         foreach ($_mValue as $_mValueVolume)
                         {
                             $_oVolume = new ContainerVolumeEntity($_mValueVolume);
                             $this->volumes[] = $_oVolume;
                         }
-                    }
-                    else
+                    } else
                     {
                         $this->{$_sKey} = $_mValue;
                     }
                 }
             }
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
         }

src/Service/JobValidator/PropertyValidator/Epsilon.php

Braces +4 added lines, -3 removed lines

@@ -57,9 +57,11 @@ 
                 $_oDateIntervalEpsilon = new \DateInterval($oJobEntity->epsilon);
                 $_iIntervalEpsilon = (int) $_oDateIntervalEpsilon->format('%Y%M%D%H%I%S');
 
-                if ($_iIntervalEpsilon > 30) // if epsilon > "PT30S"
+                if ($_iIntervalEpsilon > 30) {
+                    // if epsilon > "PT30S"
                 {
                     $_oIso8601Entity = $this->oDatePeriodFactory->createIso8601Entity($oJobEntity->schedule);
+                }
 
                     $_oDateIntervalScheduling = new \DateInterval($_oIso8601Entity->sInterval);
                     $_iIntervalScheduling = (int) $_oDateIntervalScheduling->format('%Y%M%D%H%I%S');
@@ -69,8 +71,7 @@ 
 
                 // if epsilon is less or equal than 30sec the not empty check is enough
                 return true;
-            }
-            catch (\Exception $_oException)
+            } catch (\Exception $_oException)
             {
                 // can't init \DateInterval instance
                 return false;

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     }
 
     /**
-     * @param JobEntity $oJobEntity
+     * @param JobEntityInterface $oJobEntity
      * @return bool
      */
     private function isEpsilonPropertyValid(JobEntityInterface $oJobEntity)

src/Service/JobValidator/PropertyValidator/Schedule.php

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
             {
                 $_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone);
                 return (false !== $_oDataPeriod);
-            }
-            catch (\Exception $oException)
+            } catch (\Exception $oException)
             {
                 // invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod
             }

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,9 +46,9 @@
 
 
     /**
-     * @param JobRepositoryInterface $oJobRepositoryLocal
+     * @param JobRepositoryInterface $oJobRepositoryLocalChronos
      * @param JobRepositoryInterface $oJobRepositoryChronos
-     * @param JobRepositoryInterface $oJobRepositoryMarathon
+     * @param JobRepositoryInterface $oJobRepositoryLocalChronos
      * @param DiffCompareInterface $oDiffCompare
      * @param DatePeriodFactoryInterface $oDatePeriodFactory
      * @param LoggerInterface $oLogger

Braces +1 added lines, -2 removed lines

@@ -317,8 +317,7 @@
         {
             $_oDateTime = new \DateTime(str_replace('Z', '', $_oIso8601Entity->sStartTime));
             $_oDateTime->setTimezone(new \DateTimeZone($sTimeZone));
-        }
-        else
+        } else
         {
             $_oDateTime = new \DateTime($_oIso8601Entity->sStartTime);
         }

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +6 added lines

@@ -150,6 +150,9 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $immediateChildren
+     */
     private function isDependencyCircular(JobEntityInterface $oEntity, $immediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
@@ -310,6 +313,9 @@ 
         }
     }
 
+    /**
+     * @param boolean $bForceOverwrite
+     */
     private function updateJobInLocalRepository($oAppRemote, $bForceOverwrite)
     {
         $_aDiff = $this->oJobComparisionBusinessCase->getJobDiff($oAppRemote->getKey());

Braces +7 added lines, -10 removed lines

@@ -100,8 +100,7 @@ 
                         ));
                         return false;
                     }
-                }
-                catch(\Exception $e)
+                } catch(\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         "Job %s cannot be added to remote : %s",$sAppId, $e->getMessage()
@@ -268,8 +267,7 @@ 
         if (empty($aJobNames))
         {
             $_aApps = $this->oJobRepositoryRemote->getJobs();
-        }
-        else
+        } else
         {
             $_aApps = [];
             foreach ($aJobNames as $_sAppName)
@@ -282,11 +280,12 @@ 
         foreach ($_aApps as $_oAppRemote)
         {
             $_oAppLocal = $this->oJobRepositoryLocal->getJob($_oAppRemote->getKey());
-            if (null == $_oAppLocal) // add
+            if (null == $_oAppLocal) {
+                // add
             {
                 $this->addJobInLocalRepository($_oAppRemote);
             }
-            else // update
+            } else // update
             {
                 $this->updateJobInLocalRepository($_oAppRemote, $bForceOverwrite);
             }
@@ -301,8 +300,7 @@ 
                 'App %s stored in local repository',
                 $oAppRemote->getKey()
             ));
-        }
-        else {
+        } else {
             $this->oLogger->error(sprintf(
                 'Failed to store %s in local repository',
                 $oAppRemote->getKey()
@@ -331,8 +329,7 @@ 
                     'App %s is updated in local repository',
                     $oAppRemote->getKey()
                 ));
-            }
-            else {
+            } else {
                 $this->oLogger->error(sprintf(
                     'Failed to update app %s in local repository',
                     $oAppRemote->getKey()