tracim.views.default.default_controller

Complexity

Total Complexity

12

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	DefaultController.test_manager_page()	0	8	2
B	DefaultController.bind()	0	37	1
A	DefaultController.test_config()	0	8	2
A	DefaultController.notfound_view()	0	4	1
A	DefaultController.forbidden_view()	0	10	2
A	DefaultController.test_user_page()	0	8	2
A	DefaultController.test_admin_page()	0	8	2

# coding=utf-8

This module should have a docstring.

from tracim.views.controllers import Controller
from pyramid.config import Configurator
from pyramid.response import Response
from pyramid.exceptions import NotFound
from pyramid.httpexceptions import HTTPUnauthorized
from pyramid.httpexceptions import HTTPForbidden
from pyramid.security import forget


class DefaultController(Controller):

This class should have a docstring.

The variable __class__ seems to be unused.

    @classmethod
    def notfound_view(cls, request):

This method should have a docstring.

        request.response.status = 404
        return {}

    @classmethod
    def forbidden_view(cls, request):

This method should have a docstring.

        if request.authenticated_userid is None:
            response = HTTPUnauthorized()
            response.headers.update(forget(request))

        # user is logged in but doesn't have permissions, reject wholesale
        else:
            response = HTTPForbidden()
        return response

    @classmethod
    def test_config(cls, request):

This method should have a docstring.

        try:
            app_config = request.registry.settings['CFG']
            project = app_config.WEBSITE_TITLE
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}

    @classmethod
    def test_admin_page(cls, request):

This method should have a docstring.

        try:
            app_config = request.registry.settings['CFG']

The variable app_config seems to be unused.

            project = 'admin'
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}

    @classmethod
    def test_manager_page(cls, request):

This method should have a docstring.

        try:
            app_config = request.registry.settings['CFG']

The variable app_config seems to be unused.

            project = 'manager'
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}

    @classmethod
    def test_user_page(cls, request):

This method should have a docstring.

        try:
            app_config = request.registry.settings['CFG']

The variable app_config seems to be unused.

            project = 'user'
        except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}


    def bind(self, configurator: Configurator):
        configurator.add_static_view('static', 'static', cache_max_age=3600)
        configurator.add_view(
            self.notfound_view,
            renderer='tracim:templates/404.jinja2',
            context=NotFound,
        )

        configurator.add_route('test_config', '/')
        configurator.add_view(
            self.test_config,
            route_name='test_config',
            renderer='tracim:templates/mytemplate.jinja2',
        )

        configurator.add_route('test_admin', '/test_admin')
        configurator.add_view(
            self.test_admin_page,
            route_name='test_admin',
            renderer='tracim:templates/mytemplate.jinja2',
            permission='admin',
        )
        configurator.add_route('test_manager', '/test_manager')
        configurator.add_view(
            self.test_user_page,
            route_name='test_manager',
            renderer='tracim:templates/mytemplate.jinja2',
            permission='manager',
        )
        configurator.add_route('test_user', '/test_user')
        configurator.add_view(
            self.test_user_page,
            route_name='test_user',
            renderer='tracim:templates/mytemplate.jinja2',
            permission='user',
        )
        configurator.add_forbidden_view(self.forbidden_view)