tracim.views.default.default_controller.DefaultController.forbidden_view() - Code Metrics - Inspection of "add simple authorization auth" - tracim/tracim_backend - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5e9dbb...c55bf2 )

unknown

created 2018-04-06 10:19 UTC

DefaultController.forbidden_view() A

↳ Parent: tracim.views.default.default_controller

Complexity

Conditions

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
nop	2

# coding=utf-8
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from tracim.views.controllers import Controller
from pyramid.config import Configurator
from pyramid.response import Response
from pyramid.exceptions import NotFound
from pyramid.httpexceptions import HTTPUnauthorized
from pyramid.httpexceptions import HTTPForbidden
from pyramid.security import forget


class DefaultController(Controller):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    @classmethod
    def notfound_view(cls, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request.response.status = 404
        return {}

    @classmethod
    def forbidden_view(cls, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        if request.authenticated_userid is None:
            response = HTTPUnauthorized()
            response.headers.update(forget(request))

        # user is logged in but doesn't have permissions, reject wholesale
        else:
            response = HTTPForbidden()
        return response

    @classmethod
    def test_config(cls, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        try:
            app_config = request.registry.settings['CFG']
            project = app_config.WEBSITE_TITLE
        except Exception as e:

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}

    @classmethod
    def test_admin_page(cls, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        try:
            app_config = request.registry.settings['CFG']

            project = 'admin'
        except Exception as e:

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}

    @classmethod
    def test_manager_page(cls, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        try:
            app_config = request.registry.settings['CFG']

            project = 'manager'
        except Exception as e:

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}

    @classmethod
    def test_user_page(cls, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        try:
            app_config = request.registry.settings['CFG']

            project = 'user'
        except Exception as e:

            return Response(e, content_type='text/plain', status=500)
        return {'project': project}


    def bind(self, configurator: Configurator):
        configurator.add_static_view('static', 'static', cache_max_age=3600)
        configurator.add_view(
            self.notfound_view,
            renderer='tracim:templates/404.jinja2',
            context=NotFound,
        )

        configurator.add_route('test_config', '/')
        configurator.add_view(
            self.test_config,
            route_name='test_config',
            renderer='tracim:templates/mytemplate.jinja2',
        )

        configurator.add_route('test_admin', '/test_admin')
        configurator.add_view(
            self.test_admin_page,
            route_name='test_admin',
            renderer='tracim:templates/mytemplate.jinja2',
            permission='admin',
        )
        configurator.add_route('test_manager', '/test_manager')
        configurator.add_view(
            self.test_user_page,
            route_name='test_manager',
            renderer='tracim:templates/mytemplate.jinja2',
            permission='manager',
        )
        configurator.add_route('test_user', '/test_user')
        configurator.add_view(
            self.test_user_page,
            route_name='test_user',
            renderer='tracim:templates/mytemplate.jinja2',
            permission='user',
        )
        configurator.add_forbidden_view(self.forbidden_view)


1			# coding=utf-8
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from tracim.views.controllers import Controller
3			from pyramid.config import Configurator
4			from pyramid.response import Response
5			from pyramid.exceptions import NotFound
6			from pyramid.httpexceptions import HTTPUnauthorized
7			from pyramid.httpexceptions import HTTPForbidden
8			from pyramid.security import forget
9
10
11			class DefaultController(Controller):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
12
13			@classmethod
14			def notfound_view(cls, request):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
15			request.response.status = 404
16			return {}
17
18			@classmethod
19			def forbidden_view(cls, request):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
20			if request.authenticated_userid is None:
21			response = HTTPUnauthorized()
22			response.headers.update(forget(request))
23
24			# user is logged in but doesn't have permissions, reject wholesale
25			else:
26			response = HTTPForbidden()
27			return response
28
29			@classmethod
30			def test_config(cls, request):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
31			try:
32			app_config = request.registry.settings['CFG']
33			project = app_config.WEBSITE_TITLE
34			except Exception as e:
			0 ignored issues – show Best Practice introduced 2018-03-30 20:04 UTC by Report Bug Copy Issue Report Catching very general exceptions such as `Exception` is usually not recommended. Generally, you would want to handle very specific errors in the exception handler. This ensure that you do not hide other types of errors which should be fixed. So, unless you specifically plan to handle any error, consider adding a more specific exception. Loading history... Coding Style Naming introduced 2018-03-30 20:04 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
35			return Response(e, content_type='text/plain', status=500)
36			return {'project': project}
37
38			@classmethod
39			def test_admin_page(cls, request):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
40			try:
41			app_config = request.registry.settings['CFG']
			0 ignored issues – show Unused Code introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The variable `app_config` seems to be unused. Loading history...
42			project = 'admin'
43			except Exception as e:
			0 ignored issues – show Best Practice introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report Catching very general exceptions such as `Exception` is usually not recommended. Generally, you would want to handle very specific errors in the exception handler. This ensure that you do not hide other types of errors which should be fixed. So, unless you specifically plan to handle any error, consider adding a more specific exception. Loading history... Coding Style Naming introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
44			return Response(e, content_type='text/plain', status=500)
45			return {'project': project}
46
47			@classmethod
48			def test_manager_page(cls, request):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
49			try:
50			app_config = request.registry.settings['CFG']
			0 ignored issues – show Unused Code introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The variable `app_config` seems to be unused. Loading history...
51			project = 'manager'
52			except Exception as e:
			0 ignored issues – show Best Practice introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report Catching very general exceptions such as `Exception` is usually not recommended. Generally, you would want to handle very specific errors in the exception handler. This ensure that you do not hide other types of errors which should be fixed. So, unless you specifically plan to handle any error, consider adding a more specific exception. Loading history... Coding Style Naming introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
53			return Response(e, content_type='text/plain', status=500)
54			return {'project': project}
55
56			@classmethod
57			def test_user_page(cls, request):
			0 ignored issues – show Coding Style introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
58			try:
59			app_config = request.registry.settings['CFG']
			0 ignored issues – show Unused Code introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The variable `app_config` seems to be unused. Loading history...
60			project = 'user'
61			except Exception as e:
			0 ignored issues – show Best Practice introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report Catching very general exceptions such as `Exception` is usually not recommended. Generally, you would want to handle very specific errors in the exception handler. This ensure that you do not hide other types of errors which should be fixed. So, unless you specifically plan to handle any error, consider adding a more specific exception. Loading history... Coding Style Naming introduced 2018-04-06 10:21 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
62			return Response(e, content_type='text/plain', status=500)
63			return {'project': project}
64
65
66			def bind(self, configurator: Configurator):
67			configurator.add_static_view('static', 'static', cache_max_age=3600)
68			configurator.add_view(
69			self.notfound_view,
70			renderer='tracim:templates/404.jinja2',
71			context=NotFound,
72			)
73
74			configurator.add_route('test_config', '/')
75			configurator.add_view(
76			self.test_config,
77			route_name='test_config',
78			renderer='tracim:templates/mytemplate.jinja2',
79			)
80
81			configurator.add_route('test_admin', '/test_admin')
82			configurator.add_view(
83			self.test_admin_page,
84			route_name='test_admin',
85			renderer='tracim:templates/mytemplate.jinja2',
86			permission='admin',
87			)
88			configurator.add_route('test_manager', '/test_manager')
89			configurator.add_view(
90			self.test_user_page,
91			route_name='test_manager',
92			renderer='tracim:templates/mytemplate.jinja2',
93			permission='manager',
94			)
95			configurator.add_route('test_user', '/test_user')
96			configurator.add_view(
97			self.test_user_page,
98			route_name='test_user',
99			renderer='tracim:templates/mytemplate.jinja2',
100			permission='user',
101			)
102			configurator.add_forbidden_view(self.forbidden_view)
103

tracim / tracim_backend

Push — master ( 5e9dbb...c55bf2 )

DefaultController.forbidden_view() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like