tonicforhealth / json-rpc

src/ApiLayer/JsonRpcExtensions/Documentation/MetadataExtractor.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     /**
      * @param MethodCollection $methodCollection
      *
-     * @return array
+     * @return string
      */
     public function extract(MethodCollection $methodCollection)
     {

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 
 namespace Tonic\Component\ApiLayer\JsonRpcExtensions\Documentation;
 
-use Doctrine\Common\Annotations\PhpParser;
 use phpDocumentor\Reflection\DocBlock;
-use phpDocumentor\Reflection\DocBlock\Tag\ReturnTag;
 use Tonic\Component\ApiLayer\JsonRpc\Method\MethodCollection;
 use Tonic\Component\Reflection\TypeResolver;
 

src/Reflection/TypeResolver.php

Doc Comments +6 added lines

@@ -53,6 +53,9 @@ 
         return $type . ($isCollection ? '[]' : '');
     }
 
+    /**
+     * @param string $type
+     */
     private function isTypeObject($type)
     {
         switch (strtolower($type)) {
@@ -77,6 +80,9 @@ 
         }
     }
 
+    /**
+     * @param string $type
+     */
     private function resolveClassName($type, \ReflectionClass $usingClass)
     {
         if (strpos($type, '\\') === 0 && class_exists($type)) {

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $aliases = $this->phpParser->parseClass($usingClass);
         $alias = strtolower($type);
 
-        if (! isset($aliases[$alias])) {
+        if (!isset($aliases[$alias])) {
             return $usingClass->getNamespaceName() . '\\' . $type;
         }
 

src/ApiLayer/JsonRpcExtensions/Security/Method/SecurableMethodInvoker.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
         $attributeValue = $this->propertyAccessor->getValue($requestObject, $attributeAnnotation->valueAt);
 
         $userId = $this->userProvider->getUserId();
-        if ((! is_array($attributeValue)) && (! $this->guard->isGranted($userId, $attributeName, $attributeValue))) {
+        if ((!is_array($attributeValue)) && (!$this->guard->isGranted($userId, $attributeName, $attributeValue))) {
             throw new AccessDeniedException();
         }
 

src/ApiLayer/JsonRpc/Request/RequestParser.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
             throw new ParseException(sprintf('Invalid JSON syntax: "%s"', json_last_error_msg()));
         }
 
-        if (! is_array($data)) {
+        if (!is_array($data)) {
             throw new InvalidRequestException('Request is not valid JSON');
         }
 
@@ -39,7 +39,7 @@ 
             throw new InvalidRequestException(sprintf('Request attributes are missed: %s', join(', ', $difference)));
         }
 
-        if (! is_array($data['params'])) {
+        if (!is_array($data['params'])) {
             throw new InvalidRequestException('Parameters should have an object structure');
         }
     }

src/ApiLayer/JsonRpc/Method/Loader/MutableAnnotationLoader.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      */
     public function add($service)
     {
-        if (! is_object($service)) {
+        if (!is_object($service)) {
             throw new \InvalidArgumentException('Supports only objects');
         }
 

src/ApiLayer/JsonRpc/Method/MethodCollection.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
      */
     public function get($methodName)
     {
-        if (! $this->has($methodName)) {
+        if (!$this->has($methodName)) {
             return null;
         }
 

src/ApiLayer/JsonRpc/Method/MethodDispatcher.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
     public function dispatch($methodName, array $arguments = [])
     {
         $methodCollection = $this->getMethodCollection();
-        if (! $methodCollection->has($methodName)) {
+        if (!$methodCollection->has($methodName)) {
             throw new MethodNotFoundException(sprintf('Method "%s" is not found', $methodName));
         }
 

src/ApiLayer/JsonRpc/Method/ArgumentMapper/Normalizer/Normalizer.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
         $docBlock = new DocBlock($reflectionProperty->getDocComment());
         $tags = $docBlock->getTagsByName('var');
-        if (count($tags) == 0 ) {
+        if (count($tags) == 0) {
             return null;
         }
 

spec/ApiLayer/JsonRpc/Method/MethodCollectionSpec.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     {
         $this->has('sampleService.sampleMethod')->shouldBe(false);
 
-        $this->add('sampleService.sampleMethod', function () {});
+        $this->add('sampleService.sampleMethod', function() {});
 
         $this->get('sampleService.sampleMethod')->shouldBeAnInstanceOf(\Closure::class);
     }