tonicforhealth / health-checker-incident

src/IncidentBundle/Controller/IncidentController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use IncidentBundle\Entity\Incident;
 use JMS\Serializer\Serializer;
-use JMS\SerializerBundle\DependencyInjection\JMSSerializerExtension;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
      */
     protected function getErrorHandlerCallback(&$errors)
     {
-        return function ($errno, $errstr, $errfile, $errline) use (&$errors) {
+        return function($errno, $errstr, $errfile, $errline) use (&$errors) {
             $errors[] = ['code' => $errno, 'text' => $errstr];
         };
     }

src/IncidentBundle/Controller/IncidentHookController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace IncidentBundle\Controller;
 
 use IncidentBundle\Entity\Incident;
-use JMS\Serializer\Serializer;
-use JMS\SerializerBundle\DependencyInjection\JMSSerializerExtension;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
         $entityManager->persist($incident);
 
 
-        $responseData['status'] = empty($errors)?'ok':'error';
+        $responseData['status'] = empty($errors) ? 'ok' : 'error';
 
         return new Response(json_encode($responseData));
     }

src/TonicHealthCheck/Incident/Siren/IncidentSiren.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     /**
      * IncidentSiren constructor.
      * @param NotificationTypeInterface $notificationTypeInstance
-     * @param null|array                $subjects
+     * @param null|SubjectCollection                $subjects
      * @throws IncidentSirenException
      */
     public function __construct(NotificationTypeInterface $notificationTypeInstance, SubjectCollection $subjects = null)

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
      */
     public function notify(IncidentInterface $incident, $subjects = null)
     {
-        $subjects = null === $subjects? $this->getSubjects(): $subjects;
+        $subjects = null === $subjects ? $this->getSubjects() : $subjects;
         /** @var SubjectInterface $subject */
         foreach ($subjects as $subject) {
             try {

src/TonicHealthCheck/Incident/Siren/NotificationType/RequestNotificationType.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace TonicHealthCheck\Incident\Siren\NotificationType;
 
 use Http\Client\Common\HttpMethodsClient;
-use Http\Discovery\StreamFactoryDiscovery;
-use Psr\Http\Message\RequestInterface;
 use TonicHealthCheck\Incident\IncidentInterface;
 use TonicHealthCheck\Incident\Siren\Subject\SubjectInterface;
 

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     {
         $serverUrl = $subject;
         if ($incident->getStatus() != IncidentInterface::STATUS_OK) {
-            $response  = $this->getHttpClient()->post(
+            $response = $this->getHttpClient()->post(
                 $subject.$this->getResourceUrl(),
                 ['Content-type' => 'application/json'],
                 json_encode(

src/TonicHealthCheck/Incident/IncidentEventSubscriber.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  */
 class IncidentEventSubscriber implements EventSubscriber
 {
-    protected static $typeEventPolitic =[
+    protected static $typeEventPolitic = [
         Incident::TYPE_URGENT => [
             EmailNotificationType::class,
             FileNotificationType::class,

web/app_dev.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 // Feel free to remove this, extend it, or make something more sophisticated.
 if (isset($_SERVER['HTTP_CLIENT_IP'])
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
-    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1','192.168.99.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', '192.168.99.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
 ) {
     header('HTTP/1.0 403 Forbidden');
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');

web/config.php

Braces +9 added lines, -3 removed lines

@@ -167,7 +167,10 @@ 
                         <?php if (count($minorProblems)): ?>
                             <h2>Recommendations</h2>
                             <p>
-                                <?php if (count($majorProblems)): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your Symfony experience,
+                                <?php if (count($majorProblems)): ?>Additionally, to<?php else {
+    : ?>To<?php endif;
+}
+?> enhance your Symfony experience,
                                 it’s recommended that you fix the following:
                             </p>
                             <ol>
@@ -181,9 +184,12 @@ 
                             <p id="phpini">*
                                 <?php if ($symfonyRequirements->getPhpIniConfigPath()): ?>
                                     Changes to the <strong>php.ini</strong> file must be done in "<strong><?php echo $symfonyRequirements->getPhpIniConfigPath() ?></strong>".
-                                <?php else: ?>
+                                <?php else {
+    : ?>
                                     To change settings, create a "<strong>php.ini</strong>".
-                                <?php endif; ?>
+                                <?php endif;
+}
+?>
                             </p>
                         <?php endif; ?>