tomeightyeight / general-election-polling

application/bootstrap.php

Unused Use Statements -2 removed lines

@@ -6,10 +6,8 @@
 require_once __DIR__ . '/../vendor/autoload.php';
 	
 use Silex\Application;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Silex\Provider\UrlGeneratorServiceProvider;
-use Silex\Provider\SessionServiceProvider;
 use Silex\Provider\ServiceControllerServiceProvider;
 use Silex\Provider\MonologServiceProvider;
 	

Indentation +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
 
 // Register Monolog service provider for local logging
 $app->register(new MonologServiceProvider(), array(
-    'monolog.logfile' => __DIR__.LOG_PATH,
+	'monolog.logfile' => __DIR__.LOG_PATH,
 	'monolog.name' => APP_NAME,
 	'monolog.level' => LOG_LEVEL
 ));
@@ -65,5 +65,5 @@ 
 
 // Load routes
 foreach(glob(__DIR__ . "/src/Kineo/Route/*.php") as $filename) {
-    require_once $filename;
+	require_once $filename;
 }

Braces +3 added lines, -1 removed lines

@@ -48,7 +48,9 @@
 
 // Error handler
 $app->error(function(\Exception $e, $code) use ($app) {
-	if($app['debug']) return;
+	if($app['debug']) {
+		return;
+	}
 
 	switch($code) {
 		case 404:

Spacing +6 added lines, -6 removed lines

@@ -1,9 +1,9 @@ 
 <?php
 // Require config loader
-require_once __DIR__ . '/config-loader.php';
+require_once __DIR__.'/config-loader.php';
 
 // Composer autoloader
-require_once __DIR__ . '/../vendor/autoload.php';
+require_once __DIR__.'/../vendor/autoload.php';
 	
 use Silex\Application;
 use Symfony\Component\HttpFoundation\Request;
@@ -27,7 +27,7 @@ 
 // Set character encoding
 $app['charset'] = 'UTF-8';
 
-if(DEBUG) {
+if (DEBUG) {
 	error_reporting(E_ALL);
 	ini_set('display_errors', 1);
 	$app['debug'] = true;
@@ -48,9 +48,9 @@ 
 
 // Error handler
 $app->error(function(\Exception $e, $code) use ($app) {
-	if($app['debug']) return;
+	if ($app['debug']) return;
 
-	switch($code) {
+	switch ($code) {
 		case 404:
 			return $app->redirect('/');
 			break;
@@ -64,6 +64,6 @@ 
 });
 
 // Load routes
-foreach(glob(__DIR__ . "/src/Kineo/Route/*.php") as $filename) {
+foreach (glob(__DIR__."/src/Kineo/Route/*.php") as $filename) {
     require_once $filename;
 }

application/src/Kineo/Route/vote.php

Unused Use Statements -1 removed lines

@@ -1,5 +1,4 @@
 <?php	
-use Silex\Application;
 use Kineo\Controller\VoteController;
 
 $app['vote.controller'] = $app->share(function() use ($app) {

application/tests/WebTestCase.php

Indentation +5 added lines, -5 removed lines

@@ -5,10 +5,10 @@
 
 class WebTestCase extends BaseWebTestCase
 {
-    public function createApplication()
-    {
-        $app = require $_SERVER['APP_DIR'] . '/src/app.php';
+	public function createApplication()
+	{
+		$app = require $_SERVER['APP_DIR'] . '/src/app.php';
 
-        return $app;
-    }
+		return $app;
+	}
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 {
     public function createApplication()
     {
-        $app = require $_SERVER['APP_DIR'] . '/src/app.php';
+        $app = require $_SERVER['APP_DIR'].'/src/app.php';
 
         return $app;
     }

application/tests/Kineo/Component/DatabaseTest.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 	{
 		$bindArray = array('param' => 4);
 		
-		Database::bindParamArray('test', array(4,6,8), $bindArray);
+		Database::bindParamArray('test', array(4, 6, 8), $bindArray);
 		
 		$expected = array(
 			'param' => 4,

application/src/Kineo/Controller/DataController.php

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
 	{		
 		$constituenciesModel = new ConstituenciesModel(new Database());
 		
-		if($constituenciesModel->getAllConstituencies()) {
+		if ($constituenciesModel->getAllConstituencies()) {
 			return json_encode($constituenciesModel->constituencies);
 		} else {
 			return ApiResponse::error('NO_CONSTITUENCIES_FOUND');	
@@ -33,7 +33,7 @@ 
 	{
 		$candidatesModel = new CandidatesModel(new Database());
 		
-		if($candidatesModel->getCandidatesByConstituencyId($constituencyId)) {
+		if ($candidatesModel->getCandidatesByConstituencyId($constituencyId)) {
 			return json_encode($candidatesModel->candidates);
 		} else {
 			return ApiResponse::error('NO_CANDIDATES_FOUND');	

application/src/Kineo/Controller/VoteController.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
 		
 		$userModel = new UserModel(new Database());
 		
-		if($userModel->loadUserByEmail($userData->email)) {
+		if ($userModel->loadUserByEmail($userData->email)) {
 			return ApiResponse::error('USER_EXISTS');
 		}
 		
@@ -31,7 +31,7 @@ 
 			$userModel->saveUser($userData->email, $userData->first_name, $userData->surname, $userData->constituency, $userData->voting, $userData->candidate);
 			
 			return ApiResponse::success('DEFAULT_RESPONSE_SUCCESS');
-		} catch(\Exception $e) {
+		} catch (\Exception $e) {
 			return ApiResponse::error('USER_SAVE_FAIL');
 		}		
 	}

application/src/Kineo/Controller/ResultsController.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 	{		
 		$resultsModel = new ResultsModel(new Database());
 		
-		if($resultsModel->getResults()) {
+		if ($resultsModel->getResults()) {
 			return json_encode($resultsModel->results);
 		} else {
 			return json_encode(array());

application/src/Kineo/Model/BaseModel.php

Spacing +3 added lines, -3 removed lines

@@ -10,14 +10,14 @@
 {
 	public function hydrateObjects($collectionPropertyName, $modelType, $records)
 	{
-		if(empty($records)) {
+		if (empty($records)) {
 			throw new \Exception('No records found');
 		} else {
-			foreach($records as $item) {
+			foreach ($records as $item) {
 				// Requires a fully qualified namespace
 				$doc = new $modelType($this->app);
 				
-				foreach($item as $key => $val) {
+				foreach ($item as $key => $val) {
 					$doc->{$key} = $val;
 				}
 				

application/src/Kineo/Model/ConstituenciesModel.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 		
 		$result = $stmt->fetchAll(\PDO::FETCH_ASSOC);
 		
-		if(is_array($result) && !empty($result)) {
+		if (is_array($result) && !empty($result)) {
 			$this->constituencies = $result;
 			
 			return $this->constituencies;