Inspection of "[TASK] Implemented EXT:static_info_tables + code-f..." - tomasnorre/golf_courses - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6fcebc...8d56df )

by Tomas Norre

created 2016-08-06 18:22 UTC

Status

Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

@@ -18,19 +18,19 @@  discard block
 block discarded – undo
 			'disabled' => 'hidden',
 			'starttime' => 'starttime',
 			'endtime' => 'endtime',
-        ],
+		],
 		'searchFields' => 'name,website,comment,country,logo,',
 		'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extRelPath('golf_courses') . 'Resources/Public/Icons/tx_golfcourses_domain_model_golfcourse.png'
-    ],
+	],
 	'interface' => [
 		'showRecordFieldList' => 'sys_language_uid, l10n_parent, l10n_diffsource, hidden, name, website, comment, country, logo',
-    ],
+	],
 	'types' => [
 		'1' => ['showitem' => 'sys_language_uid;;;;1-1-1, l10n_parent, l10n_diffsource, hidden;;1, name, website, comment, country, logo, --div--;LLL:EXT:cms/locallang_ttc.xlf:tabs.access, starttime, endtime'],
-    ],
+	],
 	'palettes' => [
 		'1' => ['showitem' => ''],
-    ],
+	],
 	'columns' => [
 	
 		'sys_language_uid' => [
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
 				'items' => [
 					['LLL:EXT:lang/locallang_general.xlf:LGL.allLanguages', -1],
 					['LLL:EXT:lang/locallang_general.xlf:LGL.default_value', 0]
-                ],
-            ],
-        ],
+				],
+			],
+		],
 		'l10n_parent' => [
 			'displayCond' => 'FIELD:sys_language_uid:>:0',
 			'exclude' => 1,
@@ -56,31 +56,31 @@  discard block
 block discarded – undo
 				'renderType' => 'selectSingle',
 				'items' => [
 					['', 0],
-                ],
+				],
 				'foreign_table' => 'tx_golfcourses_domain_model_golfcourse',
 				'foreign_table_where' => 'AND tx_golfcourses_domain_model_golfcourse.pid=###CURRENT_PID### AND tx_golfcourses_domain_model_golfcourse.sys_language_uid IN (-1,0)',
-            ],
-        ],
+			],
+		],
 		'l10n_diffsource' => [
 			'config' => [
 				'type' => 'passthrough',
-            ],
-        ],
+			],
+		],
 		't3ver_label' => [
 			'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.versionLabel',
 			'config' => [
 				'type' => 'input',
 				'size' => 30,
 				'max' => 255,
-            ]
-        ],
+			]
+		],
 		'hidden' => [
 			'exclude' => 1,
 			'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
 			'config' => [
 				'type' => 'check',
-            ],
-        ],
+			],
+		],
 		'starttime' => [
 			'exclude' => 1,
 			'l10n_mode' => 'mergeIfNotBlank',
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
 				'default' => 0,
 				'range' => [
 					'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y'))
-                ],
-            ],
-        ],
+				],
+			],
+		],
 		'endtime' => [
 			'exclude' => 1,
 			'l10n_mode' => 'mergeIfNotBlank',
@@ -110,9 +110,9 @@  discard block
 block discarded – undo
 				'default' => 0,
 				'range' => [
 					'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y'))
-                ],
-            ],
-        ],
+				],
+			],
+		],
 		'name' => [
 			'exclude' => 1,
 			'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.name',
@@ -120,8 +120,8 @@  discard block
 block discarded – undo
 				'type' => 'input',
 				'size' => 30,
 				'eval' => 'trim'
-            ],
-        ],
+			],
+		],
 		'website' => [
 			'exclude' => 1,
 			'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.website',
@@ -129,8 +129,8 @@  discard block
 block discarded – undo
 				'type' => 'input',
 				'size' => 30,
 				'eval' => 'trim'
-            ],
-        ],
+			],
+		],
 		'comment' => [
 			'exclude' => 1,
 			'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.comment',
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
 				'type' => 'input',
 				'size' => 30,
 				'eval' => 'trim'
-            ],
-        ],
+			],
+		],
 		'country' => [
 			'exclude' => 1,
 			'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.country',
@@ -148,14 +148,14 @@  discard block
 block discarded – undo
 				'renderType' => 'selectSingle',
 				'items' => [
 					['Select Country', -1],
-                ],
+				],
 				'foreign_table' => 'static_countries',
 				'foreign_table_where' => 'ORDER BY cn_official_name_en ASC',
 				'size' => 1,
 				'maxitems' => 1,
 				'eval' => ''
-            ],
-        ],
+			],
+		],
 		'logo' => [
 			'exclude' => 1,
 			'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.logo',
@@ -164,44 +164,44 @@  discard block
 block discarded – undo
 				[
 					'appearance' => [
 						'createNewRelationLinkTitle' => 'LLL:EXT:cms/locallang_ttc.xlf:images.addFileReference'
-                    ],
+					],
 					'foreign_types' => [
 						'0' => [
 							'showitem' => '
 							--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
 							--palette--;;filePalette'
-                        ],
+						],
 						\TYPO3\CMS\Core\Resource\File::FILETYPE_TEXT => [
 							'showitem' => '
 							--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
 							--palette--;;filePalette'
-                        ],
+						],
 						\TYPO3\CMS\Core\Resource\File::FILETYPE_IMAGE => [
 							'showitem' => '
 							--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
 							--palette--;;filePalette'
-                        ],
+						],
 						\TYPO3\CMS\Core\Resource\File::FILETYPE_AUDIO => [
 							'showitem' => '
 							--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
 							--palette--;;filePalette'
-                        ],
+						],
 						\TYPO3\CMS\Core\Resource\File::FILETYPE_VIDEO => [
 							'showitem' => '
 							--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
 							--palette--;;filePalette'
-                        ],
+						],
 						\TYPO3\CMS\Core\Resource\File::FILETYPE_APPLICATION => [
 							'showitem' => '
 							--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
 							--palette--;;filePalette'
-                        ]
-                    ],
+						]
+					],
 					'maxitems' => 1
-                ],
+				],
 				$GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
 			),
-        ],
+		],
 
-    ],
+	],
 ];
\ No newline at end of file

Please login to merge, or discard this patch.

Classes/Domain/Repository/GolfCourseRepository.php 1 patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -35,19 +35,19 @@
 block discarded – undo
 class GolfCourseRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
 {
 
-    /**
-     * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
-     */
-    public function findAll()
-    {
-        /** @var QueryInterface $query */
-        $query = $this->createQuery();
-        $querySettings = $query->getQuerySettings();
-        $querySettings->setRespectStoragePage(false);
-        $querySettings->setIgnoreEnableFields(true);
-        $query->setOrderings(['name' => 'ASC']);
-        $query->setQuerySettings($querySettings);
-        return $query->execute();
-    }
+	/**
+	 * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
+	 */
+	public function findAll()
+	{
+		/** @var QueryInterface $query */
+		$query = $this->createQuery();
+		$querySettings = $query->getQuerySettings();
+		$querySettings->setRespectStoragePage(false);
+		$querySettings->setIgnoreEnableFields(true);
+		$query->setOrderings(['name' => 'ASC']);
+		$query->setQuerySettings($querySettings);
+		return $query->execute();
+	}
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -18,19 +18,19 @@ discard block
		block discarded – undo
18	18	'disabled' => 'hidden',
19	19	'starttime' => 'starttime',
20	20	'endtime' => 'endtime',
21		- ],
	21	+ ],
22	22	'searchFields' => 'name,website,comment,country,logo,',
23	23	'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extRelPath('golf_courses') . 'Resources/Public/Icons/tx_golfcourses_domain_model_golfcourse.png'
24		- ],
	24	+ ],
25	25	'interface' => [
26	26	'showRecordFieldList' => 'sys_language_uid, l10n_parent, l10n_diffsource, hidden, name, website, comment, country, logo',
27		- ],
	27	+ ],
28	28	'types' => [
29	29	'1' => ['showitem' => 'sys_language_uid;;;;1-1-1, l10n_parent, l10n_diffsource, hidden;;1, name, website, comment, country, logo, --div--;LLL:EXT:cms/locallang_ttc.xlf:tabs.access, starttime, endtime'],
30		- ],
	30	+ ],
31	31	'palettes' => [
32	32	'1' => ['showitem' => ''],
33		- ],
	33	+ ],
34	34	'columns' => [
35	35
36	36	'sys_language_uid' => [
		@@ -44,9 +44,9 @@ discard block
		block discarded – undo
44	44	'items' => [
45	45	['LLL:EXT:lang/locallang_general.xlf:LGL.allLanguages', -1],
46	46	['LLL:EXT:lang/locallang_general.xlf:LGL.default_value', 0]
47		- ],
48		- ],
49		- ],
	47	+ ],
	48	+ ],
	49	+ ],
50	50	'l10n_parent' => [
51	51	'displayCond' => 'FIELD:sys_language_uid:>:0',
52	52	'exclude' => 1,
		@@ -56,31 +56,31 @@ discard block
		block discarded – undo
56	56	'renderType' => 'selectSingle',
57	57	'items' => [
58	58	['', 0],
59		- ],
	59	+ ],
60	60	'foreign_table' => 'tx_golfcourses_domain_model_golfcourse',
61	61	'foreign_table_where' => 'AND tx_golfcourses_domain_model_golfcourse.pid=###CURRENT_PID### AND tx_golfcourses_domain_model_golfcourse.sys_language_uid IN (-1,0)',
62		- ],
63		- ],
	62	+ ],
	63	+ ],
64	64	'l10n_diffsource' => [
65	65	'config' => [
66	66	'type' => 'passthrough',
67		- ],
68		- ],
	67	+ ],
	68	+ ],
69	69	't3ver_label' => [
70	70	'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.versionLabel',
71	71	'config' => [
72	72	'type' => 'input',
73	73	'size' => 30,
74	74	'max' => 255,
75		- ]
76		- ],
	75	+ ]
	76	+ ],
77	77	'hidden' => [
78	78	'exclude' => 1,
79	79	'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
80	80	'config' => [
81	81	'type' => 'check',
82		- ],
83		- ],
	82	+ ],
	83	+ ],
84	84	'starttime' => [
85	85	'exclude' => 1,
86	86	'l10n_mode' => 'mergeIfNotBlank',
		@@ -94,9 +94,9 @@ discard block
		block discarded – undo
94	94	'default' => 0,
95	95	'range' => [
96	96	'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y'))
97		- ],
98		- ],
99		- ],
	97	+ ],
	98	+ ],
	99	+ ],
100	100	'endtime' => [
101	101	'exclude' => 1,
102	102	'l10n_mode' => 'mergeIfNotBlank',
		@@ -110,9 +110,9 @@ discard block
		block discarded – undo
110	110	'default' => 0,
111	111	'range' => [
112	112	'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y'))
113		- ],
114		- ],
115		- ],
	113	+ ],
	114	+ ],
	115	+ ],
116	116	'name' => [
117	117	'exclude' => 1,
118	118	'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.name',
		@@ -120,8 +120,8 @@ discard block
		block discarded – undo
120	120	'type' => 'input',
121	121	'size' => 30,
122	122	'eval' => 'trim'
123		- ],
124		- ],
	123	+ ],
	124	+ ],
125	125	'website' => [
126	126	'exclude' => 1,
127	127	'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.website',
		@@ -129,8 +129,8 @@ discard block
		block discarded – undo
129	129	'type' => 'input',
130	130	'size' => 30,
131	131	'eval' => 'trim'
132		- ],
133		- ],
	132	+ ],
	133	+ ],
134	134	'comment' => [
135	135	'exclude' => 1,
136	136	'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.comment',
		@@ -138,8 +138,8 @@ discard block
		block discarded – undo
138	138	'type' => 'input',
139	139	'size' => 30,
140	140	'eval' => 'trim'
141		- ],
142		- ],
	141	+ ],
	142	+ ],
143	143	'country' => [
144	144	'exclude' => 1,
145	145	'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.country',
		@@ -148,14 +148,14 @@ discard block
		block discarded – undo
148	148	'renderType' => 'selectSingle',
149	149	'items' => [
150	150	['Select Country', -1],
151		- ],
	151	+ ],
152	152	'foreign_table' => 'static_countries',
153	153	'foreign_table_where' => 'ORDER BY cn_official_name_en ASC',
154	154	'size' => 1,
155	155	'maxitems' => 1,
156	156	'eval' => ''
157		- ],
158		- ],
	157	+ ],
	158	+ ],
159	159	'logo' => [
160	160	'exclude' => 1,
161	161	'label' => 'LLL:EXT:golf_courses/Resources/Private/Language/locallang_db.xlf:tx_golfcourses_domain_model_golfcourse.logo',
		@@ -164,44 +164,44 @@ discard block
		block discarded – undo
164	164	[
165	165	'appearance' => [
166	166	'createNewRelationLinkTitle' => 'LLL:EXT:cms/locallang_ttc.xlf:images.addFileReference'
167		- ],
	167	+ ],
168	168	'foreign_types' => [
169	169	'0' => [
170	170	'showitem' => '
171	171	--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
172	172	--palette--;;filePalette'
173		- ],
	173	+ ],
174	174	\TYPO3\CMS\Core\Resource\File::FILETYPE_TEXT => [
175	175	'showitem' => '
176	176	--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
177	177	--palette--;;filePalette'
178		- ],
	178	+ ],
179	179	\TYPO3\CMS\Core\Resource\File::FILETYPE_IMAGE => [
180	180	'showitem' => '
181	181	--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
182	182	--palette--;;filePalette'
183		- ],
	183	+ ],
184	184	\TYPO3\CMS\Core\Resource\File::FILETYPE_AUDIO => [
185	185	'showitem' => '
186	186	--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
187	187	--palette--;;filePalette'
188		- ],
	188	+ ],
189	189	\TYPO3\CMS\Core\Resource\File::FILETYPE_VIDEO => [
190	190	'showitem' => '
191	191	--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
192	192	--palette--;;filePalette'
193		- ],
	193	+ ],
194	194	\TYPO3\CMS\Core\Resource\File::FILETYPE_APPLICATION => [
195	195	'showitem' => '
196	196	--palette--;LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.imageoverlayPalette;imageoverlayPalette,
197	197	--palette--;;filePalette'
198		- ]
199		- ],
	198	+ ]
	199	+ ],
200	200	'maxitems' => 1
201		- ],
	201	+ ],
202	202	$GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
203	203	),
204		- ],
	204	+ ],
205	205
206		- ],
	206	+ ],
207	207	];
208	208	\ No newline at end of file

		@@ -35,19 +35,19 @@
		block discarded – undo
35	35	class GolfCourseRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
36	36	{
37	37
38		- /**
39		- * @return array\|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
40		- */
41		- public function findAll()
42		- {
43		- /** @var QueryInterface $query */
44		- $query = $this->createQuery();
45		- $querySettings = $query->getQuerySettings();
46		- $querySettings->setRespectStoragePage(false);
47		- $querySettings->setIgnoreEnableFields(true);
48		- $query->setOrderings(['name' => 'ASC']);
49		- $query->setQuerySettings($querySettings);
50		- return $query->execute();
51		- }
	38	+ /**
	39	+ * @return array\|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
	40	+ */
	41	+ public function findAll()
	42	+ {
	43	+ /** @var QueryInterface $query */
	44	+ $query = $this->createQuery();
	45	+ $querySettings = $query->getQuerySettings();
	46	+ $querySettings->setRespectStoragePage(false);
	47	+ $querySettings->setIgnoreEnableFields(true);
	48	+ $query->setOrderings(['name' => 'ASC']);
	49	+ $query->setQuerySettings($querySettings);
	50	+ return $query->execute();
	51	+ }
52	52
53	53	}
54	54	\ No newline at end of file

tomasnorre / golf_courses

Push — master ( 6fcebc...8d56df )

Status

Category

Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch