Thinktomorrow\Locale\Detectors\HiddenSegmentDetector

Complexity

Total Complexity

4

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	0	10	2
A	segment()	0	6	1

<?php

namespace Thinktomorrow\Locale\Detectors;

use Illuminate\Http\Request;
use Thinktomorrow\Locale\Values\Locale;
use Thinktomorrow\Locale\Values\Config;
use Thinktomorrow\Locale\Scope;

class HiddenSegmentDetector implements Detector
{
    /**
     * @var Request
     */
    private $request;

    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }

    public function get(Scope $scope, Config $config): ?Locale
    {
        // If a locale segment is found, it means locale is not hidden so we won't bother going further.
        if ($this->segment($scope)) return null;

        // At this point if no locale segment is given and if in config the hidden_locale is set,
        // we assume the locale is hidden.
        // TODO account for domain specific hidden (default) locales
        return $scope->defaultLocale();
    }

    public function segment(Scope $scope): ?Locale
    {
        $segment = $this->request->segment(1);

        return $scope->findLocale($segment);
    }
}