HiddenSegmentDetector::get() - Code Metrics - Inspection of "changed scrutinizer code coverage check" - thinktomorrow/locale - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — 2.0 (72e182)

by Philippe

created 2018-02-12 08:21 UTC

HiddenSegmentDetector::get() A

↳ Parent: HiddenSegmentDetector

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	2
dl	0
loc	10
ccs	3
cts	3
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace Thinktomorrow\Locale\Detectors;

use Illuminate\Http\Request;
use Thinktomorrow\Locale\Values\Locale;
use Thinktomorrow\Locale\Values\Config;
use Thinktomorrow\Locale\Scope;

class HiddenSegmentDetector implements Detector
{
    /**
     * @var Request
     */
    private $request;

    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    public function get(Scope $scope, Config $config): ?Locale
    {
        // If a locale segment is found, it means locale is not hidden so we won't bother going further.
        if ($this->segment($scope)) return null;

        // At this point if no locale segment is given and if in config the hidden_locale is set,
        // we assume the locale is hidden.
        // TODO account for domain specific hidden (default) locales
        return $scope->defaultLocale();
    }

    public function segment(Scope $scope): ?Locale
    {
        $segment = $this->request->segment(1);

        return $scope->findLocale($segment);
    }
}

1		<?php
2
3		namespace Thinktomorrow\Locale\Detectors;
4
5		use Illuminate\Http\Request;
6		use Thinktomorrow\Locale\Values\Locale;
7		use Thinktomorrow\Locale\Values\Config;
8		use Thinktomorrow\Locale\Scope;
9
10		class HiddenSegmentDetector implements Detector
11		{
12		/**
13		* @var Request
14		*/
15		private $request;
16
17	28	public function __construct(Request $request)
		0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
18		{
19	28	$this->request = $request;
20	28	}
21
22	28	public function get(Scope $scope, Config $config): ?Locale
23		{
24		// If a locale segment is found, it means locale is not hidden so we won't bother going further.
25	28	if ($this->segment($scope)) return null;
26
27		// At this point if no locale segment is given and if in config the hidden_locale is set,
28		// we assume the locale is hidden.
29		// TODO account for domain specific hidden (default) locales
30	13	return $scope->defaultLocale();
31		}
32
33	28	public function segment(Scope $scope): ?Locale
34		{
35	28	$segment = $this->request->segment(1);
36
37	28	return $scope->findLocale($segment);
38		}
39		}

thinktomorrow / locale

Branch — 2.0 (72e182)

HiddenSegmentDetector::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like