Completed
Pull Request — master (#317)
by Ben
44:03 queued 04:31
created
src/Urls/Application/SaveUrlSlugs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     private function saveRecord(string $locale, ?string $slug)
58 58
     {
59 59
         // Existing ones for this locale?
60
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
60
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
61 61
             return (
62 62
                 $record->locale == $locale &&
63 63
                 !$record->isRedirect()
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         // If slug entry is left empty, all existing records will be deleted
68 68
         if (!$slug) {
69
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
69
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
70 70
                 $existingRecord->delete();
71 71
             });
72 72
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         }
83 83
 
84 84
         // Only replace the existing records that differ from the current passed slugs
85
-        $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
85
+        $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
86 86
             if ($existingRecord->slug != $slug) {
87 87
                 $existingRecord->replaceAndRedirect(['slug' => $slug]);
88 88
             }
@@ -127,12 +127,12 @@  discard block
 block discarded – undo
127 127
      */
128 128
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
129 129
     {
130
-        $existingRecords->filter(function ($record) use ($locale) {
130
+        $existingRecords->filter(function($record) use ($locale) {
131 131
             return (
132 132
                 $record->locale == $locale &&
133 133
                 $record->isRedirect()
134 134
             );
135
-        })->each(function ($existingRecord) use ($slug) {
135
+        })->each(function($existingRecord) use ($slug) {
136 136
             if ($existingRecord->slug == $slug) {
137 137
                 $existingRecord->delete();
138 138
             }
@@ -147,11 +147,11 @@  discard block
 block discarded – undo
147 147
 
148 148
         // The old homepage url should be removed since this is no longer in effect.
149 149
         // In case of any redirect to this old homepage, the last used redirect is now back in effect.
150
-        $existingRecords->reject(function ($existingRecord) {
150
+        $existingRecords->reject(function($existingRecord) {
151 151
             return (
152 152
                 $existingRecord->model_type == $this->model->getMorphClass() &&
153 153
                 $existingRecord->model_id == $this->model->id);
154
-        })->each(function ($existingRecord) {
154
+        })->each(function($existingRecord) {
155 155
 
156 156
             // TODO: if there is a redirect to this page, we'll take this one as the new url
157 157
             $existingRecord->delete();
Please login to merge, or discard this patch.
src/Urls/ProvidesUrl/BaseUrlSegment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
      */
15 15
     public static function prepend(ProvidesUrl $model, string $slug, $locale): string
16 16
     {
17
-        $slugWithBaseSegment = $model->baseUrlSegment($locale) . '/' . $slug;
17
+        $slugWithBaseSegment = $model->baseUrlSegment($locale).'/'.$slug;
18 18
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
19 19
 
20 20
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.
src/Management/Assistants/UrlAssistant.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
 
26 26
     public function manager(Manager $manager)
27 27
     {
28
-        $this->manager  = $manager;
28
+        $this->manager = $manager;
29 29
 
30
-        if (! $manager->model() instanceof ProvidesUrl) {
31
-            throw new \Exception('UrlAssistant requires the model interfaced by ' . ProvidesUrl::class . '.');
30
+        if (!$manager->model() instanceof ProvidesUrl) {
31
+            throw new \Exception('UrlAssistant requires the model interfaced by '.ProvidesUrl::class.'.');
32 32
         }
33 33
 
34 34
         $this->model = $manager->model();
@@ -56,14 +56,14 @@  discard block
 block discarded – undo
56 56
             InputField::make('url-slugs')
57 57
                 ->validation(
58 58
                     [
59
-                        'url-slugs' => ['array', 'min:1', new UniqueUrlSlugRule($this->model, ($this->model->exists) ? $this->model : null),],
59
+                        'url-slugs' => ['array', 'min:1', new UniqueUrlSlugRule($this->model, ($this->model->exists) ? $this->model : null), ],
60 60
                     ],
61 61
                     [],
62 62
                     [
63 63
                         'url-slugs.*' => 'taalspecifieke link',
64 64
                     ])
65 65
                 ->view('chief::back._fields.url-slugs')
66
-                ->viewData(['fields' => UrlSlugFields::fromModel($this->model) ]),
66
+                ->viewData(['fields' => UrlSlugFields::fromModel($this->model)]),
67 67
         ]);
68 68
     }
69 69
 
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 
74 74
         // Push update to homepage setting value
75 75
         // TODO: we should just fetch the homepages and push that instead...
76
-        UrlRecord::getByModel($this->model)->reject(function ($record) {
76
+        UrlRecord::getByModel($this->model)->reject(function($record) {
77 77
             return ($record->isRedirect() || !$record->isHomepage());
78
-        })->each(function ($record) {
78
+        })->each(function($record) {
79 79
             app(ChangeHomepage::class)->onUrlChanged($record);
80 80
         });
81 81
     }
Please login to merge, or discard this patch.