View GitHub Repository chief

Schedule Inspection
Subscribe
Completed
Pull Request — master (#396)
by Ben
69:51
created

3,343 +157 Covered Lines

4,174 +135 Total Lines

80.1 % +1.2% Code Coverage

PHP Classes Changes

 
 ⇢
0%
CheckPreviewTrait added
 
 ⇢
12.5%
NullValidator added
 
 ⇢
70.83%
DeleteManagedModel added
 
 ⇢
71.43%
Publishable added
 
 ⇢
80%
StateException added
 
 ⇢
87.5%
FieldValidatorFactory added
 
 ⇢
92.86%
StateMachine added
 
 ⇢
96.97%
FieldName added
 
 ⇢
97.86%
AbstractField added
 
 ⇢
100%
PreviewMode added
⋮ view more  
50%
 ↗
100%
 FieldType improved
50%
 ↘
18.18%
 DocumentField got worse
81.82%
 ↗
100%
 Audit improved
86.36%
 ↘
77.55%
 Managers got worse
89.06%
 ↘
81.43%
 PublishAssistant got worse
90.63%
 ↗
96.88%
 UploadMedia improved
28.57%
 ↗
33.33%
 PublishedFilter improved
70.37%
 ↗
74.07%
 Filter improved
78.85%
 ↘
76.29%
 Page got worse
80%
 ↗
82.35%
 DeletePage improved
⋮ view more  
0%
 ↛
 
 ArchiveManager removed
0%
 ↛
 
 CheckPreviewTrait removed
12.5%
 ↛
 
 NullValidator removed
60%
 ↛
 
 StateMachine removed
80%
 ↛
 
 StateException removed
85.19%
 ↛
 
 FieldValidatorFactory removed
88.3%
 ↛
 
 Field removed
94.59%
 ↛
 
 Archivable removed
95.83%
 ↛
 
 Publishable removed
100%
 ↛
 
 ArchiveScope removed
⋮ view more  

CRAP Changes

 
 ⇢
8
StateMachine::validateTransitions() added
 
 ⇢
7
ValidationNames::removeEmptyTranslations() added
 
 ⇢
6.4859
DeleteManagedModel::handle() added
 
 ⇢
6
Managers::allAssistantClassNames() added
 
 ⇢
6
CheckPreviewTrait::isPreviewAllowed() added
 
 ⇢
6
UrlAssistant::validateModel() added
 
 ⇢
5.2742
StateMachine::canTransitionTo() added
 
 ⇢
5
AbstractField::defaultValueResolver() added
 
 ⇢
5
ValidationNames::removeKeysToBeRemoved() added
 
 ⇢
5
ValidationNames::replacePlaceholders() added
⋮ view more  
2.0054
 ↗
2.0078
 AbstractManager::indexCollection() got worse
3.0261
 ↘
3
 ArchiveAssistant::route() improved
5.0488
 ↘
5
 UploadMedia::sanitizeFilesParameter() improved
3.072
 ↘
3
 UpdateSections::removeExistingSets() improved
4.074
 ↘
4
 UploadMedia::addFiles() improved
4
 ↗
4.128
 Page::flatReferenceLabel() got worse
4.1755
 ↘
4.0218
 UrlSlugField::rawSlugValue() improved
4.3731
 ↘
4.0466
 Filter::__call() improved
7
 ↗
7.6024
 PublishAssistant::publicationStatusAsLabel() got worse
1
 ↗
2
 ArchiveAssistant::isArchived() got worse
⋮ view more  
30
 ↛
 
 Field::translateValue() removed
30
 ↛
 
 StateMachine::canTransitionTo() removed
8
 ↛
 
 StateMachine::validateTransitions() removed
6
 ↛
 
 StateMachine::assertNewState() removed
6
 ↛
 
 DocumentField::translateName() removed
6
 ↛
 
 CheckPreviewTrait::isPreviewAllowed() removed
5
 ↛
 
 FieldValidatorFactory::normalizeRules() removed
5
 ↛
 
 LocalizedFieldValidationRules::influenceByPayload(... removed
4.5923
 ↛
 
 FieldValidatorFactory::create() removed
4
 ↛
 
 LocalizedFieldValidationRules::rules() removed
⋮ view more