View GitHub Repository chief

Schedule Inspection
Subscribe
Passed
Pull Request — master (#303)
by Philippe
61:32 queued 02:56
created

3,222 +36 Covered Lines

4,068 +29 Total Lines

79.2 % +0.3% Code Coverage

PHP Classes Changes

 
 ⇢
0%
CheckPreviewTrait added
 
 ⇢
70.83%
DeleteManagedModel added
 
 ⇢
71.43%
Publishable added
 
 ⇢
80%
StateException added
 
 ⇢
92.86%
StateMachine added
 
 ⇢
100%
PageState added
 
 ⇢
100%
Archivable added
 
 ⇢
100%
PageStatePresenter added
 
 ⇢
100%
PreviewMode added
 
 ⇢
100%
ArchiveScope added
⋮ view more  
81.82%
 ↗
100%
 Audit improved
100%
 ↘
90.91%
 RenderingFields got worse
86.36%
 ↘
77.55%
 Managers got worse
89.06%
 ↘
81.43%
 PublishAssistant got worse
90.63%
 ↗
96.88%
 UploadMedia improved
28.57%
 ↗
33.33%
 PublishedFilter improved
71.79%
 ↗
74.36%
 UrlSlugField improved
78.85%
 ↘
76.29%
 Page got worse
80%
 ↗
82.35%
 DeletePage improved
83.87%
 ↘
82.14%
 UrlAssistant got worse
⋮ view more  
0%
 ↛
 
 ArchiveManager removed
0%
 ↛
 
 CheckPreviewTrait removed
60%
 ↛
 
 StateMachine removed
80%
 ↛
 
 StateException removed
94.59%
 ↛
 
 Archivable removed
95.83%
 ↛
 
 Publishable removed
100%
 ↛
 
 PreviewMode removed
100%
 ↛
 
 ArchiveScope removed
100%
 ↛
 
 DeleteManager removed
100%
 ↛
 
 AssistedManager removed

CRAP Changes

 
 ⇢
8
StateMachine::validateTransitions() added
 
 ⇢
6.4859
DeleteManagedModel::handle() added
 
 ⇢
6
CheckPreviewTrait::isPreviewAllowed() added
 
 ⇢
6
UrlAssistant::validateModel() added
 
 ⇢
6
Managers::allAssistantClassNames() added
 
 ⇢
5.2742
StateMachine::canTransitionTo() added
 
 ⇢
4
ManagesAssistants::getAssistantClass() added
 
 ⇢
3
ManagesAssistants::assistants() added
 
 ⇢
3
StateMachine::apply() added
 
 ⇢
3
StateMachine::allowedTransitions() added
⋮ view more  
2.0054
 ↗
2.0078
 AbstractManager::indexCollection() got worse
3.0261
 ↘
3
 ArchiveAssistant::route() improved
5.0488
 ↘
5
 UploadMedia::sanitizeFilesParameter() improved
3.072
 ↘
3
 UpdateSections::removeExistingSets() improved
4.074
 ↘
4
 UploadMedia::addFiles() improved
4
 ↗
4.128
 Page::flatReferenceLabel() got worse
4.1755
 ↘
4.0218
 UrlSlugField::rawSlugValue() improved
7
 ↗
7.6024
 PublishAssistant::publicationStatusAsLabel() got worse
1
 ↗
2
 ArchiveAssistant::isArchived() got worse
2
 ↘
1
 Audit::getAllActivityFor() improved
⋮ view more  
30
 ↛
 
 StateMachine::canTransitionTo() removed
8
 ↛
 
 StateMachine::validateTransitions() removed
6
 ↛
 
 CheckPreviewTrait::isPreviewAllowed() removed
6
 ↛
 
 StateMachine::assertNewState() removed
4
 ↛
 
 AssistedManager::getAssistantClass() removed
3
 ↛
 
 Archivable::archive() removed
3
 ↛
 
 StateMachine::apply() removed
2.0625
 ↛
 
 Publishable::scopePublished() removed
2
 ↛
 
 Archivable::getQualifiedArchivedAtColumn() removed
2
 ↛
 
 ArchiveManager::handle() removed
⋮ view more