thinkstudeo / laravel-rakshak

src/Middleware/VerifyTwoFactorOtp.php

<?php

namespace Thinkstudeo\Rakshak\Middleware;

use Closure;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Cache;
use Thinkstudeo\Rakshak\Rakshak;
use Thinkstudeo\Rakshak\RakshakSetting;

class VerifyTwoFactorOtp
{
    /**
     * Handle the incoming request.
     *
     * @param Request $request

The type Thinkstudeo\Rakshak\Middleware\Request was not found. Did you mean Request? If so, make sure to prefix the type with \.

     * @param Closure $next
     * @return void
     */
    public function handle($request, Closure $next)
    {
        if ($this->is2faEnabled()) {
            $user = Auth::user();
            if ($user->otp_expiry > Carbon::now()) {

Accessing otp_expiry on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                return $next($request);
            }

            $user->otp_token = Rakshak::generateOtp();

Accessing otp_token on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $user->save();

            Rakshak::sendOtp($user);

            return redirect(Rakshak::verifyOtpPath());

The expression return redirect(Thinkstudeo\Rakshak\Rakshak::verifyOtpPath()) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type void.

        }

        return $next($request);
    }

    /**
     * Determine whether the 2fa is enabled for the current user.
     *
     * @return bool
     */
    private function is2faEnabled()
    {
        $enabled = config('rakshak.enable_2fa');
        // $controlLevel = RakshakSetting::first()->control_level_2fa;
        $controlLevel = Cache::get('rakshak.control_level_2fa');

        if ($enabled && $controlLevel === 'admin') {
            return true;
        }

        if ($enabled && $controlLevel === 'user') {
            return Auth::user()->enable_2fa;

Accessing enable_2fa on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
    }
}