Thinkstudeo\Rakshak\Middleware\VerifyTwoFactorOtp::handle()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle($request, Closure $next)
    {
        if ($this->is2faEnabled()) {
            $user = Auth::user();
            if ($user->otp_expiry > Carbon::now()) {

Accessing otp_expiry on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                return $next($request);
            }

            $user->otp_token = Rakshak::generateOtp();

Accessing otp_token on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $user->save();

            Rakshak::sendOtp($user);

            return redirect(Rakshak::verifyOtpPath());

The expression return redirect(Thinkstudeo\Rakshak\Rakshak::verifyOtpPath()) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type void.

        }

        return $next($request);
    }